This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG46475a79f85b: [AIX][TLS] Diagnose use of unimplemented TLS
models (authored by NeHuang).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
NeHuang updated this revision to Diff 344258.
NeHuang added a comment.
Address review comment for the diagnostic message.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102070/new/
https://reviews.llvm.org/D102070
Files:
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM aside from the single quotes in the diagnostic.
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:548
+def err_aix_unsupported_tls_model : Error<"The tls model %0 is not yet
supported on
nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
LGTM. Maybe give this a couple of days to see if any other reviewers have
further input.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
NeHuang updated this revision to Diff 343743.
NeHuang added a comment.
Addressed review comment for the diagnostic message and update the test cases.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102070/new/
https://reviews.llvm.org/D102070
aaron.ballman added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:548
+def err_aix_unsupported_tls_model : Error<"The tls model %0 is not yet
supported on AIX">;
+
This neatly avoids the problem of diagnostics not starting
NeHuang updated this revision to Diff 343683.
NeHuang added a comment.
Update the test case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102070/new/
https://reviews.llvm.org/D102070
Files:
clang/include/clang/Basic/DiagnosticDriverKinds.td
NeHuang created this revision.
Herald added a reviewer: aaron.ballman.
NeHuang requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Add front end diagnostics to report error for unimplemented TLS models set by
- compiler option `-ftls-model`
-
