[PATCH] D128223: [clang] Cached linkage assertion for static locals of static function

2022-12-07 Thread David Tenty via Phabricator via cfe-commits
daltenty accepted this revision. daltenty added a comment. New revision LGTM, VisibleNoLinkage is typical reserved for types from inline functions so it doesn't seem sensible to return. Looking at the C++ standard, I'm not even convinced this is guaranteed to be the same object if the function

[PATCH] D128223: [clang] Cached linkage assertion for static locals of static function

2022-11-10 Thread Chris Bowler via Phabricator via cfe-commits
cebowleratibm added a comment. I believe the fix for a52d151f9dde7 inadvertently exposed a code path where by the linkage of a static local of a static function, which would otherwise return LinkageInfo::none() may now return VisibleNoLinkage depending on the incoming computation argument. I

[PATCH] D128223: [clang] Cached linkage assertion for static locals of static function

2022-11-10 Thread Chris Bowler via Phabricator via cfe-commits
cebowleratibm updated this revision to Diff 473756. cebowleratibm retitled this revision from "[clang] Linkage computation of static locals may require forcing visibility computation" to "[clang] Cached linkage assertion for static locals of static function". cebowleratibm edited the summary of