daltenty accepted this revision.
daltenty added a comment.
New revision LGTM, VisibleNoLinkage is typical reserved for types from inline
functions so it doesn't seem sensible to return. Looking at the C++ standard,
I'm not even convinced this is guaranteed to be the same object if the function
cebowleratibm added a comment.
I believe the fix for a52d151f9dde7 inadvertently exposed a code path where by
the linkage of a static local of a static function, which would otherwise
return LinkageInfo::none() may now return VisibleNoLinkage depending on the
incoming computation argument.
I
cebowleratibm updated this revision to Diff 473756.
cebowleratibm retitled this revision from "[clang] Linkage computation of
static locals may require forcing visibility computation" to "[clang] Cached
linkage assertion for static locals of static function".
cebowleratibm edited the summary of