[PATCH] D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa7477eb87fd: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and… (authored by xingxue). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode

daltenty accepted this revision. daltenty added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137986/new/ https://reviews.llvm.org/D137986 ___ cfe-commits mailing list

[PATCH] D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137986/new/ https://reviews.llvm.org/D137986

[PATCH] D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode

xingxue added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:110 + // The AIX library functions frexpl, ldexpl, and modfl are for 128-bit + // 'long double'. Map to the 'double' versions if it is 64-bit 'long + // double' mode. daltenty wrote: >

[PATCH] D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode

xingxue updated this revision to Diff 475853. xingxue marked 5 inline comments as done. xingxue edited the summary of this revision. xingxue added a comment. Addressed comments: - rename `AIXLongDoubleBuiltins` to `AIXLongDouble64Builtins` - test IR output instead of assembly output - fix a typo

[PATCH] D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode

daltenty added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:110 + // The AIX library functions frexpl, ldexpl, and modfl are for 128-bit + // 'long double'. Map to the 'double' versions if it is 64-bit 'long + // double' mode. I feel like we

[PATCH] D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:112 + // double' mode. + static SmallDenseMap AIXLongDoubleBuiltins{ + {Builtin::BI__builtin_frexpl, "frexp"}, Please rename to "AIXLongDouble64Builtins".

[PATCH] D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode

xingxue created this revision. xingxue added reviewers: rjmccall, hubert.reinterpretcast, daltenty, cebowleratibm. xingxue added a project: LLVM. Herald added a project: All. xingxue requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. AIX