[PATCH] D146719: [Clang] Improve diagnostics when using a concept as template argument

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGabf4a8cb15d4: [Clang] Improve diagnostics when using a concept as template argument (authored by cor3ntin). Changed prior to commit: https://revie

[PATCH] D146719: [Clang] Improve diagnostics when using a concept as template argument

erichkeane accepted this revision. erichkeane added a comment. Yeah, LGTM too. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146719/new/ https://reviews.llvm.org/D146719 ___ cfe-commits mailing

[PATCH] D146719: [Clang] Improve diagnostics when using a concept as template argument

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please give @erichkeane a chance to give it a second set of eyes given he's been knee-deep in concepts recently. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D146719: [Clang] Improve diagnostics when using a concept as template argument

cor3ntin added a comment. Comment at: clang/lib/Parse/Parser.cpp:1886-1889 + case Sema::NC_Concept: case Sema::NC_VarTemplate: case Sema::NC_FunctionTemplate: case Sema::NC_UndeclaredTemplate: { aaron.ballman wrote: > cor3ntin wrote: > > aaron.ballma

[PATCH] D146719: [Clang] Improve diagnostics when using a concept as template argument

cor3ntin added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146719/new/ https://reviews.llvm.org/D146719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D146719: [Clang] Improve diagnostics when using a concept as template argument

aaron.ballman added inline comments. Comment at: clang/lib/Parse/Parser.cpp:1886-1889 + case Sema::NC_Concept: case Sema::NC_VarTemplate: case Sema::NC_FunctionTemplate: case Sema::NC_UndeclaredTemplate: { cor3ntin wrote: > aaron.ballman wrote: > > Woul

[PATCH] D146719: [Clang] Improve diagnostics when using a concept as template argument

cor3ntin added inline comments. Comment at: clang/lib/Parse/Parser.cpp:1886-1889 + case Sema::NC_Concept: case Sema::NC_VarTemplate: case Sema::NC_FunctionTemplate: case Sema::NC_UndeclaredTemplate: { aaron.ballman wrote: > Would this change make sense,

[PATCH] D146719: [Clang] Improve diagnostics when using a concept as template argument

cor3ntin updated this revision to Diff 508299. cor3ntin added a comment. - Address Aaron's and Erich's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146719/new/ https://reviews.llvm.org/D146719 Files: clang/docs/ReleaseNotes.rst clang

[PATCH] D146719: [Clang] Improve diagnostics when using a concept as template argument

aaron.ballman added a comment. Want to add a release note for this as well? Comment at: clang/lib/Parse/Parser.cpp:1886-1889 + case Sema::NC_Concept: case Sema::NC_VarTemplate: case Sema::NC_FunctionTemplate: case Sema::NC_UndeclaredTemplate: { Would

[PATCH] D146719: [Clang] Improve diagnostics when using a concept as template argument

cor3ntin added inline comments. Comment at: clang/test/Parser/cxx-template-template-recovery.cpp:27 + +static_assert(test); //expected-error {{too few template arguments for concept 'C1'}} +static_assert(test); //expected-error {{too few template arguments for concept 'C2'}} --

[PATCH] D146719: [Clang] Improve diagnostics when using a concept as template argument

erichkeane added a comment. This generally looks good to me, but I get lost in the parser pretty quick, so hoping one of the other reviewers can take a look. Comment at: clang/test/Parser/cxx-template-template-recovery.cpp:27 + +static_assert(test); //expected-error {{too few

[PATCH] D146719: [Clang] Improve diagnostics when using a concept as template argument

cor3ntin added a comment. Compiler explorer link demonstrating the issue this fixes https://godbolt.org/z/Tj3v5jbnq Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146719/new/ https://reviews.llvm.org/D146719 ___

[PATCH] D146719: [Clang] Improve diagnostics when using a concept as template argument

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When using the name of a template variable or concept in places where an expression was expected, Clang would drop the cxx