This revision was automatically updated to reflect the committed changes.
Closed by commit rL284233: [clang-move] Add header guard for the new header.
(authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D25610?vs=74663&id=74669#toc
Repository:
rL LLVM
https://reviews.llv
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:264
+HeaderGuard += "#define " + GuardName + "\n";
+clang::tooling::Replacement HeaderGuardInclude(FileName, 0, 0,
+ HeaderGuard);
ioeric
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg
Comment at: clang-move/ClangMove.cpp:264
+HeaderGuard += "#define " + GuardName + "\n";
+clang::tooling::Replacement HeaderGuardInclude(FileName, 0, 0,
+
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
The header guard generated by clang-move isn't always a perfect
style, just avoid getting the header included multiple times during
compiling period.
Also, we can use llvm-Header-guard clang-tid
