saugustine closed this revision.
saugustine added a comment.
Committed as https://reviews.llvm.org/rL319474.
https://reviews.llvm.org/D36431
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
saugustine added a comment.
In https://reviews.llvm.org/D36431#940169, @nemanjai wrote:
> This has been sitting in approved state for more than 2 months. As far as I
> can tell, it wasn't committed. Do you plan to commit this soon or are you
> abandoning it for some reason?
My apologies. I ha
nemanjai added a comment.
This has been sitting in approved state for more than 2 months. As far as I can
tell, it wasn't committed. Do you plan to commit this soon or are you
abandoning it for some reason?
https://reviews.llvm.org/D36431
___
cfe-
echristo accepted this revision.
echristo added a comment.
This is great with me.
https://reviews.llvm.org/D36431
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nemanjai accepted this revision.
nemanjai added subscribers: hfinkel, echristo.
nemanjai added a comment.
This revision is now accepted and ready to land.
I hope I haven't lost track of the patches that precluded this. If I remember
correctly, all the X86 80-bit stuff was sorted out. We now know
nemanjai added a comment.
Some buildbots use the distro gcc (looks like 5.4) and at least one uses gcc
7.1. I use gcc 6.2.
I think that with the addition of https://reviews.llvm.org/D36555, the empty
source file warnings should go away. However, I imagine that the warnings about
atomics will st
saugustine added a comment.
In https://reviews.llvm.org/D36431#835165, @nemanjai wrote:
> This patch appears to be perfectly fine. However, it triggers a large number
> of warnings. Namely, there's a large number of `warning: ISO C forbids an
> empty translation unit [-Wpedantic]` warnings prod
nemanjai added a comment.
This patch appears to be perfectly fine. However, it triggers a large number of
warnings. Namely, there's a large number of `warning: ISO C forbids an empty
translation unit [-Wpedantic]` warnings produced.
The reason is that all the code in the file is wrapped with an
