This revision was automatically updated to reflect the committed changes.
Closed by commit rL316900: [analyzer] Use the signature of the primary template
for issue hash calculation (authored by xazax).
Changed prior to commit:
https://reviews.llvm.org/D38728?vs=118788=120804#toc
Repository:
zaks.anna accepted this revision.
zaks.anna added a comment.
LGTM!
https://reviews.llvm.org/D38728
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun updated this revision to Diff 118788.
xazax.hun added a comment.
- Rebase based on the dependent revision and minor cleanups
https://reviews.llvm.org/D38728
Files:
lib/StaticAnalyzer/Core/IssueHash.cpp
test/Analysis/bug_hash_test.cpp
test/Analysis/edges-new.mm
Index:
NoQ added a comment.
The other way round, i guess. I like the test change, it's easier to
understand, so it's better to have it before starting to understand :)
https://reviews.llvm.org/D38728
___
cfe-commits mailing list
xazax.hun added a comment.
In https://reviews.llvm.org/D38728#895669, @NoQ wrote:
> I think it would be great to split them into two different patches, to be
> able to easily see how the change in the hashing affects the tests (and maybe
> revert easily if something goes wrong).
So you would
NoQ added a comment.
Ideas behind both hashing change and new testing mechanism look great to me.
I think it would be great to split them into two different patches, to be able
to easily see how the change in the hashing affects the tests (and maybe revert
easily if something goes wrong).
martong added inline comments.
Comment at: test/Analysis/bug_hash_test.cpp:105
+void g() {
+ TX x;
+ TX xl;
As we discussed, the checking of the equality of the `IssueString` in case of
`TX` and `TX` is implicit. And as such it is hard to see that it
is
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Core/IssueHash.cpp:39
+ // primary template.
+ if (const FunctionDecl *InstantiatedFrom =
+ Target->getInstantiatedFromMemberFunction())
martong wrote:
> Could we use here
martong added inline comments.
Comment at: lib/StaticAnalyzer/Core/IssueHash.cpp:39
+ // primary template.
+ if (const FunctionDecl *InstantiatedFrom =
+ Target->getInstantiatedFromMemberFunction())
Could we use here FunctionDecl::getPrimaryTemplate()
