This revision was automatically updated to reflect the committed changes.
Closed by commit rL327460: [OpenMP] Add flag for linking runtime bitcode
library (authored by gbercea, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43197?vs=1
gtbercea updated this revision to Diff 138275.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/Inputs/libomptarget/libomptarget-nvptx-sm_20.bc
test/Driver/openmp-offload-gpu.c
Index: t
gtbercea updated this revision to Diff 138274.
gtbercea added a comment.
- Revert
- Add back.
- Improve tests.
- Add bclib.
- Fix.
- Fix.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
test/Driver/openmp-offload-gpu.c
Index: test/Driver/openmp-offload-gpu.c
=
gtbercea updated this revision to Diff 138266.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/Inputs/libomptarget/libomptarget-nvptx-sm_20.bc
test/Driver/openmp-offload-gpu.c
Index: t
gtbercea updated this revision to Diff 138265.
gtbercea added a comment.
Update patch manually.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/Inputs/libomptarget/libomptarget-nvptx-sm_
gtbercea updated this revision to Diff 138262.
gtbercea added a comment.
Test.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
test/Driver/openmp-offload-gpu.c
Index: test/Driver/openmp-offload-gpu.c
===
--- test
gtbercea updated this revision to Diff 138261.
gtbercea added a comment.
Add bclib.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
test/Driver/openmp-offload-gpu.c
Index: test/Driver/openmp-offload-gpu.c
===
---
gtbercea updated this revision to Diff 138260.
gtbercea added a comment.
Improve test robustness for the case when CUDA libdevice cannot be found.
Check that the warning is not emitted when the bc lib is found.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
test/Driver/Inputs/
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327438: [OpenMP] Add flag for linking runtime bitcode
library (authored by gbercea, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43197?vs=138242&id=138245#toc
Repository:
rC Cla
ABataev accepted this revision.
ABataev added a comment.
LG
Repository:
rC Clang
https://reviews.llvm.org/D43197
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
gtbercea updated this revision to Diff 138242.
gtbercea added a comment.
Address comments.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/Inputs/libomptarget/libomptarget-nvptx-sm_20.bc
ABataev added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:595-596
+// Add user defined library paths from LIBRARY_PATH.
+if (llvm::Optional LibPath =
+ llvm::sys::Process::GetEnv("LIBRARY_PATH")) {
+ SmallVector Frags;
Move t
gtbercea updated this revision to Diff 138002.
gtbercea added a comment.
Add input file.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/Inputs/libomptarget/libomptarget-nvptx-sm_20.bc
gtbercea updated this revision to Diff 138001.
gtbercea added a comment.
Fixes.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Driver/openmp-offload-g
gtbercea updated this revision to Diff 138000.
gtbercea added a comment.
Rename folder. Fix test.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Drive
gtbercea updated this revision to Diff 137999.
gtbercea added a comment.
Herald added a subscriber: jholewinski.
Change name of folder.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGOpenMPRu
Hahnfeld added inline comments.
Comment at: test/Driver/openmp-offload-gpu.c:150
+/// bitcode library and add it to the LIBRARY_PATH.
+// RUN: touch %T/libomptarget-nvptx-sm_60.bc
+// RUN: env LIBRARY_PATH=%T %clang -### -fopenmp=libomp
-fopenmp-targets=nvptx64-nvidia-cuda \
gtbercea added inline comments.
Comment at: test/Driver/openmp-offload-gpu.c:150
+/// bitcode library and add it to the LIBRARY_PATH.
+// RUN: touch %T/libomptarget-nvptx-sm_60.bc
+// RUN: env LIBRARY_PATH=%T %clang -### -fopenmp=libomp
-fopenmp-targets=nvptx64-nvidia-cuda \
gtbercea updated this revision to Diff 137769.
gtbercea added a comment.
Fix test.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/Inputs/lib/libomptarget-nvptx-sm_20.bc
test/Driver/op
Hahnfeld added inline comments.
Comment at: test/Driver/openmp-offload-gpu.c:150
+/// bitcode library and add it to the LIBRARY_PATH.
+// RUN: touch %T/libomptarget-nvptx-sm_60.bc
+// RUN: env LIBRARY_PATH=%T %clang -### -fopenmp=libomp
-fopenmp-targets=nvptx64-nvidia-cuda \
gtbercea added inline comments.
Comment at: test/Driver/openmp-offload-gpu.c:150
+/// bitcode library and add it to the LIBRARY_PATH.
+// RUN: touch %T/libomptarget-nvptx-sm_60.bc
+// RUN: env LIBRARY_PATH=%T %clang -### -fopenmp=libomp
-fopenmp-targets=nvptx64-nvidia-cuda \
gtbercea updated this revision to Diff 137755.
gtbercea added a comment.
Revert to c_str().
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/Inputs/lib/libomptarget-nvptx-sm_60.bc
test/
gtbercea added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:592
+Twine("lib") + CLANG_LIBDIR_SUFFIX);
+LibraryPaths.emplace_back(DefaultLibPath.c_str());
+
ABataev wrote:
> Do you still need `.c_str()` here?
Doesn't compile without it b
Hahnfeld added inline comments.
Comment at: test/Driver/openmp-offload-gpu.c:150
+/// bitcode library and add it to the LIBRARY_PATH.
+// RUN: touch %T/libomptarget-nvptx-sm_60.bc
+// RUN: env LIBRARY_PATH=%T %clang -### -fopenmp=libomp
-fopenmp-targets=nvptx64-nvidia-cuda \
gtbercea updated this revision to Diff 137754.
gtbercea added a comment.
Change test.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/Inputs/lib/libomptarget-nvptx-sm_60.bc
test/Driver
grokos added inline comments.
Comment at: test/Driver/openmp-offload-gpu.c:150
+/// bitcode library and add it to the LIBRARY_PATH.
+// RUN: touch %T/libomptarget-nvptx-sm_60.bc
+// RUN: env LIBRARY_PATH=%T %clang -### -fopenmp=libomp
-fopenmp-targets=nvptx64-nvidia-cuda \
-
gtbercea marked an inline comment as done.
gtbercea added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:536-542
+ StringRef CompilerPath = env;
+ while (!CompilerPath.empty()) {
+std::pair Split =
+CompilerPath.split(llvm::sys::EnvPathS
ABataev added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:592
+Twine("lib") + CLANG_LIBDIR_SUFFIX);
+LibraryPaths.emplace_back(DefaultLibPath.c_str());
+
Do you still need `.c_str()` here?
Comment at: test/Driver/ope
Hahnfeld added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:536-542
+ StringRef CompilerPath = env;
+ while (!CompilerPath.empty()) {
+std::pair Split =
+CompilerPath.split(llvm::sys::EnvPathSeparator);
+LibraryPaths.push_back(
gtbercea added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:536-542
+ StringRef CompilerPath = env;
+ while (!CompilerPath.empty()) {
+std::pair Split =
+CompilerPath.split(llvm::sys::EnvPathSeparator);
+LibraryPaths.push_back(
gtbercea updated this revision to Diff 137233.
gtbercea added a comment.
- Fix message and test.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Driver
gtbercea updated this revision to Diff 137230.
gtbercea added a comment.
Fix test.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Driver/openmp-offloa
gtbercea updated this revision to Diff 137226.
gtbercea added a comment.
Address comments.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Driver/openm
ABataev added inline comments.
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:207-208
+def remark_drv_omp_offload_target_missingbcruntime : Warning<
+ "Expect degraded performance on the target device due to missing '%0' in
LIBRARY_PATH.">,
+ InGroup;
def err_drv_bi
gtbercea updated this revision to Diff 137219.
gtbercea added a comment.
Address comments.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Driver/openm
ABataev added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:591
+llvm::sys::path::append(DefaultLibPath, "lib" CLANG_LIBDIR_SUFFIX);
+LibraryPaths.emplace_back(DriverArgs.MakeArgString(DefaultLibPath));
+
Maybe just `LibraryPaths.emplace_bac
gtbercea updated this revision to Diff 137203.
gtbercea added a comment.
Address comments.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Driver/openm
ABataev added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:535
+SmallVector LibraryPaths;
+if (char *env = ::getenv("LIBRARY_PATH")) {
+ StringRef CompilerPath = env;
1. `char *`->`const char *`
2. `::getenv`->`llvm::Process::GetEnv`
Hahnfeld added a comment.
In https://reviews.llvm.org/D43197#1027139, @gtbercea wrote:
> In https://reviews.llvm.org/D43197#1011256, @Hahnfeld wrote:
>
> > Looking more closely at the patch, this doesn't seem to look into the `lib`
> > / `lib64` next to the compiler. I'm not sure if `LIBRARY_PAT
gtbercea added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:536-542
+ StringRef CompilerPath = env;
+ while (!CompilerPath.empty()) {
+std::pair Split =
+CompilerPath.split(llvm::sys::EnvPathSeparator);
+LibraryPaths.push_back(
gtbercea added a comment.
In https://reviews.llvm.org/D43197#1011256, @Hahnfeld wrote:
> Looking more closely at the patch, this doesn't seem to look into the `lib` /
> `lib64` next to the compiler. I'm not sure if `LIBRARY_PATH` is set for every
> installation, so I think we should add this on
Hahnfeld added a comment.
Looking more closely at the patch, this doesn't seem to look into the `lib` /
`lib64` next to the compiler. I'm not sure if `LIBRARY_PATH` is set for every
installation, so I think we should add this one to catch the obvious case. This
probably needs some attention for
gtbercea updated this revision to Diff 134295.
gtbercea added a comment.
Fix test.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Driver/openmp-offloa
gtbercea updated this revision to Diff 134292.
gtbercea added a comment.
Revert.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Driver/openmp-offload-
Hahnfeld added a comment.
In https://reviews.llvm.org/D43197#1007963, @gtbercea wrote:
> In https://reviews.llvm.org/D43197#1007918, @Hahnfeld wrote:
>
> > I'm still not sure we can't run this test on Windows. I think lots of other
> > tests use `touch`, even some specific to Windows...
>
>
> Le
gtbercea added a comment.
In https://reviews.llvm.org/D43197#1007918, @Hahnfeld wrote:
> I'm still not sure we can't run this test on Windows. I think lots of other
> tests use `touch`, even some specific to Windows...
Let me know what you'd like me to do. I can add the test back. I do see oth
Hahnfeld added a comment.
I'm still not sure we can't run this test on Windows. I think lots of other
tests use `touch`, even some specific to Windows...
Repository:
rC Clang
https://reviews.llvm.org/D43197
___
cfe-commits mailing list
cfe-commi
gtbercea updated this revision to Diff 134278.
gtbercea added a comment.
Use %T.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
test/Driver/unix-openmp-offload-gp
Hahnfeld added inline comments.
Comment at: test/Driver/unix-openmp-offload-gpu.c:15
+/// bitcode library that will be found via the LIBRARY_PATH.
+// RUN: touch /tmp/libomptarget-nvptx-sm_60.bc
+// RUN: env LIBRARY_PATH=/tmp
gtbercea wrote:
> Hahnfeld wrote:
gtbercea added inline comments.
Comment at: test/Driver/unix-openmp-offload-gpu.c:15
+/// bitcode library that will be found via the LIBRARY_PATH.
+// RUN: touch /tmp/libomptarget-nvptx-sm_60.bc
+// RUN: env LIBRARY_PATH=/tmp
Hahnfeld wrote:
> Hahnfeld wrote:
Hahnfeld added inline comments.
Comment at: test/Driver/openmp-offload-gpu.c:150
+/// bitcode library that will be found via the LIBRARY_PATH.
+// RUN: touch /tmp/libomptarget-nvptx-sm_60.bc
+// RUN: LIBRARY_PATH=/tmp %clang -### -fopenmp=libomp
-fopenmp-targets=nvptx64-nvid
gtbercea updated this revision to Diff 134238.
gtbercea added a comment.
Fix tmp folder name.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
test/Driver/unix-open
gtbercea marked an inline comment as done.
gtbercea added inline comments.
Comment at: test/Driver/openmp-offload-gpu.c:150
+/// bitcode library that will be found via the LIBRARY_PATH.
+// RUN: touch /tmp/libomptarget-nvptx-sm_60.bc
+// RUN: LIBRARY_PATH=/tmp %clang -### -fo
Hahnfeld added inline comments.
Comment at: test/Driver/unix-openmp-offload-gpu.c:15
+/// bitcode library that will be found via the LIBRARY_PATH.
+// RUN: touch /tmp/libomptarget-nvptx-sm_60.bc
+// RUN: env LIBRARY_PATH=/tmp
I don't see how that solves the p
gtbercea updated this revision to Diff 134235.
gtbercea added a comment.
Move unix specific test to new file.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
test/
Hahnfeld added inline comments.
Comment at: test/Driver/openmp-offload-gpu.c:150
+/// bitcode library that will be found via the LIBRARY_PATH.
+// RUN: touch /tmp/libomptarget-nvptx-sm_60.bc
+// RUN: LIBRARY_PATH=/tmp %clang -### -fopenmp=libomp
-fopenmp-targets=nvptx64-nvid
gtbercea updated this revision to Diff 133919.
gtbercea added a comment.
Add regression tests.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Driver/o
grokos accepted this revision.
grokos added a comment.
This revision is now accepted and ready to land.
I don't have any other remarks, looks good.
Repository:
rC Clang
https://reviews.llvm.org/D43197
___
cfe-commits mailing list
cfe-commits@list
gtbercea updated this revision to Diff 133882.
gtbercea added a comment.
Fix warning message.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
Index: lib/Driver/ToolChains/Cuda.cpp
==
grokos added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:559
+if (!FoundBCLibrary)
+ getDriver().Diag(diag::remark_drv_omp_offload_target_missingbcruntime);
+ }
Should we be more specific when it comes to the name of the missing bc file
gtbercea created this revision.
gtbercea added reviewers: Hahnfeld, ABataev, carlo.bertolli, caomhin, grokos.
Herald added subscribers: cfe-commits, guansong.
This patch adds an additional flag to the OpenMP device offloading toolchain to
link in the runtime library bitcode.
Repository:
rC Cl
61 matches
Mail list logo
