[PATCH] D45289: Disable -fmerge-all-constants as default.

This revision was automatically updated to reflect the committed changes. Closed by commit rC329300: Disable -fmerge-all-constants as default. (authored by manojgupta, committed by ). Changed prior to commit: https://reviews.llvm.org/D45289?vs=141081&id=141164#toc Repository: rC Clang https

[PATCH] D45289: Disable -fmerge-all-constants as default.

This revision was automatically updated to reflect the committed changes. Closed by commit rL329300: Disable -fmerge-all-constants as default. (authored by manojgupta, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D45289 Files: cfe/tru

[PATCH] D45289: Disable -fmerge-all-constants as default.

manojgupta added inline comments. Comment at: include/clang/Driver/Options.td:1286 def fno_merge_all_constants : Flag<["-"], "fno-merge-all-constants">, Group, Flags<[CC1Option]>, HelpText<"Disallow merging of constants">; def fno_modules : Flag <["-"], "fno-modules">, Gr

[PATCH] D45289: Disable -fmerge-all-constants as default.

manojgupta updated this revision to Diff 141081. manojgupta added a comment. Bring back Help Text for "-fno-merge-all-constants" Repository: rC Clang https://reviews.llvm.org/D45289 Files: include/clang/Driver/Options.td lib/AST/ExprConstant.cpp lib/Driver/ToolChains/Clang.cpp lib/Fr

[PATCH] D45289: Disable -fmerge-all-constants as default.

rjmccall added inline comments. Comment at: include/clang/Driver/Options.td:1286 def fno_merge_all_constants : Flag<["-"], "fno-merge-all-constants">, Group, Flags<[CC1Option]>, HelpText<"Disallow merging of constants">; def fno_modules : Flag <["-"], "fno-modules">, Grou

[PATCH] D45289: Disable -fmerge-all-constants as default.

manojgupta updated this revision to Diff 141075. manojgupta added a comment. Removed unused CC1 option and updated broken tests. Repository: rC Clang https://reviews.llvm.org/D45289 Files: include/clang/Driver/Options.td lib/AST/ExprConstant.cpp lib/Driver/ToolChains/Clang.cpp lib/Fr

[PATCH] D45289: Disable -fmerge-all-constants as default.

rjmccall added a comment. It's not unreasonable to just add -fmerge-all-constants to the command line invocations for the individual tests, yeah. We can take those off as necessary later. Repository: rC Clang https://reviews.llvm.org/D45289 __

[PATCH] D45289: Disable -fmerge-all-constants as default.

manojgupta added a comment. Thanks a lot for the quick review! There a bunch of broken tests because of different IR generated. Is it preferable to fix them individually or add the option -fmerge-all-constants to clang arguments to avoid figuring out changes needed to fix the tests? Reposito

[PATCH] D45289: Disable -fmerge-all-constants as default.

chandlerc accepted this revision. chandlerc added a comment. Just wanted to explicitly say +1 to this default change (with the adjustment Richard suggested). Also, John already said +1 to this default change on the bug. Repository: rC Clang https://reviews.llvm.org/D45289 ___

[PATCH] D45289: Disable -fmerge-all-constants as default.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. One minor change, then this looks good to me. Thank you! Comment at: include/clang/Driver/Options.td:1286 def fno_merge_all_constants : Flag<["-"], "fno-merge-all-constants"

[PATCH] D45289: Disable -fmerge-all-constants as default.

manojgupta created this revision. manojgupta added reviewers: rjmccall, rsmith, chandlerc. "-fmerge-all-constants" is a non-conforming optimization and should not be the default. It is also causing miscompiles when building Linux Kernel (https://lkml.org/lkml/2018/3/20/872). Fixes PR18538. Repo