This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE329578: [clangd] Allow using customized include path in
URI. (authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45426?vs=141654=141655#toc
Repository:
rCTE
hokein updated this revision to Diff 141654.
hokein marked an inline comment as done.
hokein added a comment.
includeSpelling
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45426
Files:
clangd/ClangdServer.cpp
clangd/URI.cpp
clangd/URI.h
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/URI.h:69
+ /// calculate the include path from the resolved absolute path.
+ static llvm::Expected includePath(const URI );
+
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clangd/URI.h:66
+ ///
+ /// If the returned string is non-empty, clangd will use it directly when
+ /// doing include insertion; otherwise we will fall back to the clang to
hokein updated this revision to Diff 141650.
hokein marked 3 inline comments as done.
hokein added a comment.
Address review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45426
Files:
clangd/ClangdServer.cpp
clangd/URI.cpp
clangd/URI.h
sammccall added inline comments.
Comment at: clangd/URI.h:63
+ /// Tries to get the include path of the file corresponding to the URI.
+ /// This allows clients to provide their customized include paths.
Avoid "tries to" which is vague about what cases are
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: MaskRay, ioeric, jkorous-apple, ilya-biryukov, klimek.
Calculating the include path from absolute file path does not always
work for all build system, e.g. bazel uses symlink as the build working
