This revision was automatically updated to reflect the committed changes.
yaxunl marked an inline comment as done.
Closed by commit rL331811: [HIP] Add hip offload kind (authored by yaxunl,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:133-135
Work(*C.getSingleOffloadToolChain());
+ if (JA.isHostOffloading(Action::OFK_HIP))
tra wrote:
> CUDA and HIP are mutually exclusive,
tra accepted this revision.
tra added a comment.
Small nit. LGTM otherwise.
Comment at: lib/Driver/ToolChains/Clang.cpp:133-135
Work(*C.getSingleOffloadToolChain());
+ if (JA.isHostOffloading(Action::OFK_HIP))
CUDA and HIP are mutually exclusive, so
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
https://reviews.llvm.org/D46471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
yaxunl updated this revision to Diff 145472.
yaxunl marked 2 inline comments as done.
yaxunl added a comment.
Updated comments.
https://reviews.llvm.org/D46471
Files:
include/clang/Driver/Action.h
lib/Driver/Action.cpp
lib/Driver/Compilation.cpp
lib/Driver/ToolChains/Clang.cpp
Index:
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: lib/Driver/Compilation.cpp:201
+ // not compiled again if there are already failures. It is OK to abort the
+ // CUDA pipeline on errors.
+ if (A->isOffloading(Action::OFK_Cuda) ||
rjmccall added a comment.
Otherwise LGTM.
Comment at: lib/Driver/Compilation.cpp:201
+ // not compiled again if there are already failures. It is OK to abort the
+ // CUDA pipeline on errors.
+ if (A->isOffloading(Action::OFK_Cuda) || A->isOffloading(Action::OFK_HIP))
yaxunl created this revision.
yaxunl added reviewers: rjmccall, tra.
There are quite differences in HIP action builder and action job creation,
which justifies to define a separate offload kind.
https://reviews.llvm.org/D46471
Files:
include/clang/Driver/Action.h
lib/Driver/Action.cpp
