[PATCH] D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend

tra added a comment. > I would be ok with reusing that option, as long as it's documented that there > is a difference in terms of how it can be used. The patch is in https://reviews.llvm.org/D57487 It does not look like we're formally documenting CC1 options anywhere. I've added some comments

[PATCH] D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend

arphaman added a comment. In D55673#1377404 , @tra wrote: > Would that be OK to use target_sdk_version to pass *CUDA* SDK version to the > CC1 compilations? > I have upcoming changes that need to know the version to generate correct > glue IR for CUDA.

[PATCH] D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend

tra added a comment. Would that be OK to use target_sdk_version to pass *CUDA* SDK version to the CC1 compilations? I have upcoming changes that need to know the version to generate correct glue IR for CUDA. The driver currently figures out detected CUDA version in

[PATCH] D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend

This revision was automatically updated to reflect the committed changes. Closed by commit rC349380: [darwin] parse the SDK settings from SDKSettings.json if it exists and (authored by arphaman, committed by ). Changed prior to commit: https://reviews.llvm.org/D55673?vs=178309=178501#toc

[PATCH] D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend

steven_wu added inline comments. Comment at: include/clang/Driver/DarwinSDKInfo.h:36 +/// SDK has no SDKSettings.json, or a valid \c DarwinSDKInfo otherwise. +Expected> parseDarwinSDKInfo(llvm::vfs::FileSystem , + StringRef

[PATCH] D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend

arphaman marked an inline comment as done. arphaman added inline comments. Comment at: include/clang/Driver/DarwinSDKInfo.h:36 +/// SDK has no SDKSettings.json, or a valid \c DarwinSDKInfo otherwise. +Expected> parseDarwinSDKInfo(llvm::vfs::FileSystem , +

[PATCH] D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. Other than a small design choice commented inline, LGTM. Comment at: include/clang/Driver/DarwinSDKInfo.h:36 +/// SDK has no SDKSettings.json, or a valid \c

[PATCH] D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend

arphaman updated this revision to Diff 178309. arphaman marked an inline comment as done. arphaman added a comment. Ensure test will pass on non-darwin. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55673/new/ https://reviews.llvm.org/D55673 Files:

[PATCH] D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend

arphaman marked 2 inline comments as done. arphaman added inline comments. Comment at: lib/Driver/ToolChains/Darwin.cpp:2053 +return None; + } + return *SDKInfoOrErr; steven_wu wrote: > We also has this InferredFromSDK when we infer deployment target,

[PATCH] D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend

arphaman updated this revision to Diff 178307. arphaman added a comment. Updated to infer deployment target version from SDK versions specified in the JSON file and to allow inferring the SDK version from the SDK path. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend

arphaman marked an inline comment as done. arphaman added inline comments. Comment at: include/clang/Driver/DarwinSDKInfo.h:36 +/// SDK has no SDKSettings.json, or a valid \c DarwinSDKInfo otherwise. +Expected> parseDarwinSDKInfo(llvm::vfs::FileSystem , +

[PATCH] D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend

arphaman marked an inline comment as done. arphaman added inline comments. Comment at: include/clang/Driver/DarwinSDKInfo.h:1 +//===--- DarwinSDKInfo.h - SDK Information parser for darwin *- C++ -*-===// +// steven_wu wrote: > Can this just be in

[PATCH] D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend

steven_wu added a comment. See comments inline. Comment at: include/clang/Driver/DarwinSDKInfo.h:1 +//===--- DarwinSDKInfo.h - SDK Information parser for darwin *- C++ -*-===// +// Can this just be in Toolchains/Darwin.h? Comment at:

[PATCH] D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend

arphaman created this revision. arphaman added reviewers: steven_wu, ab, dexonsmith. Herald added subscribers: jkorous, mgorny. This patch is a follow-up to the LLVM SDK Version metadata support: https://reviews.llvm.org/D55612. This patch adds support for reading the `SDKSettings.json` file in