[PATCH] D59457: [analyzer][NFC] Use capital variable names, move methods out-of-line, rename some in CheckerRegistry

2019-04-18 Thread Kristóf Umann via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL358676: [analyzer][NFC] Use capital variable names, move methods out-of-line, rename… (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D59457: [analyzer][NFC] Use capital variable names, move methods out-of-line, rename some in CheckerRegistry

2019-03-27 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I agree that we shouldn't try real hard to fix our code until we have a clear "party line" on how exactly do we name our variables (and ideally also how do we invalidate our caches), but having

[PATCH] D59457: [analyzer][NFC] Use capital variable names, move methods out-of-line, rename some in CheckerRegistry

2019-03-27 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59457/new/ https://reviews.llvm.org/D59457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59457: [analyzer][NFC] Use capital variable names, move methods out-of-line, rename some in CheckerRegistry

2019-03-19 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. In D59457#1433180 , @baloghadamsoftware wrote: > Please rename the patch. Its name does not really express its content. Good point, sorry about that. In D59457#1433816 , @xazax.hun