This revision was automatically updated to reflect the committed changes.
Closed by commit rL358274: [clangd] Show template argument list in
workspacesymbols and documentsymbols… (authored by kadircet, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed
ilya-biryukov accepted this revision.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/AST.cpp:112
if (!Out.str().empty()) {
-// FIXME(ibiryukov): do
kadircet marked an inline comment as done.
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/AST.cpp:112
if (!Out.str().empty()) {
-// FIXME(ibiryukov): do not show args not explicitly written by the user.
-if (auto *ArgList =
kadircet updated this revision to Diff 194810.
kadircet added a comment.
- Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59641/new/
https://reviews.llvm.org/D59641
Files:
clang-tools-extra/clangd/FindSymbols.cpp
kadircet marked an inline comment as done.
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/AST.cpp:112
if (!Out.str().empty()) {
-// FIXME(ibiryukov): do not show args not explicitly written by the user.
-if (auto *ArgList =
ilya-biryukov added a comment.
LG, just have a simple clarifying question.
Comment at: clang-tools-extra/clangd/AST.cpp:112
if (!Out.str().empty()) {
-// FIXME(ibiryukov): do not show args not explicitly written by the user.
-if (auto *ArgList =
kadircet created this revision.
kadircet added reviewers: ioeric, ilya-biryukov.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay.
Herald added a project: clang.
kadircet added a parent revision: D59640: [clangd] Add TemplateArgumentList
into Symbol.
kadircet added a subscriber:
