[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

svenvh added a comment. As a followup to r363496, I've added llvm-dwarfdump as a clang test dependency in r364021. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59673/new/ https://reviews.llvm.org/D59673 ___

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

This revision was automatically updated to reflect the committed changes. aaronpuchert marked 3 inline comments as done. Closed by commit rL363496: [Clang] Harmonize Split DWARF options with llc (authored by aaronpuchert, committed by ). Changed prior to commit:

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

tejohnson added inline comments. Comment at: llvm/include/llvm/LTO/Config.h:92 + /// The name for the split debug info file used for the DW_AT_[GNU_]dwo_name + /// attribute in the skeleton CU. + std::string SplitDwarfFile; aaronpuchert wrote: > tejohnson

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

aaronpuchert added inline comments. Comment at: llvm/include/llvm/LTO/Config.h:92 + /// The name for the split debug info file used for the DW_AT_[GNU_]dwo_name + /// attribute in the skeleton CU. + std::string SplitDwarfFile; tejohnson wrote: > Probably

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

tejohnson added a comment. lgtm for the LTO bits. Suggestion below for comment. Comment at: llvm/include/llvm/LTO/Config.h:92 + /// The name for the split debug info file used for the DW_AT_[GNU_]dwo_name + /// attribute in the skeleton CU. + std::string SplitDwarfFile;

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

aaronpuchert added a reviewer: tejohnson. aaronpuchert added a comment. Sorry for making the inline comments disappear, but I had to switch to the big repository. @tejohnson Could you have a look at the LTO-related changes (BackendUtil.cpp + all files with LTO in the name)? Repository: rG

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

aaronpuchert updated this revision to Diff 204661. aaronpuchert added a comment. Herald added subscribers: llvm-commits, dang, dexonsmith, steven_wu, hiraditya, mehdi_amini. Herald added a project: LLVM. Make sure the flags have the same meaning for LTO. Also slightly reworded the HelpText.

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

aaronpuchert added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:1345 Conf.RemarksPasses = CGOpts.OptRecordPasses; - Conf.DwoPath = CGOpts.SplitDwarfFile; + Conf.DwoPath = CGOpts.SplitDwarfOutput; switch (Action) { tejohnson wrote: >

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

tejohnson added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:1345 Conf.RemarksPasses = CGOpts.OptRecordPasses; - Conf.DwoPath = CGOpts.SplitDwarfFile; + Conf.DwoPath = CGOpts.SplitDwarfOutput; switch (Action) { aaronpuchert wrote: > tejohnson

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

aaronpuchert added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:1345 Conf.RemarksPasses = CGOpts.OptRecordPasses; - Conf.DwoPath = CGOpts.SplitDwarfFile; + Conf.DwoPath = CGOpts.SplitDwarfOutput; switch (Action) { tejohnson wrote: >

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

tejohnson added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:1345 Conf.RemarksPasses = CGOpts.OptRecordPasses; - Conf.DwoPath = CGOpts.SplitDwarfFile; + Conf.DwoPath = CGOpts.SplitDwarfOutput; switch (Action) { aaronpuchert wrote: >

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

aaronpuchert added a subscriber: tejohnson. aaronpuchert added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:1345 Conf.RemarksPasses = CGOpts.OptRecordPasses; - Conf.DwoPath = CGOpts.SplitDwarfFile; + Conf.DwoPath = CGOpts.SplitDwarfOutput; switch (Action) {

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59673/new/ https://reviews.llvm.org/D59673 ___

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

aaronpuchert marked 2 inline comments as done. aaronpuchert added a comment. In D59673#1521413 , @dblaikie wrote: > Might be easier as a few patches - renaming the existing option, D63130 > adding the new one, This

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

aaronpuchert updated this revision to Diff 204017. aaronpuchert added a comment. Correct an oversight. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59673/new/ https://reviews.llvm.org/D59673 Files: include/clang/Basic/CodeGenOptions.h

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

aaronpuchert updated this revision to Diff 204013. aaronpuchert added a comment. Split from other changes as suggested. A predecessor is in D63130 , and a successor will come soon. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

aaronpuchert added a comment. In D59673#1527487 , @aaronpuchert wrote: > In D59673#1521413 , @dblaikie wrote: > > > Might be easier as a few patches - renaming the existing option, adding the > > new one, then

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

aaronpuchert marked an inline comment as done. aaronpuchert added a comment. In D59673#1521413 , @dblaikie wrote: > Might be easier as a few patches - renaming the existing option, adding the > new one, then removing the single split dwarf flag handling

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

dblaikie added a comment. Might be easier as a few patches - renaming the existing option, adding the new one, then removing the single split dwarf flag handling in favor of implying that by the absence of an output file name. (if I'm reading what this patch does) Comment

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

aaronpuchert added a comment. Ping. I'm sorry that the change turned out so big, but note that it doesn't change the behavior of any non-cc1 flags. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59673/new/ https://reviews.llvm.org/D59673

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

aaronpuchert updated this revision to Diff 196156. aaronpuchert added a comment. Adapt one more test case. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59673/new/ https://reviews.llvm.org/D59673 Files: include/clang/Basic/CodeGenOptions.def

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

aaronpuchert added a subscriber: pcc. aaronpuchert added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:1345 Conf.RemarksPasses = CGOpts.OptRecordPasses; - Conf.DwoPath = CGOpts.SplitDwarfFile; + Conf.DwoPath = CGOpts.SplitDwarfOutput; switch (Action) {