[PATCH] D64614: [clangd] Mark type hierarchy as a supported feature in the docs
nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/docs/clangd/Features.rst:264 +-++--+ -| Type hierarchy | No | No | +| Type hierarchy | No | Yes| +-++--+ malaperle wrote: > nridge wrote: > > sammccall wrote: > > > nridge wrote: > > > > Should I perhaps change type hierarchy's entry in the LSP column from > > > > "No" to "Proposed"? > > > I'm not sure what "no" means, if it doesn't mean "proposed". > > > > > > Changing the "no" links to say "proposal" and link to it would be useful, > > > I think. > > > (And we could delete any rows that don't have a proposal) > > Good idea -- I'll look at that in a separate commit. > The rows that have "no" and don't have proposals meant that we wanted to make > proposals for the LSP eventually in order to match other IDEs feature. Many > didn't have proposals at the time. Right! I wouldn't delete any rows -- just maybe file (and link to) an LSP issue for any rows that don't already have proposals. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64614/new/ https://reviews.llvm.org/D64614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D64614: [clangd] Mark type hierarchy as a supported feature in the docs
malaperle added inline comments. Comment at: clang-tools-extra/docs/clangd/Features.rst:264 +-++--+ -| Type hierarchy | No | No | +| Type hierarchy | No | Yes| +-++--+ nridge wrote: > sammccall wrote: > > nridge wrote: > > > Should I perhaps change type hierarchy's entry in the LSP column from > > > "No" to "Proposed"? > > I'm not sure what "no" means, if it doesn't mean "proposed". > > > > Changing the "no" links to say "proposal" and link to it would be useful, I > > think. > > (And we could delete any rows that don't have a proposal) > Good idea -- I'll look at that in a separate commit. The rows that have "no" and don't have proposals meant that we wanted to make proposals for the LSP eventually in order to match other IDEs feature. Many didn't have proposals at the time. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64614/new/ https://reviews.llvm.org/D64614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D64614: [clangd] Mark type hierarchy as a supported feature in the docs
nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/docs/clangd/Features.rst:264 +-++--+ -| Type hierarchy | No | No | +| Type hierarchy | No | Yes| +-++--+ sammccall wrote: > nridge wrote: > > Should I perhaps change type hierarchy's entry in the LSP column from "No" > > to "Proposed"? > I'm not sure what "no" means, if it doesn't mean "proposed". > > Changing the "no" links to say "proposal" and link to it would be useful, I > think. > (And we could delete any rows that don't have a proposal) Good idea -- I'll look at that in a separate commit. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64614/new/ https://reviews.llvm.org/D64614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D64614: [clangd] Mark type hierarchy as a supported feature in the docs
This revision was automatically updated to reflect the committed changes. Closed by commit rL365987: [clangd] Mark type hierarchy as a supported feature in the docs (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D64614?vs=209408=209670#toc Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64614/new/ https://reviews.llvm.org/D64614 Files: clang-tools-extra/trunk/docs/clangd/Features.rst Index: clang-tools-extra/trunk/docs/clangd/Features.rst === --- clang-tools-extra/trunk/docs/clangd/Features.rst +++ clang-tools-extra/trunk/docs/clangd/Features.rst @@ -261,7 +261,7 @@ +-++--+ | Call hierarchy | No | No | +-++--+ -| Type hierarchy | No | No | +| Type hierarchy | No | Yes| +-++--+ | Organize Includes | No | No | +-++--+ Index: clang-tools-extra/trunk/docs/clangd/Features.rst === --- clang-tools-extra/trunk/docs/clangd/Features.rst +++ clang-tools-extra/trunk/docs/clangd/Features.rst @@ -261,7 +261,7 @@ +-++--+ | Call hierarchy | No | No | +-++--+ -| Type hierarchy | No | No | +| Type hierarchy | No | Yes| +-++--+ | Organize Includes | No | No | +-++--+ ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D64614: [clangd] Mark type hierarchy as a supported feature in the docs
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/docs/clangd/Features.rst:264 +-++--+ -| Type hierarchy | No | No | +| Type hierarchy | No | Yes| +-++--+ nridge wrote: > Should I perhaps change type hierarchy's entry in the LSP column from "No" to > "Proposed"? I'm not sure what "no" means, if it doesn't mean "proposed". Changing the "no" links to say "proposal" and link to it would be useful, I think. (And we could delete any rows that don't have a proposal) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64614/new/ https://reviews.llvm.org/D64614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D64614: [clangd] Mark type hierarchy as a supported feature in the docs
nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/docs/clangd/Features.rst:264 +-++--+ -| Type hierarchy | No | No | +| Type hierarchy | No | Yes| +-++--+ Should I perhaps change type hierarchy's entry in the LSP column from "No" to "Proposed"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64614/new/ https://reviews.llvm.org/D64614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D64614: [clangd] Mark type hierarchy as a supported feature in the docs
nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64614 Files: clang-tools-extra/docs/clangd/Features.rst Index: clang-tools-extra/docs/clangd/Features.rst === --- clang-tools-extra/docs/clangd/Features.rst +++ clang-tools-extra/docs/clangd/Features.rst @@ -261,7 +261,7 @@ +-++--+ | Call hierarchy | No | No | +-++--+ -| Type hierarchy | No | No | +| Type hierarchy | No | Yes| +-++--+ | Organize Includes | No | No | +-++--+ Index: clang-tools-extra/docs/clangd/Features.rst === --- clang-tools-extra/docs/clangd/Features.rst +++ clang-tools-extra/docs/clangd/Features.rst @@ -261,7 +261,7 @@ +-++--+ | Call hierarchy | No | No | +-++--+ -| Type hierarchy | No | No | +| Type hierarchy | No | Yes| +-++--+ | Organize Includes | No | No | +-++--+ ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
