[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script

Charusso marked an inline comment as done. Charusso added a comment. Thanks everyone! I hope the Analyzer developers start to use the wonderful features from Clang-Tidy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69746/new/ https://reviews.llvm.org/D69746

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script

This revision was automatically updated to reflect the committed changes. Closed by commit rGf69c74db34f4: [analyzer] FixItHint: Apply and test hints with the Clang-Tidys script (authored by Charusso). Changed prior to commit: https://reviews.llvm.org/D69746?vs=246209=248103#toc Repository:

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script

NoQ accepted this revision. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:92 + + bool IncludePath = false, ShouldEmitAsError = false, FixitsAsRemarks = false, + ApplyFixIts = false; Charusso wrote: > NoQ

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script

Charusso marked 2 inline comments as done. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:92 + + bool IncludePath = false, ShouldEmitAsError = false, FixitsAsRemarks = false, + ApplyFixIts = false; NoQ

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:92 + + bool IncludePath = false, ShouldEmitAsError = false, FixitsAsRemarks = false, + ApplyFixIts = false; Charusso wrote: > NoQ wrote: > > I'll be perfectly

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script

alexfh accepted this revision. alexfh added a comment. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69746/new/ https://reviews.llvm.org/D69746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script

Charusso updated this revision to Diff 246209. Charusso marked 4 inline comments as done. Charusso retitled this revision from "[analyzer] FixItHint: Apply and test hints with the Clang Tidy's script" to "[analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script". Charusso added a

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script

Charusso added a comment. Thanks for the reviews! Are we good to go? Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:112 void enableFixitsAsRemarks() { FixitsAsRemarks = true; } + void enableFixItApplication() { ApplyFixIts = true; }

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

alexfh added a comment. Herald added subscribers: martong, steakhal. A few nits. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:93 + + bool IncludePath = false, ShouldEmitAsError = false, FixitsAsRemarks = false, + ApplyFixIts = false;

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

Charusso updated this revision to Diff 241492. Charusso marked 8 inline comments as done. Charusso added a comment. - Change to 4-column space standard. - Simplify obtaining the Clang include directory. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69746/new/

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

Charusso updated this revision to Diff 241493. Charusso edited the summary of this revision. Charusso added a comment. - Rename the script from `check_analyzer_fixit.py` to `check-analyzer-fixit.py` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69746/new/

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

Charusso added a comment. Thanks for the reviews! Sorry for the delay. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69746/new/ https://reviews.llvm.org/D69746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:92 + + bool IncludePath = false, ShouldEmitAsError = false, FixitsAsRemarks = false, + ApplyFixIts = false; NoQ wrote: > I'll be perfectly happy with

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

alexfh added a comment. In D69746#1756448 , @gribozavr2 wrote: > The only way I know people apply fixits is with the help of IDEs. This depends on the infrastructure available. Talking specifically about clang-tidy in our environment, I know of at

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

NoQ added a comment. In D69746#1756448 , @gribozavr2 wrote: > > This patch introduces a way to apply the fix-its by the Analyzer: > > I'm not sure this option is very useful... I don't know of anyone who uses > the same option in Clang or ClangTidy. The

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

gribozavr2 added a comment. > This patch introduces a way to apply the fix-its by the Analyzer: I'm not sure this option is very useful... I don't know of anyone who uses the same option in Clang or ClangTidy. The only way I know people apply fixits is with the help of IDEs. I am also

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I like this! @gribozavr: It looks like @Charusso has independently implemented what we've talked about before . Do you agree that the

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

lebedev.ri resigned from this revision. lebedev.ri added inline comments. Comment at: clang/test/Analysis/check_analyzer_fixit.py:1 +#!/usr/bin/env python +# This does work with python3? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69746/new/

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

Charusso updated this revision to Diff 227640. Charusso marked 2 inline comments as done. Charusso added a comment. - Remove `llvm_unreacheable` from error-handling. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69746/new/ https://reviews.llvm.org/D69746 Files:

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:152 + + if (llvm::Error Err = Repls.add(Repl)) +llvm_unreachable("An error occured during fix-it replacements"); zinovy.nis wrote: > Isn't

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

zinovy.nis added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:152 + + if (llvm::Error Err = Repls.add(Repl)) +llvm_unreachable("An error occured during fix-it replacements"); Isn't `llvm_unreacheable`

[PATCH] D69746: [analyzer] FixItHint: apply and test hints with the Clang Tidy's script

Charusso added a comment. Hey! I would like to reuse your script without any reinvention. It serves every needs, but at some point we start to heavily diverge. When I started with the Tidy I really enjoyed that script, and most of the people I know both develop Tidy and the Analyzer, so I

[PATCH] D69746: [analyzer] FixItHint: apply and test hints with the Clang Tidy's script

Charusso created this revision. Charusso added reviewers: NoQ, alexfh, zinovy.nis, JonasToth, hokein, gribozavr, lebedev.ri. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun,