[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi added a comment. I have a fix. About to push. In D70274#1754306 , @leonardchan wrote: > Hi! I think this patch might be causing some test failures on our mac bots: > > FAIL: Clang :: InterfaceStubs/merge-conflict-test.c (6268 of 16220) >

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi added a comment. Looking into it. This change also affected Green Dragon. Thanks for the heads up. In D70274#1754306 , @leonardchan wrote: > Hi! I think this patch might be causing some test failures on our mac bots: > > FAIL: Clang ::

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

leonardchan added a comment. Hi! I think this patch might be causing some test failures on our mac bots: FAIL: Clang :: InterfaceStubs/merge-conflict-test.c (6268 of 16220) TEST 'Clang :: InterfaceStubs/merge-conflict-test.c' FAILED Script: --

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi updated this revision to Diff 229986. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70274/new/ https://reviews.llvm.org/D70274 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/InterfaceStubs.cpp clang/lib/Driver/Types.cpp

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

This revision was automatically updated to reflect the committed changes. Closed by commit rG58ea00b51fe9: [clang][IFS] Driver pipeline: generate interface stubs after standard pipeline. (authored by plotfi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi updated this revision to Diff 229973. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70274/new/ https://reviews.llvm.org/D70274 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/InterfaceStubs.cpp clang/lib/Driver/Types.cpp

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/Driver.cpp:3491 + if (Arg *A = Args.getLastArg(options::OPT_emit_interface_stubs)) { + +llvm::SmallVector PhaseList;

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi updated this revision to Diff 229747. plotfi marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70274/new/ https://reviews.llvm.org/D70274 Files: clang/lib/Driver/Driver.cpp

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi updated this revision to Diff 229745. plotfi marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70274/new/ https://reviews.llvm.org/D70274 Files: clang/lib/Driver/Driver.cpp

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

compnerd added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3506 + types::ID InputType = I.first; + const Arg *InputArg = I.second; + plotfi wrote: > compnerd wrote: > > structured bindings ... so much. > I don't understand? C++17's

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3500 + PL = CompilePhaseList; +} + compnerd wrote: > Do you use the `PhaseList` again? Why not `erase_if`? We tried this in

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi updated this revision to Diff 229731. plotfi marked 7 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70274/new/ https://reviews.llvm.org/D70274 Files: clang/lib/Driver/Driver.cpp

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

compnerd added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3493 +llvm::SmallVector = PhaseList; +types::getCompilationPhases(types::TY_IFS_CPP, PL); +llvm::SmallVector CompilePhaseList; The reference binding is odd. Why not just pass

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/test/InterfaceStubs/driver-test2.c:6 +// RUN: %clang -emit-interface-stubs -emit-merged-ifs \ +// RUN: driver-test2.o object.o weak.o -S -o - | FileCheck %s + I would use

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi updated this revision to Diff 229698. plotfi added a comment. Adding test, and some additional features in the driver. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70274/new/ https://reviews.llvm.org/D70274 Files:

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi updated this revision to Diff 229699. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70274/new/ https://reviews.llvm.org/D70274 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/InterfaceStubs.cpp clang/lib/Driver/Types.cpp

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi created this revision. plotfi added a reviewer: compnerd. Herald added a project: clang. Herald added a subscriber: cfe-commits. Up until now, clang interface stubs has replaced the standard PP -> C -> BE -> ASM -> LNK pipeline. With this change, it will happen in conjunction with it. So