This revision was automatically updated to reflect the committed changes.
Closed by commit rGaf071f03f379: [clangd] Improve ObjC property handling in
SelectionTree. (authored by sammccall).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72634/new/
merge_guards_bot added a comment.
{icon check-circle color=green} Unit tests: pass. 62195 tests passed, 0 failed
and 815 were skipped.
{icon check-circle color=green} clang-tidy: pass.
{icon check-circle color=green} clang-format: pass.
Build artifacts
sammccall updated this revision to Diff 240377.
sammccall added a comment.
more tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72634/new/
https://reviews.llvm.org/D72634
Files:
clang-tools-extra/clangd/Selection.cpp
merge_guards_bot added a comment.
{icon check-circle color=green} Unit tests: pass. 61796 tests passed, 0 failed
and 781 were skipped.
{icon question-circle color=gray} clang-tidy: unknown.
{icon check-circle color=green} clang-format: pass.
Build artifacts
dgoldman requested changes to this revision.
dgoldman added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:347
+ )cpp",
+ "ObjCPropertyRefExpr"},
+
Please add a
sammccall created this revision.
sammccall added a reviewer: dgoldman.
Herald added subscribers: cfe-commits, usaxena95, kadircet, jfb, arphaman,
jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D72634
Files:
