[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

craig.topper added a comment. In D83273#2195033 , @nickdesaulniers wrote: > In D83273#2194869 , @echristo wrote: > >> That said, it's a 10% compile time regression for compiling something like >> the linux kernel

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

nickdesaulniers added a comment. In D83273#2194869 , @echristo wrote: > That said, it's a 10% compile time regression for compiling something like > the linux kernel or anything that's very explicit what flags they set. Digging into the profile a little

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

MaskRay added a comment. Sent D85257 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83273/new/ https://reviews.llvm.org/D83273 ___ cfe-commits mailing list

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

echristo added a comment. In D83273#2194842 , @nickdesaulniers wrote: > In D83273#2194832 , @craig.topper > wrote: > >> It's a pretty nasty revert in our downstream tree where we have prototyped >> future ISAs.

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

MaskRay added a comment. I can optimize getImpliedDisabledFeatures & getImpliedEnabledFeatures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83273/new/ https://reviews.llvm.org/D83273 ___ cfe-commits

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

nickdesaulniers added a comment. In D83273#2194832 , @craig.topper wrote: > It's a pretty nasty revert in our downstream tree where we have prototyped > future ISAs. So I'd like a little time to take a look. > > @nickdesaulniers what cpu and fetaures

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

craig.topper added a comment. It's a pretty nasty revert in our downstream tree where we have prototyped future ISAs. So I'd like a little time to take a look. @nickdesaulniers what cpu and fetaures are on your command lines. getImpliedDisabledFeatures should only be called if some feature is

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

nickdesaulniers added a subscriber: nikic. nickdesaulniers added a comment. cc @nikic http://llvm-compile-time-tracker.com/compare.php?from=094e99d264c937cad33796b8c92fe123cb544c9e=16f3d698f2afbbea43e0c3df81df6f2a640ce806=instructions gives me an error, am I holding it wrong? Repository: rG

Re: [PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

Ow. Can revert and reapply after we fix the caching problem perhaps? -eric On Tue, Aug 4, 2020 at 3:48 PM Nick Desaulniers via Phabricator < revi...@reviews.llvm.org> wrote: > nickdesaulniers added a comment. > > I just collected a perf profile for an entire build. >

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

nickdesaulniers added a comment. I just collected a perf profile for an entire build. `getImpliedDisabledFeatures` is at the top with 9.15% of time spent in self. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83273/new/

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

nickdesaulniers added subscribers: Nathan-Huckleberry, nickdesaulniers. nickdesaulniers added a comment. Hi @craig.topper , @Nathan-Huckleberry and I are seeing `getImpliedEnabledFeatures` at the top of our profiles now. It seems that `llvm::X86::getImpliedFeatures` is repeatedly queried for

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG16f3d698f2af: [X86] Move the feature dependency handling in X86TargetInfo… (authored by craig.topper). Herald added a project: clang. Changed prior to commit:

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Works for me :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83273/new/ https://reviews.llvm.org/D83273 ___ cfe-commits mailing

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

craig.topper updated this revision to Diff 275883. craig.topper added a comment. Drop two header includes I was using for debugging CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83273/new/ https://reviews.llvm.org/D83273 Files: clang/lib/Basic/Targets/X86.cpp

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

craig.topper created this revision. craig.topper added reviewers: RKSimon, spatel, echristo, erichkeane, LuoYuanke, LiuChen3, FreddyYe, xiangzhangllvm. Herald added subscribers: jfb, hiraditya. Herald added a project: LLVM. Previously we had to specify the forward and backwards feature