[PATCH] D83702: [AIX]Generate debug info for static init related functions
This revision was automatically updated to reflect the committed changes. Closed by commit rG69f3378ad65b: [AIX]Generate debug info for static init related functions (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83702/new/ https://reviews.llvm.org/D83702 Files: clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/ItaniumCXXABI.cpp clang/test/CodeGenCXX/aix-static-init-debug-info.cpp Index: clang/test/CodeGenCXX/aix-static-init-debug-info.cpp === --- /dev/null +++ clang/test/CodeGenCXX/aix-static-init-debug-info.cpp @@ -0,0 +1,64 @@ +// RUN: %clang_cc1 -triple powerpc-ibm-aix-xcoff -emit-llvm -x c++ \ +// RUN: -debug-info-kind=limited < %s | \ +// RUN: FileCheck --check-prefixes=CHECK,CHECK64 %s + +// RUN: %clang_cc1 -triple powerpc64-ibm-aix-xcoff -emit-llvm -x c++ \ +// RUN: -debug-info-kind=limited < %s | \ +// RUN: FileCheck --check-prefixes=CHECK,CHECK64 %s + +struct X { + X(); + ~X(); +}; + +X v; + +// CHECK: define internal void @__cxx_global_var_init() [[ATTR:#[0-9]+]] !dbg ![[DBGVAR16:[0-9]+]] { +// CHECK: entry: +// CHECK: call void @_ZN1XC1Ev(%struct.X* @v), !dbg ![[DBGVAR19:[0-9]+]] +// CHECK: %0 = call i32 @atexit(void ()* @__dtor_v) [[ATTR:#[0-9]+]], !dbg ![[DBGVAR19]] +// CHECK: ret void, !dbg ![[DBGVAR19]] +// CHECK: } + +// CHECK: define internal void @__dtor_v() [[ATTR:#[0-9]+]] !dbg ![[DBGVAR20:[0-9]+]] { +// CHECK: entry: +// CHECK: call void @_ZN1XD1Ev(%struct.X* @v), !dbg ![[DBGVAR21:[0-9]+]] +// CHECK: ret void, !dbg ![[DBGVAR21]] +// CHECK: } + +// CHECK: define internal void @__finalize_v() [[ATTR:#[0-9]+]] !dbg ![[DBGVAR22:[0-9]+]] { +// CHECK: entry: +// CHECK: %0 = call i32 @unatexit(void ()* @__dtor_v) [[ATTR:#[0-9]+]], !dbg ![[DBGVAR24:[0-9]+]] +// CHECK: %needs_destruct = icmp eq i32 %0, 0, !dbg ![[DBGVAR24]] +// CHECK: br i1 %needs_destruct, label %destruct.call, label %destruct.end, !dbg ![[DBGVAR24]] + +// CHECK: destruct.call: +// CHECK: call void @__dtor_v(), !dbg ![[DBGVAR24]] +// CHECK: br label %destruct.end, !dbg ![[DBGVAR24]] + +// CHECK: destruct.end: +// CHECK: ret void, !dbg ![[DBGVAR24]] +// CHECK: } + +// CHECK: define void @__sinit8000_clang_c3236cbaa79f2bae3a15e6379a05f625() [[ATTR:#[0-9]+]] !dbg ![[DBGVAR25:[0-9]+]] { +// CHECK: entry: +// CHECK: call void @__cxx_global_var_init(), !dbg ![[DBGVAR26:[0-9]+]] +// CHECK: ret void +// CHECK: } + +// CHECK: define void @__sterm8000_clang_c3236cbaa79f2bae3a15e6379a05f625() [[ATTR:#[0-9]+]] !dbg ![[DBGVAR27:[0-9]+]] { +// CHECK: entry: +// CHECK: call void @__finalize_v(), !dbg ![[DBGVAR28:[0-9]+]] +// CHECK: ret void +// CHECK: } + +// CHECK: ![[DBGVAR16]] = distinct !DISubprogram(name: "__cxx_global_var_init", scope: !{{[0-9]+}}, file: !{{[0-9]+}}, line: 14, type: !{{[0-9]+}}, scopeLine: 14, spFlags: DISPFlagLocalToUnit | DISPFlagDefinition, unit: !{{[0-9]+}}, retainedNodes: !{{[0-9]+}}) +// CHECK: ![[DBGVAR19]] = !DILocation(line: 14, column: 3, scope: ![[DBGVAR16]]) +// CHECK: ![[DBGVAR20]] = distinct !DISubprogram(name: "__dtor_v", scope: !{{[0-9]+}}, file: !{{[0-9]+}}, line: 14, type: !{{[0-9]+}}, scopeLine: 14, spFlags: DISPFlagLocalToUnit | DISPFlagDefinition, unit: !{{[0-9]+}}, retainedNodes: !{{[0-9]+}}) +// CHECK: ![[DBGVAR21]] = !DILocation(line: 14, column: 3, scope: ![[DBGVAR20]]) +// CHECK: ![[DBGVAR22]] = distinct !DISubprogram(linkageName: "__finalize_v", scope: !{{[0-9]+}}, file: !{{[0-9]+}}, line: 14, type: !{{[0-9]+}}, scopeLine: 14, flags: DIFlagArtificial, spFlags: DISPFlagLocalToUnit | DISPFlagDefinition, unit: !{{[0-9]+}}, retainedNodes: !{{[0-9]+}}) +// CHECK: ![[DBGVAR24]] = !DILocation(line: 14, column: 3, scope: ![[DBGVAR22]]) +// CHECK: ![[DBGVAR25]] = distinct !DISubprogram(linkageName: "__sinit8000_clang_c3236cbaa79f2bae3a15e6379a05f625", scope: !{{[0-9]+}}, file: !{{[0-9]+}}, type: !{{[0-9]+}}, flags: DIFlagArtificial, spFlags: DISPFlagDefinition, unit: !{{[0-9]+}}, retainedNodes: !{{[0-9]+}}) +// CHECK: ![[DBGVAR26]] = !DILocation(line: 0, scope: ![[DBGVAR25]]) +// CHECK: ![[DBGVAR27]] = distinct !DISubprogram(linkageName: "__sterm8000_clang_c3236cbaa79f2bae3a15e6379a05f625", scope: !{{[0-9]+}}, file: !{{[0-9]+}}, type: !{{[0-9]+}}, flags: DIFlagArtificial, spFlags: DISPFlagDefinition, unit: !{{[0-9]+}}, retainedNodes: !{{[0-9]+}}) +// CHECK: ![[DBGVAR28]] = !DILocation(line: 0, scope: ![[DBGVAR27]]) Index: clang/lib/CodeGen/ItaniumCXXABI.cpp === --- clang/lib/CodeGen/ItaniumCXXABI.cpp +++ clang/lib/CodeGen/ItaniumCXXABI.cpp @@ -4567,7 +4567,8 @@ CodeGenFunction CGF(CGM); CGF.StartFunction(GlobalDecl(), CGM.getContext().VoidTy, StermFinalizer, FI, -FunctionArgList()); +FunctionArgList(), D.getLocation(), +D.getInit()->getE
[PATCH] D83702: [AIX]Generate debug info for static init related functions
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83702/new/ https://reviews.llvm.org/D83702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D83702: [AIX]Generate debug info for static init related functions
Xiangling_L updated this revision to Diff 277831. Xiangling_L marked 6 inline comments as done. Xiangling_L added a comment. Simplified the testcase; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83702/new/ https://reviews.llvm.org/D83702 Files: clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/ItaniumCXXABI.cpp clang/test/CodeGenCXX/aix-static-init-debug-info.cpp Index: clang/test/CodeGenCXX/aix-static-init-debug-info.cpp === --- /dev/null +++ clang/test/CodeGenCXX/aix-static-init-debug-info.cpp @@ -0,0 +1,64 @@ +// RUN: %clang_cc1 -triple powerpc-ibm-aix-xcoff -emit-llvm -x c++ \ +// RUN: -debug-info-kind=limited < %s | \ +// RUN: FileCheck --check-prefixes=CHECK,CHECK64 %s + +// RUN: %clang_cc1 -triple powerpc64-ibm-aix-xcoff -emit-llvm -x c++ \ +// RUN: -debug-info-kind=limited < %s | \ +// RUN: FileCheck --check-prefixes=CHECK,CHECK64 %s + +struct X { + X(); + ~X(); +}; + +X v; + +// CHECK: define internal void @__cxx_global_var_init() [[ATTR:#[0-9]+]] !dbg ![[DBGVAR16:[0-9]+]] { +// CHECK: entry: +// CHECK: call void @_ZN1XC1Ev(%struct.X* @v), !dbg ![[DBGVAR19:[0-9]+]] +// CHECK: %0 = call i32 @atexit(void ()* @__dtor_v) [[ATTR:#[0-9]+]], !dbg ![[DBGVAR19]] +// CHECK: ret void, !dbg ![[DBGVAR19]] +// CHECK: } + +// CHECK: define internal void @__dtor_v() [[ATTR:#[0-9]+]] !dbg ![[DBGVAR20:[0-9]+]] { +// CHECK: entry: +// CHECK: call void @_ZN1XD1Ev(%struct.X* @v), !dbg ![[DBGVAR21:[0-9]+]] +// CHECK: ret void, !dbg ![[DBGVAR21]] +// CHECK: } + +// CHECK: define internal void @__finalize_v() [[ATTR:#[0-9]+]] !dbg ![[DBGVAR22:[0-9]+]] { +// CHECK: entry: +// CHECK: %0 = call i32 @unatexit(void ()* @__dtor_v) [[ATTR:#[0-9]+]], !dbg ![[DBGVAR24:[0-9]+]] +// CHECK: %needs_destruct = icmp eq i32 %0, 0, !dbg ![[DBGVAR24]] +// CHECK: br i1 %needs_destruct, label %destruct.call, label %destruct.end, !dbg ![[DBGVAR24]] + +// CHECK: destruct.call: +// CHECK: call void @__dtor_v(), !dbg ![[DBGVAR24]] +// CHECK: br label %destruct.end, !dbg ![[DBGVAR24]] + +// CHECK: destruct.end: +// CHECK: ret void, !dbg ![[DBGVAR24]] +// CHECK: } + +// CHECK: define void @__sinit8000_clang_c3236cbaa79f2bae3a15e6379a05f625() [[ATTR:#[0-9]+]] !dbg ![[DBGVAR25:[0-9]+]] { +// CHECK: entry: +// CHECK: call void @__cxx_global_var_init(), !dbg ![[DBGVAR26:[0-9]+]] +// CHECK: ret void +// CHECK: } + +// CHECK: define void @__sterm8000_clang_c3236cbaa79f2bae3a15e6379a05f625() [[ATTR:#[0-9]+]] !dbg ![[DBGVAR27:[0-9]+]] { +// CHECK: entry: +// CHECK: call void @__finalize_v(), !dbg ![[DBGVAR28:[0-9]+]] +// CHECK: ret void +// CHECK: } + +// CHECK: ![[DBGVAR16]] = distinct !DISubprogram(name: "__cxx_global_var_init", scope: !{{[0-9]+}}, file: !{{[0-9]+}}, line: 14, type: !{{[0-9]+}}, scopeLine: 14, spFlags: DISPFlagLocalToUnit | DISPFlagDefinition, unit: !{{[0-9]+}}, retainedNodes: !{{[0-9]+}}) +// CHECK: ![[DBGVAR19]] = !DILocation(line: 14, column: 3, scope: ![[DBGVAR16]]) +// CHECK: ![[DBGVAR20]] = distinct !DISubprogram(name: "__dtor_v", scope: !{{[0-9]+}}, file: !{{[0-9]+}}, line: 14, type: !{{[0-9]+}}, scopeLine: 14, spFlags: DISPFlagLocalToUnit | DISPFlagDefinition, unit: !{{[0-9]+}}, retainedNodes: !{{[0-9]+}}) +// CHECK: ![[DBGVAR21]] = !DILocation(line: 14, column: 3, scope: ![[DBGVAR20]]) +// CHECK: ![[DBGVAR22]] = distinct !DISubprogram(linkageName: "__finalize_v", scope: !{{[0-9]+}}, file: !{{[0-9]+}}, line: 14, type: !{{[0-9]+}}, scopeLine: 14, flags: DIFlagArtificial, spFlags: DISPFlagLocalToUnit | DISPFlagDefinition, unit: !{{[0-9]+}}, retainedNodes: !{{[0-9]+}}) +// CHECK: ![[DBGVAR24]] = !DILocation(line: 14, column: 3, scope: ![[DBGVAR22]]) +// CHECK: ![[DBGVAR25]] = distinct !DISubprogram(linkageName: "__sinit8000_clang_c3236cbaa79f2bae3a15e6379a05f625", scope: !{{[0-9]+}}, file: !{{[0-9]+}}, type: !{{[0-9]+}}, flags: DIFlagArtificial, spFlags: DISPFlagDefinition, unit: !{{[0-9]+}}, retainedNodes: !{{[0-9]+}}) +// CHECK: ![[DBGVAR26]] = !DILocation(line: 0, scope: ![[DBGVAR25]]) +// CHECK: ![[DBGVAR27]] = distinct !DISubprogram(linkageName: "__sterm8000_clang_c3236cbaa79f2bae3a15e6379a05f625", scope: !{{[0-9]+}}, file: !{{[0-9]+}}, type: !{{[0-9]+}}, flags: DIFlagArtificial, spFlags: DISPFlagDefinition, unit: !{{[0-9]+}}, retainedNodes: !{{[0-9]+}}) +// CHECK: ![[DBGVAR28]] = !DILocation(line: 0, scope: ![[DBGVAR27]]) Index: clang/lib/CodeGen/ItaniumCXXABI.cpp === --- clang/lib/CodeGen/ItaniumCXXABI.cpp +++ clang/lib/CodeGen/ItaniumCXXABI.cpp @@ -4567,7 +4567,8 @@ CodeGenFunction CGF(CGM); CGF.StartFunction(GlobalDecl(), CGM.getContext().VoidTy, StermFinalizer, FI, -FunctionArgList()); +FunctionArgList(), D.getLocation(), +D.getInit()->getExprLoc()); // The unatexit subroutine
[PATCH] D83702: [AIX]Generate debug info for static init related functions
dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:248-250 CGF.StartFunction(GlobalDecl(&VD, DynamicInitKind::AtExit), -CGM.getContext().VoidTy, fn, FI, FunctionArgList()); +CGM.getContext().VoidTy, fn, FI, FunctionArgList(), +VD.getLocation(), VD.getInit()->getExprLoc()); hubert.reinterpretcast wrote: > dblaikie wrote: > > Any ideas why this is only showing up for AIX & not other targets, given > > this code looks to be generic, not AIX-specific? > Yes, because the AIX implementation generates a direct call to the stub > function on the finalization path when it finds that a stub was still > registered with `atexit`. > > That would explain why other platforms to not encounter this message: > ``` > inlinable function call in a function with debug info must have a !dbg > location > ``` > Ah, fair enough - thanks for the context! Comment at: clang/test/CodeGenCXX/aix-static-init-debug-info.cpp:9-19 +int a = 0; + +class X { +public: + X() { +a = 1; + } dblaikie wrote: > This could probably be simplified to: > ``` > struct X { > X(); > ~X(); > }; > ``` > > This would still produce a global ctor and dtor without the superfluous > variable, etc. Could you simplify the test a bit like this? If it's only about the global /dtor/, perhaps omit the ctor in X too. & which exact call in the test is the important one? Perhaps just test that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83702/new/ https://reviews.llvm.org/D83702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D83702: [AIX]Generate debug info for static init related functions
hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:248-250 CGF.StartFunction(GlobalDecl(&VD, DynamicInitKind::AtExit), -CGM.getContext().VoidTy, fn, FI, FunctionArgList()); +CGM.getContext().VoidTy, fn, FI, FunctionArgList(), +VD.getLocation(), VD.getInit()->getExprLoc()); dblaikie wrote: > Any ideas why this is only showing up for AIX & not other targets, given this > code looks to be generic, not AIX-specific? Yes, because the AIX implementation generates a direct call to the stub function on the finalization path when it finds that a stub was still registered with `atexit`. That would explain why other platforms to not encounter this message: ``` inlinable function call in a function with debug info must have a !dbg location ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83702/new/ https://reviews.llvm.org/D83702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D83702: [AIX]Generate debug info for static init related functions
dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:248-250 CGF.StartFunction(GlobalDecl(&VD, DynamicInitKind::AtExit), -CGM.getContext().VoidTy, fn, FI, FunctionArgList()); +CGM.getContext().VoidTy, fn, FI, FunctionArgList(), +VD.getLocation(), VD.getInit()->getExprLoc()); Any ideas why this is only showing up for AIX & not other targets, given this code looks to be generic, not AIX-specific? Comment at: clang/test/CodeGenCXX/aix-static-init-debug-info.cpp:9-19 +int a = 0; + +class X { +public: + X() { +a = 1; + } This could probably be simplified to: ``` struct X { X(); ~X(); }; ``` This would still produce a global ctor and dtor without the superfluous variable, etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83702/new/ https://reviews.llvm.org/D83702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D83702: [AIX]Generate debug info for static init related functions
Xiangling_L created this revision. Xiangling_L added reviewers: hubert.reinterpretcast, yusra.syeda, jasonliu. Herald added subscribers: cfe-commits, aprantl. Herald added a project: clang. Set the debug location for static init related functions on AIX(__dtor and __finalize) so we can generate valid debug info by invoking `-g` with clang or `-debug-info-kind=limited` with clang_cc1. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83702 Files: clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/ItaniumCXXABI.cpp clang/test/CodeGenCXX/aix-static-init-debug-info.cpp Index: clang/test/CodeGenCXX/aix-static-init-debug-info.cpp === --- /dev/null +++ clang/test/CodeGenCXX/aix-static-init-debug-info.cpp @@ -0,0 +1,70 @@ +// RUN: %clang_cc1 -triple powerpc-ibm-aix-xcoff -emit-llvm -x c++ \ +// RUN: -debug-info-kind=limited -fno-use-cxa-atexit < %s | \ +// RUN: FileCheck --check-prefixes=CHECK,CHECK64 %s + +// RUN: %clang_cc1 -triple powerpc64-ibm-aix-xcoff -emit-llvm -x c++ \ +// RUN: -debug-info-kind=limited -fno-use-cxa-atexit < %s | \ +// RUN: FileCheck --check-prefixes=CHECK,CHECK64 %s + +int a = 0; + +class X { +public: + X() { +a = 1; + } + ~X() { +a = -1; + } +}; + +X v; + +// CHECK: define internal void @__cxx_global_var_init() [[ATTR:#[0-9]+]] !dbg ![[DBGVAR19:[0-9]+]] { +// CHECK: entry: +// CHECK: call void @_ZN1XC1Ev(%class.X* @v), !dbg ![[DBGVAR22:[0-9]+]] +// CHECK: %0 = call i32 @atexit(void ()* @__dtor_v) [[ATTR:#[0-9]+]], !dbg ![[DBGVAR22]] +// CHECK: ret void, !dbg ![[DBGVAR22]] +// CHECK: } + +// CHECK: define internal void @__dtor_v() [[ATTR:#[0-9]+]] !dbg ![[DBGVAR34:[0-9]+]] { +// CHECK: entry: +// CHECK: call void @_ZN1XD1Ev(%class.X* @v), !dbg ![[DBGVAR35:[0-9]+]] +// CHECK: ret void, !dbg ![[DBGVAR35]] +// CHECK: } + +// CHECK: define internal void @__finalize_v() [[ATTR:#[0-9]+]] !dbg ![[DBGVAR36:[0-9]+]] { +// CHECK: entry: +// CHECK: %0 = call i32 @unatexit(void ()* @__dtor_v) [[ATTR:#[0-9]+]], !dbg ![[DBGVAR38:[0-9]+]] +// CHECK: %needs_destruct = icmp eq i32 %0, 0, !dbg ![[DBGVAR38]] +// CHECK: br i1 %needs_destruct, label %destruct.call, label %destruct.end, !dbg ![[DBGVAR38]] + +// CHECK: destruct.call: +// CHECK: call void @__dtor_v(), !dbg ![[DBGVAR38]] +// CHECK: br label %destruct.end, !dbg ![[DBGVAR38]] + +// CHECK: destruct.end: +// CHECK: ret void, !dbg ![[DBGVAR38]] +// CHECK: } + +// CHECK: define void @__sinit8000_clang_9da80ccf074143d177aee39644eda39d() [[ATTR:#[0-9]+]] !dbg ![[DBGVAR51:[0-9]+]] { +// CHECK: entry: +// CHECK: call void @__cxx_global_var_init(), !dbg ![[DBGVAR52:[0-9]+]] +// CHECK: ret void +// CHECK: } + +// CHECK: define void @__sterm8000_clang_9da80ccf074143d177aee39644eda39d() [[ATTR:#[0-9]+]] !dbg ![[DBGVAR53:[0-9]+]] { +// CHECK: entry: +// CHECK: call void @__finalize_v(), !dbg ![[DBGVAR54:[0-9]+]] +// CHECK: ret void +// CHECK: } + + +// CHECK: ![[DBGVAR19]] = distinct !DISubprogram(name: "__cxx_global_var_init", scope: !{{[0-9]+}}, file: !{{[0-9]+}}, line: 21, type: !{{[0-9]+}}, scopeLine: 21, spFlags: DISPFlagLocalToUnit | DISPFlagDefinition, unit: !{{[0-9]+}}, retainedNodes: !{{[0-9]+}}) +// CHECK: ![[DBGVAR22]] = !DILocation(line: 21, column: 3, scope: ![[DBGVAR19]]) +// CHECK: ![[DBGVAR36]] = distinct !DISubprogram(linkageName: "__finalize_v", scope: !{{[0-9]+}}, file: !{{[0-9]+}}, line: 21, type: !{{[0-9]+}}, scopeLine: 21, flags: DIFlagArtificial, spFlags: DISPFlagLocalToUnit | DISPFlagDefinition, unit: !{{[0-9]+}}, retainedNodes: !{{[0-9]+}}) +// CHECK: ![[DBGVAR38]] = !DILocation(line: 21, column: 3, scope: ![[DBGVAR36]]) +// CHECK: ![[DBGVAR51]] = distinct !DISubprogram(linkageName: "__sinit8000_clang_9da80ccf074143d177aee39644eda39d", scope: !{{[0-9]+}}, file: !{{[0-9]+}}, type: !{{[0-9]+}}, flags: DIFlagArtificial, spFlags: DISPFlagDefinition, unit: !{{[0-9]+}}, retainedNodes: !{{[0-9]+}}) +// CHECK: ![[DBGVAR52]] = !DILocation(line: 0, scope: ![[DBGVAR51]]) +// CHECK: ![[DBGVAR53]] = distinct !DISubprogram(linkageName: "__sterm8000_clang_9da80ccf074143d177aee39644eda39d", scope: !{{[0-9]+}}, file: !{{[0-9]+}}, type: !{{[0-9]+}}, flags: DIFlagArtificial, spFlags: DISPFlagDefinition, unit: !{{[0-9]+}}, retainedNodes: !{{[0-9]+}}) +// CHECK: ![[DBGVAR54]] = !DILocation(line: 0, scope: ![[DBGVAR53]]) Index: clang/lib/CodeGen/ItaniumCXXABI.cpp === --- clang/lib/CodeGen/ItaniumCXXABI.cpp +++ clang/lib/CodeGen/ItaniumCXXABI.cpp @@ -4567,7 +4567,8 @@ CodeGenFunction CGF(CGM); CGF.StartFunction(GlobalDecl(), CGM.getContext().VoidTy, StermFinalizer, FI, -FunctionArgList()); +FunctionArgList(), D.getLocation(), +D.getInit()->getExprLoc()); // The unatexit subroutine unregisters __dtor functions that were previously // registered by the atexit subrou