[PATCH] D84458: [Modules] Improve error message when cannot find parent module for submodule definition.

vsapsai marked an inline comment as done. vsapsai added a comment. Thanks for the review. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:700 + "no module named '%0' %select{found|in '%2'}1, " + "expected parent module to be defined before the submodule">; def

[PATCH] D84458: [Modules] Improve error message when cannot find parent module for submodule definition.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8839e278ffca: [Modules] Improve error message when cannot find parent module for submodule… (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84458: [Modules] Improve error message when cannot find parent module for submodule definition.

vsapsai updated this revision to Diff 287749. vsapsai added a comment. Tweak the error text. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84458/new/ https://reviews.llvm.org/D84458 Files: clang/include/clang/Basic/DiagnosticLexKinds.td

[PATCH] D84458: [Modules] Improve error message when cannot find parent module for submodule definition.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM as is, minor suggestion below. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:700 + "no module named '%0' %select{found|in '%2'}1, " + "expected parent

[PATCH] D84458: [Modules] Improve error message when cannot find parent module for submodule definition.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84458/new/ https://reviews.llvm.org/D84458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D84458: [Modules] Improve error message when cannot find parent module for submodule definition.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84458/new/ https://reviews.llvm.org/D84458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D84458: [Modules] Improve error message when cannot find parent module for submodule definition.

vsapsai marked 3 inline comments as done. vsapsai added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:700 + "no module named '%0' %select{found|in '%2'}1, " + "expected parent module to be defined before the submodule">; def

[PATCH] D84458: [Modules] Improve error message when cannot find parent module for submodule definition.

vsapsai created this revision. vsapsai added reviewers: rsmith, bruno, Bigcheese. Herald added subscribers: ributzka, dexonsmith, jkorous. Herald added a project: clang. Before the change the diagnostic for module unknown.submodule {} was "error: expected module name" which is incorrect and