[PATCH] D86649: Fix for assertion failure on PR46865

2020-09-27 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. I think the assertion is correct: if we reach this point, then we have a `DeclRefExpr` that is not value-dependent and refers to a declaration whose initializer is value-dependent.

[PATCH] D86649: Fix for assertion failure on PR46865

2020-09-01 Thread Warren Ristow via Phabricator via cfe-commits
wristow added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:3098 // have been value-dependent too), so diagnose that. -assert(!VD->mightBeUsableInConstantExpressions(Info.Ctx)); +assert(!VD->isUsableInConstantExpressions(Info.Ctx)); if

[PATCH] D86649: Fix for assertion failure on PR46865

2020-08-26 Thread Sunil Srivastava via Phabricator via cfe-commits
Sunil_Srivastava created this revision. Sunil_Srivastava added reviewers: rsmith, erichkeane. Herald added a project: clang. Herald added a subscriber: cfe-commits. Sunil_Srivastava requested review of this revision. This is a proposed fix for the crash of PR46865. Repository: rG LLVM Github