[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

daltenty added a comment. In D89696#2344797 , @jhuber6 wrote: > In D89696#2344753 , @daltenty wrote: > >> In D89696#2344508 , @jhuber6 wrote: >> >>> @daltenty Do you think

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

jhuber6 added a comment. In D89696#2344753 , @daltenty wrote: > In D89696#2344508 , @jhuber6 wrote: > >> @daltenty Do you think this will fix the problem on AIX? > > It's not just AIX that will have this problem I

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

daltenty added a comment. In D89696#2344508 , @jhuber6 wrote: > @daltenty Do you think this will fix the problem on AIX? It's not just AIX that will have this problem I suspect. If you configure any cross-compiling build with a 64-bit host, targeting a

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

jhuber6 added a comment. @daltenty Do you think this will fix the problem on AIX? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89696/new/ https://reviews.llvm.org/D89696 ___ cfe-commits mailing list

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

jhuber6 updated this revision to Diff 299672. jhuber6 added a comment. Changing test to be similar to LLVM's method, checks the linker flags for 32-bit library and only if the target triple is one of the known 64-bit triples. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

jhuber6 added inline comments. Comment at: clang/test/OpenMP/driver-openmp-target.c:2 +// REQUIRES: x86-registered-target +// REQUIRES: clang-64-bits +// RUN: %clang %s -c -E -dM -fopenmp=libomp -fopenmp-version=45 -fopenmp-targets=x86_64-unknown-unknown -o - | FileCheck

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

daltenty added inline comments. Comment at: clang/test/OpenMP/driver-openmp-target.c:2 +// REQUIRES: x86-registered-target +// REQUIRES: clang-64-bits +// RUN: %clang %s -c -E -dM -fopenmp=libomp -fopenmp-version=45 -fopenmp-targets=x86_64-unknown-unknown -o - | FileCheck

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

This revision was automatically updated to reflect the committed changes. Closed by commit rG24df30efda61: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89696/new/

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

jhuber6 updated this revision to Diff 299081. jhuber6 added a comment. Checking tests again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89696/new/ https://reviews.llvm.org/D89696 Files: clang/test/OpenMP/driver-openmp-target.c

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89696/new/ https://reviews.llvm.org/D89696

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. jhuber6 requested review of this revision. Herald added a subscriber: sstefan1. The changes made in D88594