[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

dblaikie added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:35 CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm. +CODEGENOPT(Dwarf64 , 1, 0) ///< -gdwarf64. CODEGENOPT(PreserveAsmComments, 1, 1) ///< -dA,

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo updated this revision to Diff 306482. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

dblaikie added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4023 + D.Diag(diag::err_drv_argument_only_allowed_with) + << A->getAsString(Args) << "DWARVv3 or greater"; +else if (!RawTriple.isArch64Bit())

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo updated this revision to Diff 306477. ayermolo marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ikudrin added inline comments. Comment at: clang/include/clang/Driver/Options.td:2145-2146 HelpText<"Generate source-level debug information with dwarf version 5">; +def gdwarf64 : Flag<["-"], "gdwarf64">, Group, Flags<[CC1Option]>, + HelpText<"Generate DWARF64 debug

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo updated this revision to Diff 306263. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

dblaikie added inline comments. Comment at: clang/include/clang/Driver/Options.td:2145-2146 HelpText<"Generate source-level debug information with dwarf version 5">; +def gdwarf64 : Flag<["-"], "gdwarf64">, Group, Flags<[CC1Option]>, + HelpText<"Generate DWARF64 debug

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo added inline comments. Comment at: clang/include/clang/Driver/Options.td:2145-2146 HelpText<"Generate source-level debug information with dwarf version 5">; +def gdwarf64 : Flag<["-"], "gdwarf64">, Group, Flags<[CC1Option]>, + HelpText<"Generate DWARF64 debug

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo added inline comments. Comment at: clang/include/clang/Driver/Options.td:2145-2146 HelpText<"Generate source-level debug information with dwarf version 5">; +def gdwarf64 : Flag<["-"], "gdwarf64">, Group, Flags<[CC1Option]>, + HelpText<"Generate DWARF64 debug

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

dblaikie added inline comments. Comment at: clang/include/clang/Driver/Options.td:2145-2146 HelpText<"Generate source-level debug information with dwarf version 5">; +def gdwarf64 : Flag<["-"], "gdwarf64">, Group, Flags<[CC1Option]>, + HelpText<"Generate DWARF64 debug

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4020 +const Arg *A = Args.getLastArg(options::OPT_gdwarf64); +const llvm::Triple = TC.getTriple(); +if (DWARFVersion < 3) MaskRay wrote: > The variable is only used

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo updated this revision to Diff 306223. ayermolo retitled this revision from "Adding DWARF64 clang flag" to "Adding DWARF64 clang flag: -gdwarf64". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507

[PATCH] D90507: Adding DWARF64 clang flag

MaskRay added a comment. > Adding DWARF64 clang flag It is important to mention the exact option name: Add `-gdwarf-64` to enable 64-bit DWARF format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507

[PATCH] D90507: Adding DWARF64 clang flag

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4018 + if (Args.hasArg(options::OPT_gdwarf64)) { +const Arg *A = Args.getLastArg(options::OPT_gdwarf64); `if (const Arg *A = Args.getLastArg(options::OPT_gdwarf64)`)

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo marked 2 inline comments as done. ayermolo added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:35 CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm. +CODEGENOPT(Dwarf64 , 1, 0) ///< -gdwarf64.

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo updated this revision to Diff 306187. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo updated this revision to Diff 306186. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo added a comment. In D90507#2398654 , @ikudrin wrote: > It looks like `lld/test/COFF/lto-new-pass-manager.ll.obj` was added to the > patch by accident and should be removed. It's weird. The file gets automatically added whenever I commit the

[PATCH] D90507: Adding DWARF64 clang flag

ikudrin added a comment. It looks like `lld/test/COFF/lto-new-pass-manager.ll.obj` was added to the patch by accident and should be removed. Comment at: clang/include/clang/Basic/CodeGenOptions.def:35 CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm.

[PATCH] D90507: Adding DWARF64 clang flag

dblaikie added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:35 CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm. +CODEGENOPT(Dwarf64 , 1, 0) ///< -gdwarf64. CODEGENOPT(PreserveAsmComments, 1, 1) ///< -dA,

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo added a comment. In D90507#2394109 , @wenlei wrote: > This change covers non-LTO cases. For LTO, I think we would need to pass it > from driver to LTO. Something like this: tools::addLTOOptions -> lld -> > lto::Config

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo added a comment. In D90507#2393434 , @jansvoboda11 wrote: > Hi @ayermolo, do you think this might be triggered by D82756 > ? (my only upstream patch ATM) Oh, no. Sorry I wasn't clear. I was just looking for

[PATCH] D90507: Adding DWARF64 clang flag

wenlei added a comment. This change covers non-LTO cases. For LTO, I think we would need to pass it from driver to LTO. Something like this: tools::addLTOOptions -> lld -> lto::Config (Config->TargetOptions->MCTargetOptions) ->LTO Backend. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D90507: Adding DWARF64 clang flag

jansvoboda11 added a comment. Hi @ayermolo, do you think this might be triggered by D82756 ? (my only upstream patch ATM) Comment at: clang/test/Driver/debug-options.c:377 // NO_DEBUG_UNUSED_TYPES:

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo added a subscriber: jansvoboda11. ayermolo added a comment. @jansvoboda11 Can you take a look? The failing test is unrelated it seems. Fails locally even without my change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo added a comment. The failure seems unrelated to my changes. Trying locally it fails with latest upstream even without my changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo updated this revision to Diff 304000. Herald added subscribers: steven_wu, hiraditya. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo added a comment. In D90507#2378015 , @ikudrin wrote: > 1. The patch needs tests to check the added functionality. > 2. DWARF64 can be generated only for a limited number of targets. There > should be diagnostics for invalid switch combinations

[PATCH] D90507: Adding DWARF64 clang flag

ikudrin added a comment. 1. The patch needs tests to check the added functionality. 2. DWARF64 can be generated only for a limited number of targets. There should be diagnostics for invalid switch combinations to prevent misuse. @MaskRay mentioned that in the patch for `llc`, D87011#2254749

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo updated this revision to Diff 303303. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo updated this revision to Diff 303209. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo updated this revision to Diff 302326. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo created this revision. ayermolo added a reviewer: llvm-commits. Herald added subscribers: cfe-commits, dexonsmith, wenlei, dang. Herald added a project: clang. ayermolo requested review of this revision. @ikudrin enabled support for dwarf64 in D87011 .