dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.
Thanks. I think this LGTM now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93022/new/
https://reviews.llvm.org/D93022
MarkMurrayARM updated this revision to Diff 313700.
MarkMurrayARM added a comment.
More review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93022/new/
https://reviews.llvm.org/D93022
Files:
clang/test/Driver/aarch64-cpus.c
dmgreen added inline comments.
Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:151
+AARCH64_CPU_NAME("cortex-a78c", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false,
+ (AArch64::AEK_RAS))
AARCH64_CPU_NAME("cortex-r82", ARMV8R, FK_CRYPTO_NEON_FP_ARMV8,
MarkMurrayARM updated this revision to Diff 313694.
MarkMurrayARM added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93022/new/
https://reviews.llvm.org/D93022
Files:
clang/test/Driver/aarch64-cpus.c
dmgreen added inline comments.
Comment at: llvm/include/llvm/Support/ARMTargetParser.def:306
+ARM_CPU_NAME("cortex-a78c", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false,
+ ARM::AEK_RAS)
ARM_CPU_NAME("cortex-x1", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false,
MarkMurrayARM updated this revision to Diff 313678.
MarkMurrayARM added a comment.
Incorporate reviewer comments. Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93022/new/
https://reviews.llvm.org/D93022
Files:
MarkMurrayARM marked 4 inline comments as done.
MarkMurrayARM added a comment.
Marked addressed comments as "done". Some debug code has been abandoned.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93022/new/
https://reviews.llvm.org/D93022
MarkMurrayARM updated this revision to Diff 311856.
MarkMurrayARM added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93022/new/
https://reviews.llvm.org/D93022
Files:
clang/test/Driver/aarch64-cpus.c
ktkachov added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64.td:673-686
+def ProcA78C : SubtargetFeature<"cortex-a78c", "ARMProcFamily",
+"CortexA78C",
+"Cortex-A78C ARM processors", [
+
DavidSpickett added inline comments.
Comment at: llvm/unittests/Support/TargetParserTest.cpp:833
+}
+ }
pass &= AArch64::getCPUAttr(AK).equals(CPUAttr);
MarkMurrayARM wrote:
> DavidSpickett wrote:
> > I assume this was left in from debugging, if not it
MarkMurrayARM added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64.td:673-686
+def ProcA78C : SubtargetFeature<"cortex-a78c", "ARMProcFamily",
+"CortexA78C",
+"Cortex-A78C ARM processors", [
+
miyuki added inline comments.
Comment at: llvm/unittests/Support/TargetParserTest.cpp:47
+if (!pass)
+ std::cout << "ExpectedFlags = 0x" << std::hex << ExpectedFlags
+<< " do not equal ExtKind = 0x" << std::hex << ExtKind
I suggest using LLVM
ktkachov added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64.td:673-686
+def ProcA78C : SubtargetFeature<"cortex-a78c", "ARMProcFamily",
+"CortexA78C",
+"Cortex-A78C ARM processors", [
+
DavidSpickett added inline comments.
Comment at: llvm/unittests/Support/TargetParserTest.cpp:833
+}
+ }
pass &= AArch64::getCPUAttr(AK).equals(CPUAttr);
I assume this was left in from debugging, if not it should be its own change.
(considering this file
MarkMurrayARM created this revision.
Herald added subscribers: danielkiss, hiraditya, kristof.beyls.
MarkMurrayARM requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
This patch upstreams support for the Arm-v8 Cortex-A78C
15 matches
Mail list logo
