[PATCH] D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it

modimo added a comment. In D94333#2829233 , @sylvestre.ledru wrote: >> I think this change broke apt.llvm.org > > Confirmed: reverting this change fixed the link issue What exact commit/download package and build command repros this? M68kSubtarget.cpp

[PATCH] D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it

sylvestre.ledru added a comment. > I think this change broke apt.llvm.org Confirmed: reverting this change fixed the link issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94333/new/ https://reviews.llvm.org/D94333

[PATCH] D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it

sylvestre.ledru added a comment. Herald added a subscriber: ormris. I think this change broke apt.llvm.org > [100%] Linking CXX shared library ../../lib/libLLVM-13.so > cd "/build/llvm-toolchain-snapshot-13~++20210619083511+1605fce6c307/build-llvm/tools/llvm-shlib" && /usr/bin/cmake -E

[PATCH] D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it

modimo added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:412 + + Remark << ";"; } wenlei wrote: > modimo wrote: > > wenlei wrote: > > > nit: any special reason for adding this? doesn't seem consistent with > > > other remarks we have. > >

[PATCH] D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it

wenlei added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:412 + + Remark << ";"; } modimo wrote: > wenlei wrote: > > nit: any special reason for adding this? doesn't seem consistent with other > > remarks we have. > If you grab the remark

[PATCH] D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it

modimo added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:412 + + Remark << ";"; } wenlei wrote: > nit: any special reason for adding this? doesn't seem consistent with other > remarks we have. If you grab the remark outputs via

[PATCH] D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it

wenlei added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:412 + + Remark << ";"; } nit: any special reason for adding this? doesn't seem consistent with other remarks we have. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a49b7c64a33: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it (authored by modimo). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG