sammccall marked an inline comment as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:762
Opts.ResourceDir = ResourceDir;
- Opts.BuildDynamicSymbolIndex = EnableIndex;
+ Opts.BuildDynamicSymbolIndex = true;
ivanmurashko added inline comments.
Herald added projects: clang-tools-extra, All.
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:762
Opts.ResourceDir = ResourceDir;
- Opts.BuildDynamicSymbolIndex = EnableIndex;
+ Opts.BuildDynamicSymbolIndex = true;
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2ab5fd2c8567: [clangd] Retire some flags for
uncontroversial, stable features. (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D94727?vs=316787=317819#toc
Repository:
rG
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/ClangdServer.h:147
-bool SuggestMissingIncludes = false;
-
hokein wrote:
> our internal client explicitly set this to `true`, so we need a migration
> plan for this, otherwise this
hokein added a comment.
the code looks good to me, but we need to be a bit careful on landing this --
as we have an internal client setting this flag.
Comment at: clang-tools-extra/clangd/ClangdServer.h:147
-bool SuggestMissingIncludes = false;
-
our
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: usaxena95, kadircet, arphaman.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
And mark a couple to be retired
