Re: [PATCH] Fix crash when using path limit

2016-11-24 Thread Florian Pritz
On 24.11.2016 20:16, Lukas Fleischer wrote: > The array passed to setup_revisions() must be NULL-terminated. Fixes a > regression introduced in 455b598 (ui-patch.c: Use log_tree_commit() to > generate diffs, 2013-08-20). > > Reported-by: Florian Pritz <bluew...@xinu.at> &

Crash when using path limit in ui-patch.c

2016-11-24 Thread Florian Pritz
Hi, I get the following backtrace when trying to use the path limit feature while getting a patch. > #0 0x00467bb5 in prefix_pathspec (item=0x77ba48, > p_short_magic=0x7fffb2e8, raw=0x76e488, flags=0, prefix=0x0, prefixlen=0, > elt=0x3637353238343130 0x3637353238343130>) at

Re: [PATCH 06/12] filter: add preliminary lua support

2014-01-13 Thread Florian Pritz
On 13.01.2014 05:11, Jason A. Donenfeld wrote: Signed-off-by: Jason A. Donenfeld ja...@zx2c4.com --- cgit.h | 2 +- cgit.mk | 13 ++- filter.c | 284 --- All those *_lua_filter functions look rather self contained, maybe

Re: RFE: .so filters

2014-01-10 Thread Florian Pritz
On 10.01.2014 18:57, Jason A. Donenfeld wrote: On Fri, Jan 10, 2014 at 6:12 PM, Florian Pritz bluew...@xinu.at wrote: Isn't this (fast scripting with lots of features) when people normally start using lua? This would have the same challenges as using .so files, w.r.t. hooking write

Re: RFE: .so filters

2014-01-10 Thread Florian Pritz
On 10.01.2014 21:11, John Keeping wrote: Forking and using Lua in the child is an interesting idea. I need to investigate how Lua generally deals with I/O, but it feels like it will be simpler to use a simple function interface than deal with slurping in the input in Lua. Looks rather easy