Re: [PATCH] Fix crash when using path limit

2016-11-24 Thread Florian Pritz
On 24.11.2016 20:16, Lukas Fleischer wrote: > The array passed to setup_revisions() must be NULL-terminated. Fixes a > regression introduced in 455b598 (ui-patch.c: Use log_tree_commit() to > generate diffs, 2013-08-20). > > Reported-by: Florian Pritz > Signed-off-by: Lukas

Crash when using path limit in ui-patch.c

2016-11-24 Thread Florian Pritz
Hi, I get the following backtrace when trying to use the path limit feature while getting a patch. > #0 0x00467bb5 in prefix_pathspec (item=0x77ba48, > p_short_magic=0x7fffb2e8, raw=0x76e488, flags=0, prefix=0x0, prefixlen=0, > elt=0x3637353238343130 0x3637353238343130>) at pathsp

Re: [PATCH v2] Support Git over HTTP using git-http-backend

2015-01-15 Thread Florian Pritz
On 29.12.2014 18:16, Lukas Fleischer wrote: > On Mon, 29 Dec 2014 at 17:56:05, Florian Pritz wrote: >> This saves users from the hassle of setting up git-http-backend when >> they already run cgit. >> >> References: man git-http-backend Since this has not yet b

[PATCH v2] Support Git over HTTP using git-http-backend

2014-12-29 Thread Florian Pritz
This saves users from the hassle of setting up git-http-backend when they already run cgit. References: man git-http-backend Signed-off-by: Florian Pritz --- v2: - git_root allocation was too small by 1 - change comment style to c89 cgit.c | 3 +++ cgit.h | 1 + cgitrc.5.txt

[PATCH] Support Git over HTTP using git-http-backend

2014-12-29 Thread Florian Pritz
This saves users from the hassle of setting up git-http-backend when they already run cgit. References: man git-http-backend Signed-off-by: Florian Pritz --- I've messed up updating my master branch and used git-send-email on it. You might have gotten 1 or 2 patches that are already ap

Re: adopting kernel.org's css modifications?

2014-02-21 Thread Florian Pritz
On 20.02.2014 21:27, Lukas Fleischer wrote: > On Thu, 20 Feb 2014 at 20:23:56, Jason A. Donenfeld wrote: >> Looks like kernel.org makes some changes. Do we want to adopt any of >> these? Some of them are pretty, like the even/odd background. Others >> I'm not sure what they do... >> [...] > > On t

Re: [PATCH 06/12] filter: add preliminary lua support

2014-01-13 Thread Florian Pritz
On 13.01.2014 05:11, Jason A. Donenfeld wrote: > Signed-off-by: Jason A. Donenfeld > --- > cgit.h | 2 +- > cgit.mk | 13 ++- > filter.c | 284 > --- All those *_lua_filter functions look rather self contained, maybe they should b

Re: RFE: .so filters

2014-01-10 Thread Florian Pritz
On 10.01.2014 21:36, John Keeping wrote: >> Looks rather easy to slurp stdin (from http://www.lua.org/pil/21.1.html): > > Interesting. But I think it will be simpler from both side if the > interface is just a function call source_filter could potentially get a rather long input and might not ne

Re: RFE: .so filters

2014-01-10 Thread Florian Pritz
On 10.01.2014 21:11, John Keeping wrote: > Forking and using Lua in the child is an interesting idea. > > I need to investigate how Lua generally deals with I/O, but it feels > like it will be simpler to use a simple function interface than deal > with slurping in the input in Lua. Looks rather e

Re: RFE: .so filters

2014-01-10 Thread Florian Pritz
On 10.01.2014 18:57, Jason A. Donenfeld wrote: > On Fri, Jan 10, 2014 at 6:12 PM, Florian Pritz wrote: >> >> Isn't this (fast scripting with lots of features) when people normally >> start using lua? >> > > This would have the same challenges as using .so f

Re: RFE: .so filters

2014-01-10 Thread Florian Pritz
On 10.01.2014 16:57, Jason A. Donenfeld wrote: > On Fri, Jan 10, 2014 at 10:06 AM, John Keeping wrote: >> >> This seems drastically over complicated. > > So here's the situation. There's a lot of "state" that we're taking > advantage of in using processes that terminate, that needs to be > replic

Re: [RFC] Relocate repos when using scan-path

2013-05-19 Thread Florian Pritz
On 18.05.2013 18:06, John Keeping wrote: > On Sat, May 18, 2013 at 05:46:35PM +0200, Jason A. Donenfeld wrote: >> On Sat, May 18, 2013 at 5:27 PM, Florian Pritz wrote: >> > The point is that I want to keep already cloned repositories (as in "git >> > clone git://

Re: [RFC] Relocate repos when using scan-path

2013-05-18 Thread Florian Pritz
On 18.05.2013 17:10, John Keeping wrote: > On Mon, May 13, 2013 at 03:56:13PM +0200, Florian Pritz wrote: >> Having now seen section-from-path now I think this feature is pretty >> useful, but to fully utilize it I'd have to move around some repos for a >> proper directo

[RFC] Relocate repos when using scan-path

2013-05-13 Thread Florian Pritz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Having now seen section-from-path now I think this feature is pretty useful, but to fully utilize it I'd have to move around some repos for a proper directory structure. Since I want to keep URLs working for existing clones I thought about placin