and the final one is
the point of the series.
John Keeping (3):
ui-shared: extract date formatting to a function
ui-shared: use common function in print_rel_date()
ui-shared: show full date in tooltip if longer ago than max_relative
ui-shared.c | 28 ++--
1 file
Follow the Git policy of including system headers in only one place.
Signed-off-by: John Keeping
---
cgit.h | 2 ++
ui-shared.h | 2 --
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/cgit.h b/cgit.h
index 3120562..508179a 100644
--- a/cgit.h
+++ b/cgit.h
@@ -3,6 +3,8
We only need to hook write() if Lua filter's are in use. If support has
been disabled, remove the dependency on dlsym().
Signed-off-by: John Keeping
---
filter.c | 78 ++--
1 file changed, 42 insertions(+), 36 deletions(-)
diff
git-compat-util.h may define various values that affect the
interpretation of system headers. In most places we include cgit.h
first, which pulls in git-compat-util.h, but this file does not depend
on anything else in CGit, so use git-compat-util.h directly.
Signed-off-by: John Keeping
it's not already defined
and git-compat-util.h defines it to 64 unconditionally.
John Keeping (8):
tests: allow shell to be overridden
Makefile: include Git's config.mak.uname
Remove redundant includes
configfile.c: don't include system headers directly
cache.c: fix h
These are all included in git-compat-util.h (when necessary), which we
include in cgit.h.
Signed-off-by: John Keeping
---
filter.c | 6 --
html.c| 6 --
shared.c | 1 -
ui-plain.c| 1 -
ui-repolist.c | 1 -
ui-summary.c | 1 -
6 files changed, 16 deletions
g our own "sane" isgraph() using Git's sane isprint() and
isspace() avoids all of these problems.
Signed-off-by: John Keeping
---
cgit.h| 3 +++
ui-tree.c | 1 -
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/cgit.h b/cgit.h
index 508179a..f327627 100644
--- a/cgit
same way that Git does.
Signed-off-by: John Keeping
---
tests/Makefile | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/Makefile b/tests/Makefile
index 1556475..65e1117 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -1,11 +1,15 @@
+include ../git/config.mak.
This pulls in the correct value of $(INSTALL) on a wide variety of
systems.
Signed-off-by: John Keeping
---
Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
index 65b4318..74061a3 100644
--- a/Makefile
+++ b/Makefile
@@ -33,6 +33,7 @@ DOC_PDF = $(patsubst %.txt
git-compat-util.h may define values that affect how system headers are
interpreted, so move sys/sendfile.h after cgit.h (which includes
git-compat-util.h).
Signed-off-by: John Keeping
---
cache.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/cache.c b/cache.c
index
counting
This crept in while rebasing the previous commit onto an updated
upstream.
Signed-off-by: John Keeping
---
ui-log.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui-log.c b/ui-log.c
index ff832ce..6bff948 100644
--- a/ui-log.c
+++ b/ui-log.c
@@ -476,7 +476,7 @@ vo
On Wed, Aug 12, 2015 at 05:07:12PM +0200, Jason A. Donenfeld wrote:
> Relying on an installed git does impose an additional deployment
> requirement we didn't have before. Previously git was just required
> for running the tests (developers), but not for deployment.
I'd be surprised if most people
: add an entry about the agefile
Signed-off-by: John Keeping
---
faq | 13 +
1 file changed, 13 insertions(+)
diff --git a/faq b/faq
index 9c3ff01..e940510 100644
--- a/faq
+++ b/faq
@@ -26,3 +26,16 @@ the .git directory.
A less likely cause is that the repo is, infact, not a valid
On Wed, Aug 12, 2015 at 03:44:19PM +0200, Jason A. Donenfeld wrote:
> On Wed, Aug 12, 2015 at 3:03 PM, John Keeping wrote:
> > This is an attempt at adding "blame" support to CGit. Because git.git
> > doesn't include the blame implementation in libgit.a, I decided
inery no longer performs any path
limitation so we have to examine every commit until we find a page full
of commits that affect the target path or something related to it.
Suggested-by: René Neumann
Signed-off-by: John Keeping
---
Rebased onto updated master.
cgit.c| 4 ++
cgit.h
This will allow us to use this nice wrapper function elsewhere, avoiding
dealing with the diff queue when we only need to inspect a filepair.
Signed-off-by: John Keeping
---
Unchanged since v2/3.
cgit.h | 3 +++
shared.c | 4 ++--
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git
On Wed, Aug 12, 2015 at 03:49:06PM +0200, Jason A. Donenfeld wrote:
> I'd like some review of a few branches that have been sitting for a
> while, and perhaps a rebased version:
>
> jk/http-status-codes: Should be pretty much okay and ready to merge,
> but John -- anything that needs to be done he
Jason, did you decide not to apply this or was it just lost in the
noise?
[Thread starts here:
http://article.gmane.org/gmane.comp.version-control.cgit/2258
]
On Tue, Dec 23, 2014 at 05:12:41PM +0100, Ferry Huberts wrote:
> On 23/12/14 16:48, John Keeping wrote:
> > On Tue, Dec 23, 2014
ile there.
[1] http://repo.or.cz/w/cgit.git/blame/HEAD:/cgit.c
John Keeping (3):
ui-blame: add blame UI
ui-shared: add cgit_blame_link()
ui-tree: generate blame links
cgit.c | 4 +-
cgit.css | 4 ++
cgit.h | 3 +
cgit.mk | 1 +
cgitrc.5.txt | 4 +
---
ui-tree.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/ui-tree.c b/ui-tree.c
index bbc468e..add0344 100644
--- a/ui-tree.c
+++ b/ui-tree.c
@@ -106,6 +106,11 @@ static void print_object(const unsigned char *sha1, char
*path, const char *base
htmlf("blob: %s (", sha1_to_
This is disabled by default and needs to be turned on in the config
file.
Because libgit.a does not include the blame implementation (which lives
in git/builtin/blame.c), this is implemented by executing a git-blame
subprocess and parsing its output. Given how expensive the blame
operation itself
---
ui-shared.c | 40
ui-shared.h | 3 +++
2 files changed, 43 insertions(+)
diff --git a/ui-shared.c b/ui-shared.c
index ac5a287..da9c3d0 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -338,6 +338,46 @@ void cgit_log_link(const char *name, const char *tit
On Mon, Aug 10, 2015 at 09:45:48AM +0200, Daniel Reichelt wrote:
> If the global option enable-filter-overrides is set to 1 the repo-specific
> options repo.hide and repo.ignore never got processed.
>
> Signed-off-by: Daniel Reichelt
Reviewed-by: John Keeping
> ---
> cgit.c
On Fri, Aug 07, 2015 at 07:09:28AM +0200, Daniel Reichelt wrote:
> please find attached a patch which fixes processing of repo.hide and
> repo.ignore.
> These options currently get ignored, if the global option
> enable-filter-overrides is enabled.
>
> Please CC me on replies, I'm not subscribed.
On Fri, Jul 24, 2015 at 11:42:00PM +1000, Matt Hevern wrote:
> On Fri, Jul 24, 2015 at 7:21 PM, John Keeping wrote:
>
> > On Fri, Jul 24, 2015 at 09:35:05AM +1000, Matt Hevern wrote:
> > > I'd like to be able to specify a number of existing git repositories, and
>
On Fri, Jul 24, 2015 at 09:35:05AM +1000, Matt Hevern wrote:
> I'd like to be able to specify a number of existing git repositories, and
> associated descriptions, sections etc, so that they show up orderly via the
> web interface - but I'd also like to set up scan-path so that if anyone
> pushes n
I've just realised that CGit prints dates either in the server's
timezone or in UTC. I'm not sure how I've never spotted it before, but
I find it a bit surprising considering that Git's normal behaviour is to
show author/committer timestamps in the originator's timezone.
I'd like to change CGit's
On Thu, Jun 18, 2015 at 05:03:35PM +0200, Bernhard Reutner-Fischer wrote:
> On 18 June 2015 at 16:48, John Keeping wrote:
> > On Thu, Jun 18, 2015 at 04:38:32PM +0200, Bernhard Reutner-Fischer wrote:
> >> A colleague asked if it's possible to disable the logo-link, but th
On Thu, Jun 18, 2015 at 04:38:32PM +0200, Bernhard Reutner-Fischer wrote:
> A colleague asked if it's possible to disable the logo-link, but that
> doesn't seem to work right now?
No, if there isn't a logo-link specified then the CGit root URL is used;
see ui-shared.c:
if (logo_link && *l
On Thu, Jun 18, 2015 at 02:18:32PM +0200, Bernhard Reutner-Fischer wrote:
> A max-repo-count less than or equal to 0 now disables repository
> pagination.
>
> Previously a value of 0 or smaller went into an infinite loop just
> printing pagination links without any repo.
>
> Signed-off-by: Bernha
On Fri, May 15, 2015 at 03:12:53PM +0200, David Demelier wrote:
> On Fri, 2015-05-15 at 13:39 +0100, John Keeping wrote:
> > On Fri, May 15, 2015 at 01:24:29PM +0100, John Keeping wrote:
> >
> > C
> >
> > So I think what's happening is that you rewrite
On Fri, May 15, 2015 at 01:24:29PM +0100, John Keeping wrote:
> On Fri, May 15, 2015 at 02:08:23PM +0200, David Demelier wrote:
> > I'm trying to setup cgit with lighttpd, this is my actual
> > configuration :
> >
> > $HTTP["host"] ==
On Fri, May 15, 2015 at 02:08:23PM +0200, David Demelier wrote:
> I'm trying to setup cgit with lighttpd, this is my actual
> configuration :
>
> $HTTP["host"] == "git.malikania.fr" {
> alias.url = (
> "/static/" => "/usr/local/www/cgit/",
> "/cgit.cgi" => "
On Wed, May 13, 2015 at 02:41:24PM +0100, John Keeping wrote:
> On Wed, May 13, 2015 at 03:35:29PM +0200, Jason A. Donenfeld wrote:
> > Anybody have any objections to this? In some cases it's slightly more
> > verbose, but otherwise, I can't see any downsides.
>
>
On Wed, May 13, 2015 at 03:35:29PM +0200, Jason A. Donenfeld wrote:
> Anybody have any objections to this? In some cases it's slightly more
> verbose, but otherwise, I can't see any downsides.
It's worse if there is trailing data. Since there's nothing obvious we
can do if the input is bad, I'm n
On Thu, Apr 30, 2015 at 02:57:22PM +0200, Vincent Férotin wrote:
> As a newbie to cgit, I'm currently trying to configure it for a a
> project which hosts some git repos.
> It seems to me (please refute me if I'm wrong) that cgit takes its
> configuration from a given hard-coded path, i.e. "/etc/cg
On Tue, Apr 07, 2015 at 03:36:32PM +0200, Jason A. Donenfeld wrote:
> I've put them in this branch with a few fixes:
> http://git.zx2c4.com/cgit/log/?h=jk/http-status-codes
>
> Feel free to send diffs I should squash into any of these commits.
Thanks. The only other change I have from testing th
On Tue, Apr 07, 2015 at 03:23:03PM +0200, Jason A. Donenfeld wrote:
> On Sun, Apr 5, 2015 at 5:54 PM, John Keeping wrote:
> >
> > +void cgit_print_error_page(int code, const char *msg, const char *fmt,
> > ...)
> > +{
> > + va_list ap;
On Sun, Apr 05, 2015 at 04:55:02PM +0100, John Keeping wrote:
> This also allows us to return proper HTTP error codes when the requested
> tree is not found and display an error message in one case (invalid path
> inside valid commit) where we previously just displayed an empty page.
&g
On Sun, Apr 05, 2015 at 04:54:46PM +0100, John Keeping wrote:
> Following Nicolas' report[0] about CGit caching error pages I've been
> looking into ways of (optionally) avoiding caching error responses.
>
> This series doesn't achieve that but it does give us two feat
No commands use this any more.
Signed-off-by: John Keeping
---
cgit.c | 9 -
cmd.c | 44 ++--
cmd.h | 1 -
3 files changed, 22 insertions(+), 32 deletions(-)
diff --git a/cgit.c b/cgit.c
index 227c336..465b4c3 100644
--- a/cgit.c
+++ b/cgit.c
This also allows us to return proper HTTP error codes when the requested
tree is not found and display an error message in one case (invalid path
inside valid commit) where we previously just displayed an empty page.
Signed-off-by: John Keeping
---
cmd.c | 2 +-
ui-tree.c | 13
Signed-off-by: John Keeping
---
cmd.c| 2 +-
ui-summary.c | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/cmd.c b/cmd.c
index 5340405..ef41ccf 100644
--- a/cmd.c
+++ b/cmd.c
@@ -159,7 +159,7 @@ struct cgit_cmd *cgit_get_cmd(void)
def_cmd(repolist, 0
This also allows us to return proper HTTP error codes when something
goes wrong.
Signed-off-by: John Keeping
---
cmd.c| 2 +-
ui-tag.c | 13 ++---
2 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/cmd.c b/cmd.c
index ef41ccf..27408f2 100644
--- a/cmd.c
+++ b/cmd.c
The existing "show_ctrls" flag is used to control whether we are running
in an existing page or control the page ourselves.
Signed-off-by: John Keeping
---
cmd.c | 2 +-
ui-diff.c | 19 ++-
2 files changed, 15 insertions(+), 6 deletions(-)
diff --git a/cmd.c b/c
This also allows us to return proper HTTP error codes for invalid
requests.
Signed-off-by: John Keeping
---
cmd.c | 2 +-
ui-stats.c | 8 ++--
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/cmd.c b/cmd.c
index 57a8fe7..5340405 100644
--- a/cmd.c
+++ b/cmd.c
@@ -158,7
Signed-off-by: John Keeping
---
cmd.c | 2 +-
ui-repolist.c | 5 -
ui-summary.c | 8 ++--
3 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/cmd.c b/cmd.c
index 188cd56..0f67c74 100644
--- a/cmd.c
+++ b/cmd.c
@@ -144,7 +144,7 @@ struct cgit_cmd *cgit_get_cmd(void
Signed-off-by: John Keeping
---
cmd.c| 2 +-
ui-log.c | 5 -
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/cmd.c b/cmd.c
index f26ae0b..b61c736 100644
--- a/cmd.c
+++ b/cmd.c
@@ -149,7 +149,7 @@ struct cgit_cmd *cgit_get_cmd(void)
def_cmd(commit, 1, 0, 1
These will avoid needing to call three functions to start page layout in
subsequent patches when we move the layout setup into each individual
page.
Signed-off-by: John Keeping
---
ui-shared.c | 12
ui-shared.h | 3 +++
2 files changed, 15 insertions(+)
diff --git a/ui-shared.c b
This allows us to return a proper HTTP status code when an object is not
found by switching from cgit_print_error() to cgit_print_error_page().
Signed-off-by: John Keeping
---
cmd.c | 2 +-
ui-commit.c | 8 ++--
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/cmd.c b
This provides a formatted error response rather than a simple HTTP
error.
Signed-off-by: John Keeping
---
ui-snapshot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui-snapshot.c b/ui-snapshot.c
index cb34f4b..bf4bcd7 100644
--- a/ui-snapshot.c
+++ b/ui-snapshot.c
Signed-off-by: John Keeping
---
cmd.c | 2 +-
ui-refs.c | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/cmd.c b/cmd.c
index b61c736..57a8fe7 100644
--- a/cmd.c
+++ b/cmd.c
@@ -155,7 +155,7 @@ struct cgit_cmd *cgit_get_cmd(void)
def_cmd(patch, 1, 0, 1
This is now unused.
Signed-off-by: John Keeping
---
html.c | 7 ---
html.h | 1 -
2 files changed, 8 deletions(-)
diff --git a/html.c b/html.c
index 155cde5..9e0d6ba 100644
--- a/html.c
+++ b/html.c
@@ -127,13 +127,6 @@ void html_vtxtf(const char *format, va_list ap)
strbuf_release
This will allow us to generate error responses with the correct HTTP
response code without needing all of the layout boilerplate.
Signed-off-by: John Keeping
---
ui-shared.c | 14 ++
ui-shared.h | 2 ++
2 files changed, 16 insertions(+)
diff --git a/ui-shared.c b/ui-shared.c
index
This provides a formatted error response rather than a simple HTTP
error.
Signed-off-by: John Keeping
---
ui-plain.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/ui-plain.c b/ui-plain.c
index b787bc3..e08dad9 100644
--- a/ui-plain.c
+++ b/ui-plain.c
@@ -67,13
e cases where we should not do this.
[0] http://lists.zx2c4.com/pipermail/cgit/2015-March/002464.html
John Keeping (17):
ui-shared: add cgit_print_error_page() function
cgit: use cgit_print_error_page() where appropriate
clone: use cgit_print_error_page() instead of html_status()
plain: use
These are more-or-less one-to-one translations but in the final hunk we
gain an HTTP error code where we used to send "200 OK", which is an
improvement.
Signed-off-by: John Keeping
---
cgit.c | 27 +++
1 file changed, 7 insertions(+), 20 deletions(-)
diff --gi
This provides a formatted error response rather than a simple HTTP
error.
Signed-off-by: John Keeping
---
ui-clone.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/ui-clone.c b/ui-clone.c
index e35d3d3..e7a6b76 100644
--- a/ui-clone.c
+++ b/ui-clone.c
@@ -57,13
On Mon, Mar 30, 2015 at 07:15:27PM +0200, Nicolas Dely wrote:
> I would like to share an unexpected cache behaviour with this list and
> discuss about a solution.
>
> Indeed we are using cgit to provide a web interface to our internal user
> and also to provide file to our reviewboard server.
>
On Sat, Mar 21, 2015 at 02:11:51PM +0100, Stefan Naewe wrote:
> On Fri, Mar 20, 2015 at 10:29 PM, John Keeping wrote:
> > On Fri, Mar 20, 2015 at 05:39:53PM +0100, Stefan Naewe wrote:
> >> When the git function format_display_notes() is called
> >> with a value != 0
On Fri, Mar 20, 2015 at 05:39:53PM +0100, Stefan Naewe wrote:
> When the git function format_display_notes() is called
> with a value != 0 as the last argument ('raw') the notes text
> gets displayed w/o an additional 'Notes:' header. This seems
> to be better suited for our needs since we're alrea
On Mon, Mar 09, 2015 at 03:39:29PM -0400, Todd Zullinger wrote:
> Those on the list can check the PGP signature on the announcement mail
> and then use the included SHA1 to check the tarball, but doing that as
> a non-list member isn't as easy due to many list archives stripping or
> mangling PG
This is not used outside this file and is not declared.
Signed-off-by: John Keeping
---
ui-shared.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui-shared.c b/ui-shared.c
index 6d3cfa9..d4c4bb9 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -11,7 +11,7 @@
#include "
These definitions should not be modified (and never are) so we can move
them to .rodata.
Signed-off-by: John Keeping
---
ui-stats.c | 14 +++---
ui-stats.h | 2 +-
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/ui-stats.c b/ui-stats.c
index a264f6a..9cd8247 100644
--- a
Sparse complains that we are using a plain integer as a NULL pointer
here, but in fact we do not have to specify a value for this variable at
all since it has static storage duration and thus will be initialized to
NULL by the compiler.
Signed-off-by: John Keeping
---
ui-shared.c | 2 +-
1 file
Signed-off-by: John Keeping
---
cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cache.c b/cache.c
index 900b161..cd99812 100644
--- a/cache.c
+++ b/cache.c
@@ -411,7 +411,7 @@ int cache_ls(const char *path)
DIR *dir;
struct dirent *ent;
int err
These are not used outside this file and are not declared; they are also
never modified.
Signed-off-by: John Keeping
---
ui-repolist.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui-repolist.c b/ui-repolist.c
index a6d0321..2453a7f 100644
--- a/ui-repolist.c
+++ b/ui
Signed-off-by: John Keeping
---
ui-shared.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui-shared.c b/ui-shared.c
index 1e3c131..7bcb8d3 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -119,7 +119,7 @@ char *cgit_fileurl(const char *reponame, const char
*pagename,
char
Sparse complains about this table because we use the integer zero as the
NULL pointer. Use this as an opportunity to reformat the table so that
it always contains 8 elements per row, making it easier to see which
values are being set and which are not.
Signed-off-by: John Keeping
---
html.c
These are not used outside this file and are not declared.
Signed-off-by: John Keeping
---
scan-tree.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scan-tree.c b/scan-tree.c
index e900ad9..8e3cf52 100644
--- a/scan-tree.c
+++ b/scan-tree.c
@@ -45,8 +45,8 @@ out
These are not used outside this file and are not declared.
Signed-off-by: John Keeping
---
ui-log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui-log.c b/ui-log.c
index 1b60591..32b4c47 100644
--- a/ui-log.c
+++ b/ui-log.c
@@ -12,7 +12,7 @@
#include "ui-sha
These are not used outside this file and are not declared.
Signed-off-by: John Keeping
---
shared.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/shared.c b/shared.c
index ae17d78..a99173b 100644
--- a/shared.c
+++ b/shared.c
@@ -284,8 +284,8 @@ static int load_mmfile
Bitfields are only defined for unsigned types.
Detected by sparse.
Signed-off-by: John Keeping
---
ui-blob.c | 4 ++--
ui-diff.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/ui-blob.c b/ui-blob.c
index a025bca..388a017 100644
--- a/ui-blob.c
+++ b/ui-blob.c
@@ -14,8
Sparse says things like:
warning: non-ANSI function declaration of function 'calc_ttl'
Signed-off-by: John Keeping
---
cgit.c| 2 +-
filter.c | 2 +-
ui-diff.c | 2 +-
ui-refs.c | 4 ++--
ui-repolist.c | 6 +++---
ui-shared.c | 12 ++--
u
://sparse.wiki.kernel.org/index.php/Main_Page
John Keeping (13):
Makefile: add a target to run CGit through sparse
Avoid non-ANSI function declarations
Avoid signed bitfields
scan-tree: make some variables 'static'
shared: make some variables 'static'
ui-log: make some variables &#
Signed-off-by: John Keeping
---
Makefile | 3 +++
cgit.mk | 9 -
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index ed329e8..42ed230 100644
--- a/Makefile
+++ b/Makefile
@@ -68,6 +68,9 @@ all:: cgit
cgit:
$(QUIET_SUBDIR0)git $(QUIET_SUBDIR1
On Sat, Mar 07, 2015 at 06:35:10PM -0500, Todd Zullinger wrote:
> John Keeping wrote:
> > I still think we can't rely on `gpg --recv-keys` though, we would
> > have to distribute the key with CGit and possible also do something
> > to avoid importing it into the
On Sat, Mar 07, 2015 at 06:49:32PM +0100, Lukas Fleischer wrote:
> On Sat, 07 Mar 2015 at 18:02:59, John Keeping wrote:
> > [...]
> > I'm not sure what benefit it has if it's optional. Will anyone check?
> >
> > Maybe we could do something like:
> >
&g
On Sat, Mar 07, 2015 at 04:59:26PM +0100, Lukas Fleischer wrote:
> On Sat, 07 Mar 2015 at 15:46:41, John Keeping wrote:
> > This requires that we save the downloaded file explicitly rather than
> > piping it straight to tar, but that is advisable anyway since it allows
> >
e the file when
updating our Git version in the future.
Signed-off-by: John Keeping
---
Makefile | 8 ++--
git.sha256sum| 1 +
tests/t0001-validate-git-versions.sh | 11 +++
3 files changed, 18 insertions(+), 2 deletions(-)
create
johnkeeping/git-instacgit
> -Original Message-
> From: John Keeping [mailto:j...@keeping.me.uk]
> Sent: Thursday, March 05, 2015 12:26 PM
> To: Dunnigan, Terrence J
> Cc: cgit@lists.zx2c4.com
> Subject: Re: Support for submodules in tree view?
>
> On Thu, Mar 05, 2
On Thu, Mar 05, 2015 at 07:31:01PM +0100, Lukas Fleischer wrote:
> On Thu, 05 Mar 2015 at 19:25:53, John Keeping wrote:
> > On Thu, Mar 05, 2015 at 06:19:31PM +, Dunnigan, Terrence J wrote:
> > > We are using cgit 0.10.1. Some of our repos have submodules, and when
> >
On Thu, Mar 05, 2015 at 06:19:31PM +, Dunnigan, Terrence J wrote:
> We are using cgit 0.10.1. Some of our repos have submodules, and when
> I look at a tree view I see the name of the submodule with its current
> hash, e.g.
>
> m- Utilities @ 350bc94
>
> The submodule names are all h
On Thu, Mar 05, 2015 at 06:50:47PM +0100, Jan-Marek Glogowski wrote:
> Am 05.03.2015 um 18:38 schrieb John Keeping:
> > What's the advantage of this over using "enable-git-config=1" and
> > "cgit.section" (we even support "gitweb.section" as an a
On Thu, Mar 05, 2015 at 06:15:04PM +0100, Jan-Marek Glogowski wrote:
> Gitweb reads .git/category to set a repository section for
> grouping. This handles the file in the same way a .git/description
> file is handled.
>
> The file section takes precedence over the ctx.cfg.section_from_path
> setti
On Thu, Mar 05, 2015 at 11:46:55AM +0100, Jason A. Donenfeld wrote:
> This commit breaks ui-tag. The first few lines of tag messages are cut off.
It looks like parse_user() consumes the trailing LF on the user line, so
next_header_line() ends up skipping the blank line at the end of the
header.
I
On Thu, Mar 05, 2015 at 10:51:09AM +0100, Pablo Rauzy wrote:
> Hello again, and thanks for your quick response.
>
> On 2015-03-05, John Keeping wrote:
> > On Thu, Mar 05, 2015 at 09:22:55AM +0100, Pablo Rauzy wrote:
> >> My first question is about sections.
> >>
On Thu, Mar 05, 2015 at 09:22:55AM +0100, Pablo Rauzy wrote:
> My first question is about sections.
> I would like to be able to add a title and a little description for each
> section, just like I can with the cgit.desc configuration for each the
> git repos.
>
> Example : http://clandest.in/sens
On Tue, Mar 03, 2015 at 11:56:11PM +0100, Jason A. Donenfeld wrote:
> Thanks! Merged. It would be nice to see a test case built out of the
> example you gave in the commit message.
It has to run for a couple of minutes to get sensible results. I guess
we could introduce an EXPENSIVE prerequisite
>From eb741581ec16d3249e7d207c3dbc4a433a8f329b Mon Sep 17 00:00:00 2001
Message-Id:
From: John Keeping
Date: Tue, 3 Mar 2015 19:01:24 +
Subject: [PATCH] cache: use F_SETLK to avoid stale lock files
If CGit is killed while it holds a lock on a cache slot (for example
because it is tak
On Sun, Mar 01, 2015 at 07:36:00PM +, John Keeping wrote:
> On Sun, Mar 01, 2015 at 06:43:17PM +, Bertrand Jacquin wrote:
> > On 28/02/2015 12:37, John Keeping wrote:
> > > On Sat, Feb 28, 2015 at 12:06:41PM +, Bertrand Jacquin wrote:
> > >> We are st
On Sun, Mar 01, 2015 at 06:43:17PM +, Bertrand Jacquin wrote:
> On 28/02/2015 12:37, John Keeping wrote:
> > On Sat, Feb 28, 2015 at 12:06:41PM +, Bertrand Jacquin wrote:
> >> We are still experiencing the issue. Is there any fixes with newer
> >> releases ?
&g
On Sat, Feb 28, 2015 at 12:06:41PM +, Bertrand Jacquin wrote:
> We are still experiencing the issue. Is there any fixes with newer
> releases ?
I have just tried to reproduce this with the latest version and have not
been able to do so, but I'm not aware of any changes that should have an
eff
On Wed, Jan 21, 2015 at 11:02:32AM -0500, Elijah Lynn wrote:
> I am not sure if there is an issue tracker being used for the project. I
> asked the list a while back but haven't heard back. At any rate, is there a
> way I can see if there is git blame support being built? I am part of the
> Drupal
On Mon, Jan 19, 2015 at 02:17:00PM -0500, Eclipse Webmaster (Denis Roy) wrote:
> We use cgit for about 800 Git repos. Lately we've noticed that the links
> in the cache become polluted. We've noticed hits like this in the logs,
> which come from Search Bots, which seem to match the garbage in the
On Fri, Jan 16, 2015 at 05:30:56PM +0100, Lukas Tribus wrote:
> I've a probably stupid setup issue, I just can't figure it out and need
> a fresh set of eyes:
> I compiled cgit from source (@d6c405077) and installed it
> on a Ubuntu VM together with nginx through fcgiwrapper.
>
> When I open cgit
ter
the log link will show the log of the tag. This is clearly desirable
when the tag has been reached from the refs UI and changing the
behaviour for tag decorations makes them match branch decorations where
log -> decoration -> log shows the log of the decoration.
Reported-by: Ferry
On Wed, Jan 14, 2015 at 04:34:20PM +0100, l...@eworm.de wrote:
> From: Christian Hesse
>
> * sort_string_list(): rename to string_list_sort() (upstream commit
> * 3383e199)
> * update read_tree_recursive callback to pass strbuf as base (upstream
> commit 6a0b0b6d)
>
> Signed-off-by: Christian
On Thu, Jan 15, 2015 at 06:27:50PM +0100, Lukas Fleischer wrote:
> On Thu, 15 Jan 2015 at 17:18:02, Ferry Huberts wrote:
> > Hi
> >
> > Just noticed this:
> > You can't show the log of a tag when that tag is not on a branch, which
> > happen to me a lot for expired maintenance branches.
> >
> >
On Tue, Jan 13, 2015 at 10:57:39AM +0100, Christian Hesse wrote:
> John Keeping on Tue, 2015/01/13 09:43:
> > On Tue, Jan 13, 2015 at 09:56:47AM +0100, l...@eworm.de wrote:
> > > From: Christian Hesse
> > >
> > > * sort_string_list(): rename to string_list_so
401 - 500 of 621 matches
Mail list logo
