Re: [PATCH 06/12] filter: add preliminary lua support

2014-01-13 Thread Lukas Fleischer
This patch is quite messy and hard to read. I read your cover-letter but maybe you still want to clean this up when dealing with the other suggestions during a rebase -- shouldn't be too hard when using an editor with good Git integration (like fugitive for Vim). On Mon, 13 Jan 2014 at 05:11:13,

Re: [PATCH 06/12] filter: add preliminary lua support

2014-01-13 Thread John Keeping
On Mon, Jan 13, 2014 at 09:31:39AM +0100, Lukas Fleischer wrote: This patch is quite messy and hard to read. I read your cover-letter but maybe you still want to clean this up when dealing with the other suggestions during a rebase -- shouldn't be too hard when using an editor with good Git

Re: [PATCH 06/12] filter: add preliminary lua support

2014-01-13 Thread John Keeping
On Mon, Jan 13, 2014 at 05:11:13AM +0100, Jason A. Donenfeld wrote: [snip] +static int html_lua_filter(lua_State *lua_state) +{ + size_t len; + const char *str; + + str = lua_tostring(lua_state, 1); + if (!str) + return 0; + len = strlen(str); +

Re: [PATCH 06/12] filter: add preliminary lua support

2014-01-13 Thread Florian Pritz
On 13.01.2014 05:11, Jason A. Donenfeld wrote: Signed-off-by: Jason A. Donenfeld ja...@zx2c4.com --- cgit.h | 2 +- cgit.mk | 13 ++- filter.c | 284 --- All those *_lua_filter functions look rather self contained, maybe