Re: [Chicken-hackers] [PATCH] A stupid but serviceable fix for #1110

2015-12-08 Thread Christian Kellermann
Peter Bex writes: > So here's another fix, this is an attempt to slightly improve the error > message you get when Henrietta returns an error. Henrietta is supposed > to return an s-expression (error "blabla") when something doesn't work > out well, but there's a mismatch

Re: [Chicken-hackers] [PATCH] Make ##sys#stat work with port objects.

2015-12-08 Thread Christian Kellermann
lemonboy writes: > Take 2, this time the NEWS file and the manual have been updated too. > Sorry for the noise. I have applied this to the master branch and will cherry pick it into chicken-5. Thanks for your contribution! Cheers, Christian

Re: [Chicken-hackers] [PATCH] Improve irregex matching performance a lot by adding two type declarations

2015-12-08 Thread Peter Bex
On Tue, Dec 08, 2015 at 10:35:35PM +0100, felix.winkelm...@bevuta.com wrote: > > Now, if you look at the patch you'll see that it changes irregex-core.scm, > > which means it creates a "fork" against that part of the code in upstream. > > I don't see a way to declare the type from the "outside",

Re: [Chicken-hackers] [PATCH] Improve irregex matching performance a lot by adding two type declarations

2015-12-08 Thread Peter Bex
On Wed, Dec 09, 2015 at 01:30:47AM +0100, Kooda wrote: > On Tue, Dec 08, 2015 at 10:12:46PM +0100, Peter Bex wrote: > > Using the unpatched version: > > 1.336s CPU time, 0.028s GC time (major), 600061/2562 mutations > > (total/tracked), 11/2823 GCs (major/minor) > > > > Using the patched

[Chicken-hackers] [PATCH] Improve irregex matching performance a lot by adding two type declarations

2015-12-08 Thread Peter Bex
Hi all, I've done some benchmarking of the irregex unit and I found that the single most performance-critical part of the code is "cset-contains?". This procedure is used to check the current character in the input string against the regex DFA state's transition table while matching the input,

Re: [Chicken-hackers] [PATCH] Improve irregex matching performance a lot by adding two type declarations

2015-12-08 Thread felix . winkelmann
> Now, if you look at the patch you'll see that it changes irregex-core.scm, > which means it creates a "fork" against that part of the code in upstream. > I don't see a way to declare the type from the "outside", in irregex.scm, > unless we also copy that code body as a macro, but that feels