Re: [Chicken-hackers] read/write invariance of #!

2019-01-20 Thread Peter Bex
On Mon, Jan 14, 2019 at 09:16:18AM +1300, Evan Hanson wrote: > No worries, here's an updated version of the patch that should apply > nicely to HEAD. I've pushed this, thanks guys! I've also added a little regression test for this. Cheers, Peter signature.asc Description: PGP signature

Re: [Chicken-hackers] read/write invariance of #!

2019-01-13 Thread Jim Ursetto
> On Jan 13, 2019, at 2:16 PM, Evan Hanson wrote: > > > I don't think this change fixes the example you gave as a "certain > strange combination" in ticket #1572, i.e. (#! (foo bar)). ISTM that > happens because any whitespace after a "#!" token causes the reader to > skip everything until the

Re: [Chicken-hackers] read/write invariance of #!

2019-01-13 Thread Evan Hanson
On 2019-01-13 22:28, felix.winkelm...@bevuta.com wrote: > > Does anyone know what that's about? I can't figure out what feature that > > code is there to support. It's been there since the first check-in to > > Git (I didn't look any further back than that). > > That's intentional, to handle

Re: [Chicken-hackers] read/write invariance of #!

2019-01-13 Thread felix . winkelmann
> I don't think this change fixes the example you gave as a "certain > strange combination" in ticket #1572, i.e. (#! (foo bar)). ISTM that > happens because any whitespace after a "#!" token causes the reader to > skip everything until the end of the line (and the same goes for a > forward

Re: [Chicken-hackers] read/write invariance of #!

2019-01-13 Thread Evan Hanson
Hi Jim, On 2019-01-12 10:04, Jim Ursetto wrote: > > > On Jan 11, 2019, at 9:47 PM, Jim Ursetto wrote: > > > >> On Jan 11, 2019, at 3:12 PM, Evan Hanson >> > wrote: > >> > >> In case someone decides to apply this patch, there's an unnecessary (and > >> ...) > >>

Re: [Chicken-hackers] read/write invariance of #!

2019-01-12 Thread Jim Ursetto
> On Jan 11, 2019, at 9:47 PM, Jim Ursetto wrote: > >> On Jan 11, 2019, at 3:12 PM, Evan Hanson > > wrote: >> >> In case someone decides to apply this patch, there's an unnecessary (and ...) >> around the conditional that can be removed. > > Hi Evan, > Sorry for the

Re: [Chicken-hackers] read/write invariance of #!

2019-01-11 Thread Jim Ursetto
> On Jan 11, 2019, at 3:12 PM, Evan Hanson wrote: > > On 2018-12-27 10:38, Jim Ursetto wrote: >> Thanks Felix. This looks good but I haven’t had a chance to test it yet. >> Will report back. > > Any luck? This looks OK to me. > > In case someone decides to apply this patch, there's an

Re: [Chicken-hackers] read/write invariance of #!

2019-01-11 Thread Evan Hanson
On 2018-12-27 10:38, Jim Ursetto wrote: > Thanks Felix. This looks good but I haven’t had a chance to test it yet. > Will report back. Any luck? This looks OK to me. In case someone decides to apply this patch, there's an unnecessary (and ...) around the conditional that can be removed. Evan

Re: [Chicken-hackers] read/write invariance of #!

2018-12-27 Thread Jim Ursetto
Thanks Felix. This looks good but I haven’t had a chance to test it yet. Will report back. Jim > On Dec 23, 2018, at 1:46 PM, felix.winkelm...@bevuta.com wrote: > > Hi! > > Attached is a patch that seems to work for me. I don't think #!eof > should be handled specially, as it is a distinct

Re: [Chicken-hackers] read/write invariance of #!

2018-12-23 Thread felix . winkelmann
Hi! Attached is a patch that seems to work for me. I don't think #!eof should be handled specially, as it is a distinct object. felixFrom 834a8d231d5bcdfc9bc517e8902ceee3c18d98e8 Mon Sep 17 00:00:00 2001 From: felix Date: Sun, 23 Dec 2018 20:44:51 +0100 Subject: [PATCH] preserve read/write