[chromium-dev] Re: UI proposal: Open link in new foreground tab

2008-12-08 Thread Simon B.
One way to lower the cognitive costs with additional menu options: let users customize menus. A customized menu gets an extra More... as its last option. (Tooltip suggestion: More options exist. This menu is customized.). Click to show remaining options below the fold, including Customize and

[chromium-dev] data resources and localized strings on linux

2008-12-08 Thread tony
I wrote a short design doc about handling data resources and localized strings on linux. http://sites.google.com/a/chromium.org/dev/developers/design-documents/linuxresourcesandlocalizedstrings Feedback welcome. tony --~--~-~--~~~---~--~~ You received this

[chromium-dev] Re: Did you move Chromium to ProgramFiles ?

2008-12-08 Thread cpu
If this is a common scenario, we might need to use another signal. On Dec 6, 6:25 pm, Peter Kasting [EMAIL PROTECTED] wrote: On Fri, Dec 5, 2008 at 7:01 PM, cpu [EMAIL PROTECTED] wrote: Due to a series of changes in the last month, the app now thinks it has been installed systemwide. This

[chromium-dev] Re: data resources and localized strings on linux

2008-12-08 Thread Evan Martin
- Is the plan to mmap the data file directly? Avoids copies, but means we should (a) null terminate the string resources (maybe the rc format does this already) and (b) sort the resource entries by resource id for faster lookup. - We should make explicit the byte order for the int32s. We can't

[chromium-dev] Re: data resources and localized strings on linux

2008-12-08 Thread Adam Langley
On Mon, Dec 8, 2008 at 10:40 AM, Evan Martin [EMAIL PROTECTED] wrote: - Is the plan to mmap the data file directly? Avoids copies, but means we should (a) null terminate the string resources (maybe the rc format does this already) and (b) sort the resource entries by resource id for faster

[chromium-dev] Re: build issue: File src\chrome\app\theme\google_chrome\BRANDING is missing

2008-12-08 Thread blep
On 8 déc, 09:24, [EMAIL PROTECTED] wrote: You need to run a gclient sync rather than an svn update. You won't get all the necessary dependencies with just an svn update. See the end of http://dev.chromium.org/developers/how-tos/get-the-code Forgot the gclient part (took 4 hours to download

[chromium-dev] Re: data resources and localized strings on linux

2008-12-08 Thread tony
All good points. I've added notes about null terminating the strings, little endian byte order, and utf8 encoding. zip or zlib or bzip compression may speed load time. I'm not sure, but I think that would be an iteration we add later. It probably wouldn't help with the theme .so file, but it

[chromium-dev] Re: data resources and localized strings on linux

2008-12-08 Thread Jo
Fast question, have you think about adding checksum? On Dec 8, 12:15 pm, [EMAIL PROTECTED] wrote: I wrote a short design doc about handling data resources and localized strings on linux.  http://sites.google.com/a/chromium.org/dev/developers/design-document... Feedback welcome. tony

[chromium-dev] New Find Bar ownership/hookup design doc

2008-12-08 Thread Ben Goodger (Google)
I've been contemplating and prototyping some changes to the way the Find Bar is attached and owned relative to other objects in the Browser UI. To describe what I am thinking I've put together a design doc: http://dev.chromium.org/developers/design-documents/find-bar Please reply with any

[chromium-dev] Re: Extending Value with std::string support

2008-12-08 Thread Peter Kasting
On Mon, Dec 8, 2008 at 5:28 PM, Andrew Scherkus [EMAIL PROTECTED]wrote: 1) Overload CreateStringValue, GetAsString, etc.. to also accept std::string. Add TYPE_UTF8_STRING to ValueType enum. 2) Overload CreateStringValue, GetAsString, etc.. to also accept std::string. TYPE_STRING becomes

[chromium-dev] Re: Extending Value with std::string support

2008-12-08 Thread Brett Wilson
On Mon, Dec 8, 2008 at 7:50 PM, Peter Kasting [EMAIL PROTECTED] wrote: On Mon, Dec 8, 2008 at 6:41 PM, Andrew Scherkus [EMAIL PROTECTED] wrote: Darin touched upon this, who said to document that std::string should refer to UTF-8 strings. How about: - CreateStringValue creates a

[chromium-dev] Re: Extending Value with std::string support

2008-12-08 Thread Andrew Scherkus
Somewhat in line with the Google style guide, the overloaded CreateStringValue/GetString do accomplish the same thing (variant string type), just with different encodings. I did some partial implementations of #3 and as Peter highlighted, writing GetWideString everywhere started looking really

[chromium-dev] Re: Extending Value with std::string support

2008-12-08 Thread Brett Wilson
On Mon, Dec 8, 2008 at 8:32 PM, Andrew Scherkus [EMAIL PROTECTED] wrote: Somewhat in line with the Google style guide, the overloaded CreateStringValue/GetString do accomplish the same thing (variant string type), just with different encodings. I did some partial implementations of #3 and as

[chromium-dev] Re: Extending Value with std::string support

2008-12-08 Thread Andrew Scherkus
On Mon, Dec 8, 2008 at 8:53 PM, Brett Wilson [EMAIL PROTECTED] wrote: On Mon, Dec 8, 2008 at 8:32 PM, Andrew Scherkus [EMAIL PROTECTED] wrote: Somewhat in line with the Google style guide, the overloaded CreateStringValue/GetString do accomplish the same thing (variant string type), just