On Mon, Dec 8, 2008 at 8:53 PM, Brett Wilson <[EMAIL PROTECTED]> wrote:
> > On Mon, Dec 8, 2008 at 8:32 PM, Andrew Scherkus <[EMAIL PROTECTED]> > wrote: > > Somewhat in line with the Google style guide, the overloaded > > CreateStringValue/GetString do accomplish the same thing (variant string > > type), just with different encodings. > > I did some partial implementations of #3 and as Peter highlighted, > writing > > GetWideString everywhere started looking really silly. > > In terms of enums and implementation, would TYPE_STRING and TYPE_WSTRING > > suffice with documentation > > I'm happy with that. > > > > and DCHECKs for UTF-8 std::strings? > > What is the source of the data? We normally don't bother verifying the > encoding because that be very clumsy. But depending on the source, > this may be helpful. > The biggest user I've come across is JSONReader and JSONWriter. > > Brett > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/chromium-dev?hl=en -~----------~----~----~----~------~----~------~--~---
