[chromium-dev] Re: NSS and NSPR

2009-02-25 Thread Darin Fisher
Hmm... I'm OK with having the small duplication of NSS/NSPR code for the foreseeable future. I think it is nice that base doesn't require all of NSS+NSPR. So, I guess that's a +1 in favor of moving it to deps_os as planned. -Darin On Wed, Feb 25, 2009 at 9:08 PM, Michael Moss wrote: > Does

[chromium-dev] Re: NSS and NSPR

2009-02-25 Thread Michael Moss
Does that imply that it shouldn't move to deps? We can restrict it to Linux with deps_os now, and then make it apply to all platforms later, right? Or is it better to just leave it in trunk since it's already there? I'm fine with it either way, though it's less hassle for me to leave it where it i

[chromium-dev] Re: NSS and NSPR

2009-02-25 Thread Darin Fisher
If we do that cleanup, then we will need NSS and NSPR on all platforms. -Darin On Wed, Feb 25, 2009 at 7:31 PM, Michael Moss wrote: > > There are actually both nss and nspr under base, but only a handful of > files, not the whole trees. I plan to clean those up as appropriate, > once this is a

[chromium-dev] Re: NSS and NSPR

2009-02-25 Thread Thomas Van Lenten
On Wed, Feb 25, 2009 at 10:29 PM, Michael Moss wrote: > On Wed, Feb 25, 2009 at 5:04 PM, Thomas Van Lenten > wrote: > > Sorry for arriving late w/ this question... > > > > I'm guessing NSS & NSPR are needed for the linux build? Should they be > > pulled in via DEPS instead of being directly in

[chromium-dev] Re: linux async IO

2009-02-25 Thread Craig Schlenter
On Wed, Feb 25, 2009 at 11:21 PM, Adam Langley wrote: > > On Wed, Feb 25, 2009 at 1:13 PM, William Chan (陈智昌) > wrote: >> I talked to Darin and he told me that this needs work since it's >> impacting the page cycler times, so I figured I'd pick it up. You >> have a TODO there saying to figure o

[chromium-dev] Re: NSS and NSPR

2009-02-25 Thread Michael Moss
There are actually both nss and nspr under base, but only a handful of files, not the whole trees. I plan to clean those up as appropriate, once this is all in and working. Michael On Wed, Feb 25, 2009 at 5:15 PM, Lei Zhang wrote: > > BTW, we have both src/third_party/nss/ and src/base/third_pa

[chromium-dev] Re: NSS and NSPR

2009-02-25 Thread Michael Moss
On Wed, Feb 25, 2009 at 5:04 PM, Thomas Van Lenten wrote: > Sorry for arriving late w/ this question... > > I'm guessing NSS & NSPR are needed for the linux build?  Should they be > pulled in via DEPS instead of being directly in src/third_party?  In the > current form it causes both mac and wind

[chromium-dev] Re: NSS and NSPR

2009-02-25 Thread Lei Zhang
BTW, we have both src/third_party/nss/ and src/base/third_party/nss/. On Wed, Feb 25, 2009 at 5:04 PM, Thomas Van Lenten wrote: > Sorry for arriving late w/ this question... > > I'm guessing NSS & NSPR are needed for the linux build?  Should they be > pulled in via DEPS instead of being directly

[chromium-dev] NSS and NSPR

2009-02-25 Thread Thomas Van Lenten
Sorry for arriving late w/ this question... I'm guessing NSS & NSPR are needed for the linux build? Should they be pulled in via DEPS instead of being directly in src/third_party? In the current form it causes both mac and windows to have to add ~80M to their svn trees that really isn't needed.

[chromium-dev] [linux] converting some notimplemented()s into bugs

2009-02-25 Thread Evan Martin
As we get closer to something stable, it's helpful to not have real error messages masked by console spew about bits we don't especially care about yet. For example, we currently output this on startup: [4635:4635:1130873151532:ERROR:browser/process_singleton_linux.cc(60)] Not implemented reach

[chromium-dev] Re: linux async IO

2009-02-25 Thread 陈智昌
Woops, newbie mistake, sent from my google.com addr the first time. 2009/2/25 William Chan (陈智昌) : > Sorry for not being clear. Yep, you're correct, I'm not planning use > POSIX async IO. Just planning to execute the sync IO on the > WorkerPool. > > On Wed, Feb 25, 2009 at 1:21 PM, Adam Langley

[chromium-dev] Let's make build system history!

2009-02-25 Thread Mark Mentovai
Over the past month, some of us have been working on a not-so-well-kept secret project to create a "build system system." Our goal is to have something Generate Your Projects (GYP) in a variety of formats, all from the same source. Today, we're ready to allow Mac developers to begin testing this

[chromium-dev] Re: linux async IO

2009-02-25 Thread Adam Langley
On Wed, Feb 25, 2009 at 1:13 PM, William Chan (陈智昌) wrote: > I talked to Darin and he told me that this needs work since it's > impacting the page cycler times, so I figured I'd pick it up.  You > have a TODO there saying to figure out how to best do async IO.  Did > you ever figure this out?  I

[chromium-dev] linux async IO

2009-02-25 Thread 陈智昌
Hey Dean, I talked to Darin and he told me that this needs work since it's impacting the page cycler times, so I figured I'd pick it up. You have a TODO there saying to figure out how to best do async IO. Did you ever figure this out? I talked to Darin briefly and decided that the simplest thi

[chromium-dev] Re: [Linux] new symlinks needed

2009-02-25 Thread Adam Langley
On Wed, Feb 25, 2009 at 1:00 PM, Adam Langley wrote: > Linux builds after r10369 will need some additional symlinks on 64-bit > Ubuntu machines. Also, one may notice that red and blue are swapped on shared memory X setups. I'll be fixing that soon ;) AGL --~--~-~--~~~-

[chromium-dev] [Linux] new symlinks needed

2009-02-25 Thread Adam Langley
Linux builds after r10369 will need some additional symlinks on 64-bit Ubuntu machines. Ubuntu messed up the /usr/lib32 directory, this should fix it. Evan is updating the docs: # cd /usr/lib32 # ln -s libX11.so.6.2.0 libX11.so # ln -s libXrender.so.1.3.0 libXrender.so # ln -s libXext.so.6.4.0 l

[chromium-dev] Re: Streamlining key events

2009-02-25 Thread Peter Kasting
On Wed, Feb 25, 2009 at 11:49 AM, Evan Martin wrote: > As your prize, I send you a video of RMS dancing: > http://www.youtube.com/watch?v=Pube5Aynsls RMS is disturbed that video of himself is available on a site not run by Free Software. I am just disturbed at that video of him. PK --~--~---

[chromium-dev] Re: Streamlining key events

2009-02-25 Thread Evan Martin
Avi went above and beyond the call of duty to make it work on Linux too! As your prize, I send you a video of RMS dancing: http://www.youtube.com/watch?v=Pube5Aynsls On Wed, Feb 25, 2009 at 11:15 AM, Avi Drissman wrote: > If you never use the keyboard in Chromium, you can skip this email. > > I

[chromium-dev] Streamlining key events

2009-02-25 Thread Avi Drissman
If you never use the keyboard in Chromium, you can skip this email. I'm going to land http://codereview.chromium.org/27056 which fixes most of the glaring problems with keyboard support on the Mac by unifying and streamlining key events for everyone. If things don't work for you, it's probably my

[chromium-dev] Re: Mac chrome from the tree

2009-02-25 Thread Mohamed Mansour
Great! Keep up the good work :) On Wed, Feb 25, 2009 at 9:19 AM, Mike Pinkerton wrote: > > Actually, http://dev.chromium.org wasn't ever a problem. More importantly: > > We can now render http://www.google.com without crashing!!! > > :-D > > On Wed, Feb 25, 2009 at 12:32 AM, John Grabowski wrot

[chromium-dev] Re: Mac chrome from the tree

2009-02-25 Thread Mike Pinkerton
Actually, http://dev.chromium.org wasn't ever a problem. More importantly: We can now render http://www.google.com without crashing!!! :-D On Wed, Feb 25, 2009 at 12:32 AM, John Grabowski wrote: > For Mac Chrome multiprocess bringup a group of us had been throwing diffs > around. There were v

[chromium-dev] Re: Google Chrome's Most visited page is inferior to Apple Safari 4 (beta) Top Sites page

2009-02-25 Thread Mike Pinkerton
+1 meetoo On Wed, Feb 25, 2009 at 12:43 AM, Peter Kasting wrote: > On Tue, Feb 24, 2009 at 6:34 PM, Evan Martin wrote: >> >> Yes, I would suggest it is urgent that we improve all of Chromium as >> rapidly as possible. > > I AGREE THINGS THAT ARE BAD SHOULD BE LESS BAD > PLEASE TO BE FIX THIS N

[chromium-dev] Mac/Linux & blank tabs (or "don't panic!")

2009-02-25 Thread Mike Pinkerton
Hey folks, just a heads up. I landed some changes to browser/dom_ui and the temp scaffolding to begin the process of hooking up the new tab page. As of right now, however, all it does is load a url called "chrome-internal:" and display a blank tab. This is expected behavior. I didn't want anyone