[chromium-dev] Re: Setting Default Search Engine

2009-04-22 Thread stylo~
On Mar 21, 5:36 am, Pam Greene wrote: > Yes, Chromium supports the OpenSearch specification. As you browse pages, if > they offer a search engine (a tag), we'll pick it up and > automatically add it to the list of engines available in the browser. For > instance, visithttp://www.slashdot.org/an

[chromium-dev] not able to run chrome.exe

2009-04-22 Thread mailandroid
Hi, I have built the source on windows(making chrome_exe as start up project) and able to create chrome.exe. But I am not able to run the exe. Opening an exe will give me error message saying "[2412:3744:8310875:FATAL:render_widget_host_view_win.cc(557)]Check failed: render_widget_host_->process(

[chromium-dev] Re: Setting Default Search Engine

2009-04-22 Thread stylo~
Btw, I just tried http://mycroft.mozdev.org/youtube-search-plugins.html and those WILL install for me in Chrome, I get the popup, but I copied the script there to my page and it wouldn't work for me in Chome, only FF. I have no apparent js errors on my site in Chome either. Tried various scripts,

[chromium-dev] Re: hammer build error

2009-04-22 Thread jack...@gmail.com
This thread really helped me. I was getting the same can't cd to error so executing the "gclient sync --force" command and removing the sconsbuild directory worked prefectly. One note. I am building chrome on Ubuntu 9.04 RC and found that the install-build-deps.sh will only work for 8.04/8.10 alt

[chromium-dev] Please use BUG and TEST in changelists

2009-04-22 Thread Mark Larson (Google)
All changelists should have TEST= BUG= if at all feasible. Why? TEST= will ensure that testers get the information they need to cover your change. What needs to be tested is not always obvious from the CL description. Sometimes a change in base/ can impact the installer or downloads. Help t

[chromium-dev] Re: Remove svn from deps/third_party?

2009-04-22 Thread Darin Fisher
IIRC, some people (peter?) have had /usr/bin/svn on their path ahead of depot_tools, since they don't want our svn interfering with their webkit checkout. this used to work if you always accessed our svn by calling gvn instead (yes, i meant gvn). i believe that gcl, like gvn, will also pass throu

[chromium-dev] Re: Remove svn from deps/third_party?

2009-04-22 Thread Adam Barth
Sounds good to me. (Although if I had my way, we'd check the entire toolchain into SVN, gcc and all.) Adam On Wed, Apr 22, 2009 at 9:58 PM, Mark Larson (Google) wrote: > I filed http://bugs.chromium.org/10872 for this... > > From src/chrome/tools/build/win/version.bat: > :: Determine the curr

[chromium-dev] Remove svn from deps/third_party?

2009-04-22 Thread Mark Larson (Google)
I filed http://bugs.chromium.org/10872 for this... >From src/chrome/tools/build/win/version.bat: :: Determine the current repository revision number set PATH=%~dp0..\..\..\..\third_party\svn;%PATH% svn.exe info | grep.exe "Revision:" | cut -d" " -f2- | sed "s/\(.*\)/set LASTCHANGE=\1/" >> %VarsB

[chromium-dev] Don't do work in a DCHECK

2009-04-22 Thread Mark Larson (Google)
(rafaelw, this isn't personal. It's just the most recent example.) src/chrome/browser/extensions/extension_tabs_module.cc contains this code at line 229: 229 int new_index; 230 DCHECK(args->GetInteger(L"index", &new_index)); 231 if (new_index < 0) { 232DCHECK(false); 233return false; 23

[chromium-dev] GSoC: Network Stack in Chromium

2009-04-22 Thread Smita
Hello, I am not sure if this is the correct forum to put in this question, but I was just curious to know where my application lacked, and why it did not qualify. Your feedback is greatly appreciated! Thanks, Smita --~--~-~--~~~---~--~~ Chromium Developers mailin

[chromium-dev] Re: Getting LOG(INFO) to print

2009-04-22 Thread cpu
My apologies to Pink. For future reference here is the email I sent to the team: dateFri, Aug 29, 2008 at 2:45 PM subject default logging level change in chrome I've committed a change in ToT for chrome that: 1- Increases the default (minimum) login level from INFO to WARNING 2- Allows to sp

[chromium-dev] Please do not remove intentional crashes

2009-04-22 Thread cpu
As a hard and fast rule you can consider any crash where we are not intentionally trying to crash (using __debugbreak(), DebugBreak(), RaiseException() or CHECK ) as probably exploitable. If you think a little bit about a crash you might be tempted to think it is not exploitable, but is easy to g

[chromium-dev] Re: [extensions] Proposed changes to PageActions API

2009-04-22 Thread Aaron Boodman
On Wed, Apr 22, 2009 at 5:07 PM, Nick Baum wrote: > On Wed, Apr 22, 2009 at 4:38 PM, Aaron Boodman wrote: >> >> So Finnur is looking at the Page Actions API >> >> (http://dev.chromium.org/developers/design-documents/extensions/page-actions-api). >> Right now, the proposed API for creating one of

[chromium-dev] Re: [extensions] API sprucing

2009-04-22 Thread Nick Baum
Thanks for doing this. Comments inline. On Wed, Apr 22, 2009 at 3:35 PM, Aaron Boodman wrote: > > A few of us extension guys were talking offline Monday about how now > that we've all had a chance to implement some APIs, we are probably > better positioned to come to consensus on the remaining s

[chromium-dev] Re: [extensions] Proposed changes to PageActions API

2009-04-22 Thread Nick Baum
On Wed, Apr 22, 2009 at 4:38 PM, Aaron Boodman wrote: > > So Finnur is looking at the Page Actions API > ( > http://dev.chromium.org/developers/design-documents/extensions/page-actions-api > ). > Right now, the proposed API for creating one of these bad boys is: > > create({string name, [string j

[chromium-dev] [extensions] Proposed changes to PageActions API

2009-04-22 Thread Aaron Boodman
So Finnur is looking at the Page Actions API (http://dev.chromium.org/developers/design-documents/extensions/page-actions-api). Right now, the proposed API for creating one of these bad boys is: create({string name, [string javascript], [string faviconUrl], [bool executeInPage]}, [function callba

[chromium-dev] [extensions] API sprucing

2009-04-22 Thread Aaron Boodman
A few of us extension guys were talking offline Monday about how now that we've all had a chance to implement some APIs, we are probably better positioned to come to consensus on the remaining style points. I went through the existing three browser APIs (windows, tabs, and bookmarks -- http://dev

[chromium-dev] Re: Turned on tcmalloc

2009-04-22 Thread Sverrir Á . Berg
See: http://codereview.chromium.org/92037 Sverrir On Wed, Apr 22, 2009 at 4:29 PM, Tommi wrote: > I'm still getting those errors. Like Sverrir I'm using VS2008. What's the > magic required to get chrome.dll to link? > > > On Wed, Apr 22, 2009 at 11:02 AM, Mike Belshe wrote: > >> It should wo

[chromium-dev] Re: Turned on tcmalloc

2009-04-22 Thread Tommi
I'm still getting those errors. Like Sverrir I'm using VS2008. What's the magic required to get chrome.dll to link? On Wed, Apr 22, 2009 at 11:02 AM, Mike Belshe wrote: > It should work :-) > I'd check chrome/app/chrome_dll.vcproj for changes. > > The basic idea is: >* these functions are

[chromium-dev] Re: Getting LOG(INFO) to print

2009-04-22 Thread Evan Martin
code.google.com is world-writable, so many of the docs there involve user contributions. (E.g. the fedora build instructions.) On Wed, Apr 22, 2009 at 11:49 AM, Andrew Scherkus wrote: > I might have missed this memo, but why are we splitting documentation across > dev.chromium.org and code.goog

[chromium-dev] Re: Getting LOG(INFO) to print

2009-04-22 Thread Andrew Scherkus
I might have missed this memo, but why are we splitting documentation across dev.chromium.org and code.google.com? Andrew On Wed, Apr 22, 2009 at 11:37 AM, Evan Martin wrote: > > Since Pinkerton just lost some hours to this and I did again: > The secret to getting LOG(INFO) to show is to pass --

[chromium-dev] Getting LOG(INFO) to print

2009-04-22 Thread Evan Martin
Since Pinkerton just lost some hours to this and I did again: The secret to getting LOG(INFO) to show is to pass --log-level=0 when you run. I added this to http://code.google.com/p/chromium/wiki/LinuxDebugging (which, by the way, has had a lot of content added since you last looked). --~--~

[chromium-dev] 2.0.176.0 for Dev Channel cut at r14196

2009-04-22 Thread Jon
I have the CL I needed so I am going to cut the new dev channel release from the trunk at r14196. This brings in the fix for scrolling in GMail. Jon --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email

[chromium-dev] Re: [extensions] Refactoring design docs

2009-04-22 Thread Aaron Boodman
Resending from right address... - a On Wed, Apr 22, 2009 at 10:32 AM, Aaron Boodman wrote: > I've started a small refactor of our design docs: > http://sites.google.com/a/chromium.org/dev/developers/design-documents/extensions > >  The main changes are: > > - Created a new simple "homepage" for

[chromium-dev] Chromium April 21 2009 total failure post mortem

2009-04-22 Thread Marc-Antoine Ruel
- If you have issues with gcl or gclient misbehaving, reads the "End Results" section.- If you don't care about the build breakage and code review tool screw up yesterday, you can stop reading now. - If you want to laugh about me, continue reading. Timeline (all times in PDT) *On Fri Apr 17 at 6

[chromium-dev] Re: URLRequestMockHTTPJob?

2009-04-22 Thread Mike Pinkerton
Ah, I found it. My LOG(INFO)s weren't getting printed correctly, a two-hour red herring. The problem was that DIR_SOURCE_ROOT was wrong for bundles, while it worked fine for the test executables. I guess this was the first use from w/in Chromium or TestShell. On Wed, Apr 22, 2009 at 9:33 AM, Mik

[chromium-dev] Re: Turned on tcmalloc

2009-04-22 Thread Mike Belshe
It should work :-) I'd check chrome/app/chrome_dll.vcproj for changes. The basic idea is: * these functions are now provided by an alternate libcmt which is in the tcmalloc directory. * there is a build step as part of tcmalloc which creates this library (prep_libc.sh) * chrome.dll now ig

[chromium-dev] Re: Turned on tcmalloc

2009-04-22 Thread Sverrir Á . Berg
Even after doing the clobber & runhooks raindance I'm getting linker errors: 143>tcmalloc.lib(override_functions.obj) : error LNK2005: _malloc already defined in libcmt.lib(malloc.obj) 143>tcmalloc.lib(override_functions.obj) : error LNK2005: _free already defined in libcmt.lib(free.obj) 143>tcmall

[chromium-dev] Re: Turned on tcmalloc

2009-04-22 Thread Sverrir Á . Berg
Even after doing the clobber & runhooks raindance I'm getting linker errors: 143>tcmalloc.lib(override_functions.obj) : error LNK2005: _malloc already defined in libcmt.lib(malloc.obj) 143>tcmalloc.lib(override_functions.obj) : error LNK2005: _free already defined in libcmt.lib(free.obj) 143>tcmall

[chromium-dev] Turned on tcmalloc

2009-04-22 Thread Mike Belshe
I turned on tcmalloc last night as an experiment. I left it on so far. The good news is the perf: http://build.chromium.org/buildbot/perf/dashboard/overview.html The bad news is the reliability bot shows some crashes. I believe these are crashes not caused by tcmalloc but exposed by it. We'll f

[chromium-dev] Re: URLRequestMockHTTPJob?

2009-04-22 Thread Mike Pinkerton
The problem I'm seeing is that this is getting called before the ChromePathProvider has been registered with the path service in the browser, so it doesn't get any path. I'll keep digging as to why. On Tue, Apr 21, 2009 at 6:11 PM, Tony Chang wrote: > It tries to get it from PathService::Get(ch