[chromium-dev] Re: Request for comments: Feed preview work

2009-05-07 Thread Ben Goodger (Google)
Regardless of whose authority they run at, it is somewhat desirable to have the feed URL display in the address bar, since that's the content that's being loaded. I would like to keep the flow in page as much as possible. We should be able to come up with some solution here that doesn't involve

[chromium-dev] Re: Request for comments: Feed preview work

2009-05-07 Thread Aaron Boodman
Let's say the feed is http://foo.com/feed.xml What about a setup where the content rendered in the tab area is running on chrome://, but contains a frame that hosts the actual feed running on http://foo.com? The subscribe UI runs on the other page, so it is the only thing that needs elevated

[chromium-dev] FYI: DEFER no longer means anything

2009-05-07 Thread Ojan Vafai
I just committed a change that removes defer from text_expectations.txt. That means that the number of failing tests the bot reports is the total number of webkit tests that we'll ever want to fix (e.g. win-release went from 141 fixable to 768 fixable). In order to know which of those tests need

[chromium-dev] Re: Tab-modal dialogs on the Mac

2009-05-07 Thread Amanda Walker
That's cleaner than I expected, and the behavior looks right. Nice job! I vote for continuing with this approach. --Amanda On Thu, May 7, 2009 at 12:17 AM, Avi Drissman a...@google.com wrote: OK, so attached is my proof of concept. The code is pretty clear, though if you have questions,

[chromium-dev] Re: Request for comments: Feed preview work

2009-05-07 Thread Itai
Minor comment, but I assume you will be triggering the feed-preview when people click on a link to the feed as well. Many sites have an RSS link to the feed's XML file because it is previewable in many browsers without autodiscovery. Currently, Chrome shows unformated XML. Doing CTRL-U after

[chromium-dev] Re: Tab-modal dialogs on the Mac

2009-05-07 Thread Mike Pinkerton
I dig it! NICE! It's similar to the overlay window trick we use for tab dragging between windows. Maybe for consistency you should call the hanger window the overlay window? Is there any way we can keep this generic and put it into GTM? On Thu, May 7, 2009 at 8:46 AM, Amanda Walker

[chromium-dev] Re: Request for comments: Feed preview work

2009-05-07 Thread Darin Fisher
chrome:// pages cannot load HTTP-based sub-resources. We don't want to taint the processes that render Chrome UI. -Darin On Wed, May 6, 2009 at 11:55 PM, Aaron Boodman a...@chromium.org wrote: Let's say the feed is http://foo.com/feed.xml What about a setup where the content rendered in the

[chromium-dev] Re: Request for comments: Feed preview work

2009-05-07 Thread Darin Fisher
I see. That probably simplifies things. Hmm... -Darin On Wed, May 6, 2009 at 10:51 PM, Adam Barth aba...@chromium.org wrote: I don't think we want these feed previews to run with foo.com's authority. I'd rather they ran with no one's authority. Adam On Wed, May 6, 2009 at 8:42 PM,

[chromium-dev] Re: depot_tools is moving!

2009-05-07 Thread avcoder
I fail to update I get the following message: E:\depot_toolsgclient help Installing subversion ... [-] ADODB.Stream 800a01ad: Cannot save file (Automation server can't create object) ... Failed to checkout svn automatically. Please visit http://subversion.tigris.org to download the latest

[chromium-dev] Re: Request for comments: Feed preview work

2009-05-07 Thread Aaron Boodman
On Thu, May 7, 2009 at 12:03 AM, Adam Barth aba...@chromium.org wrote: On Wed, May 6, 2009 at 11:55 PM, Aaron Boodman a...@chromium.org wrote: What about a setup where the content rendered in the tab area is running on chrome://, but contains a frame that hosts the actual feed running on

[chromium-dev] Re: Tab-modal dialogs on the Mac

2009-05-07 Thread Avi Drissman
1. Naming's arbitrary. The name hanger window comes from an earlier design idea where the clear window was sized only 10 px high, and was the hanger upon which the sheet hung. Once I got the idea that I could also use it to block input to the underlying view, I guess it outgrew the name. (shrug)

[chromium-dev] Re: depot_tools is moving!

2009-05-07 Thread Marc-Antoine Ruel
Please visit http://subversion.tigris.org to download the latest subversion client before continuing. You can also get the prebacked version used at http://src.chromium.org/svn/trunk/tools/third_party/ The thing that is missing now is to stop the message from happening you need to create

[chromium-dev] Try out --enable-omnibox2!

2009-05-07 Thread Ben Goodger (Google)
Please try out the --enable-omnibox2 command line switch in Chrome and file bugs against me in the issue tracker. I'd like to get a better sense of what needs to be done with it so we can turn it on by default. The differences thus far are aesthetic, and in the popup. -Ben

[chromium-dev] Re: webkit gyp conversion, another (likely) attempt tonight

2009-05-07 Thread Steven Knight
Heads up: I'm gearing up to close the tree tonight for another attempt at converting the webkit build to gyp, closure starting some time between 20:00 and 22:00 PDT. If this would be a serious imposition, let me know. I'm still working on a few last issues. If I run into another serious

[chromium-dev] Re: Getting LOG(INFO) to print

2009-05-07 Thread Lei Zhang
I'm having the opposite problem. I did a release build on Linux, and I get tons of INFO spew. --log-level=N for N 0 doesn't turn it off. On Wed, Apr 22, 2009 at 11:37 AM, Evan Martin e...@chromium.org wrote: Since Pinkerton just lost some hours to this and I did again: The secret to getting

[chromium-dev] Re: Regarding using bookmark to save user info...

2009-05-07 Thread jack
Thanks for your tips PhistucK. I am using dev version (2.0.177.1). You are right the object name is chromium, and it works for the extension domain (chrome-extension://[id]/*). Also in web main (http://*) I can get chromium.extension.id_, but not chromium.bookmarks. Also although

[chromium-dev] Re: Regarding using bookmark to save user info...

2009-05-07 Thread PhistucK
I am not sure you can (currently) connect from an HTTP origin to an extension. I guess it is not implemented yet or not even allowed at all. ☆PhistucK 2009/5/7 jack js2...@gmail.com Thanks for your tips PhistucK. I am using dev version (2.0.177.1). You are right the object name is chromium,

[chromium-dev] Re: Regarding using bookmark to save user info...

2009-05-07 Thread jack
I'd rather believe it is a not-ready rather than not-allowed issue. Content scripts run in the http domain, and it is the recommended manner for content script to communicate w/ the extension, unless I understood it wrong. -Jack On May 7, 11:39 am, PhistucK phist...@gmail.com wrote: I am not

[chromium-dev] Re: Regarding using bookmark to save user info...

2009-05-07 Thread PhistucK
Oh, sorry, I thought you meant pure page javascript.Yes, of course, the content script is supposed to be able to interact. ☆PhistucK 2009/5/7 jack js2...@gmail.com I'd rather believe it is a not-ready rather than not-allowed issue. Content scripts run in the http domain, and it is the

[chromium-dev] Re: depot_tools is moving!

2009-05-07 Thread Greg Spencer
After checking out the latest from the new location, when I run 'gclient' now, I just get the following message (on Vista 64-bit): The system cannot find the batch label specified - SVN_FORCE -Greg. On Thu, May 7, 2009 at 8:56 AM, Marc-Antoine Ruel mar...@chromium.orgwrote: Please visit

[chromium-dev] Linux: removing dependency on libviews

2009-05-07 Thread Paweł Hajdan Jr .
I'm working on http://crbug.com/11066 (removing depencency on libviews on Linux), and there's one thing I'm not sure how to do. It would be a good thing to ensure not only that nothing on Linux links to libviews, but also that nothing built on Linux doesn't #include anything in chrome/views/ For

[chromium-dev] Re: depot_tools is moving!

2009-05-07 Thread Marc-Antoine Ruel
Thanks, fixed in revision 15567. Sorry about that. You will have to svn up your depot_tools directory. M-A On Thu, May 7, 2009 at 12:17 PM, Greg Spencer gspen...@google.com wrote: After checking out the latest from the new location, when I run 'gclient' now, I just get the following message

[chromium-dev] Re: Linux: removing dependency on libviews

2009-05-07 Thread Marc-Antoine Ruel
I could be a PRESUBMIT.py check that parses the .gyp files instead. M-A 2009/5/7 Paweł Hajdan Jr. phajdan...@chromium.org I'm working on http://crbug.com/11066 (removing depencency on libviews on Linux), and there's one thing I'm not sure how to do. It would be a good thing to ensure not only

[chromium-dev] Re: Implementing an onidle event (and the Linux implications)

2009-05-07 Thread Adam Barth
I'd encourage you to implement it for extensions first. It seems really useful for queuing up notifications, etc. Adam 2009/5/7 PhistucK phist...@gmail.com: (Creating a new thread for it.) So, I started looking into it. And as you wrote, in order to implement this function for all of the

[chromium-dev] Re: Passing PlatformGraphicsContext from WebKit to Chrome code

2009-05-07 Thread Andrew Scherkus
On Wed, May 6, 2009 at 10:44 AM, Darin Fisher da...@chromium.org wrote: We could either use skia/ext/platform_canvas_mac.h or we could define it to be a CG type. I'm not sure I fully understand the hybridization of CG and Skia in our Chromium Mac port. I am equally (or even more so)

[chromium-dev] Re: Passing PlatformGraphicsContext from WebKit to Chrome code

2009-05-07 Thread Darin Fisher
We have exactly the same issue with WebWidget::paint. That uses WebCanvas. I think that WebMediaPlayer::paint should be the same. -Darin On Thu, May 7, 2009 at 1:50 PM, Andrew Scherkus scher...@chromium.orgwrote: On Wed, May 6, 2009 at 10:44 AM, Darin Fisher da...@chromium.org wrote: We

[chromium-dev] Re: Graceful updates on Linux

2009-05-07 Thread Dan Kegel
Is this still the plan? I don't see any alternative, since on Linux, when we get updated, the old version's files are no longer available, so any old instances still running either have to be happy with the new version's files, or not need any files at all. On Thu, Feb 5, 2009 at 11:35 AM,

[chromium-dev] Re: Graceful updates on Linux

2009-05-07 Thread Evan Martin
This is still the vague plan, at least. Nobody's really looked at performance yet beyond making new tabs sure is slow on Linux; maybe the zygote bit would help, but it seems equally likely to me that we've got other things going wrong. On Thu, May 7, 2009 at 2:19 PM, Dan Kegel

[chromium-dev] Re: Graceful updates on Linux

2009-05-07 Thread Jeremy Orlow
I have no idea what I'm talking about, but hand wavingI just wanted to comment that on Linux when firefox is updated while I'm running, things start getting really weird and it generally becomes unusable pretty quickly...no idea why, but I assume it has something to do with its resources being

[chromium-dev] [extensions] content-type

2009-05-07 Thread Aaron Boodman
Right now, the extension system treats any downloaded file that ends in .crx as an extension. This seems like a bad idea, and that we should use a content type. Firefox uses the content type application/x-xpinstall. However, as a Firefox extension developer, I can tell you the content type thing

[chromium-dev] Re: [extensions] content-type

2009-05-07 Thread Adam Langley
On Thu, May 7, 2009 at 3:35 PM, Aaron Boodman a...@chromium.org wrote: I know that content sniffing is a very dirty business, but our crx files have a very specific format, including a few signature bytes at the very beginning. What if we supported both a content-type *and* did content

[chromium-dev] Re: [extensions] content-type

2009-05-07 Thread Evan Martin
On Thu, May 7, 2009 at 3:35 PM, Aaron Boodman a...@chromium.org wrote: Right now, the extension system treats any downloaded file that ends in .crx as an extension. This seems like a bad idea, and that we should use a content type. You have two use cases in mind here, and I think your

[chromium-dev] Re: [extensions] content-type

2009-05-07 Thread Aaron Boodman
On Thu, May 7, 2009 at 3:52 PM, Evan Martin e...@chromium.org wrote: You have two use cases in mind here, and I think your solutions are mixing them. In the (rare) case where someone has the correct mime type set, we should obey the mime type and do no sniffing.  I think that's

[chromium-dev] Re: [extensions] content-type

2009-05-07 Thread Adam Barth
On Thu, May 7, 2009 at 3:55 PM, Aaron Boodman a...@chromium.org wrote: On Thu, May 7, 2009 at 3:52 PM, Evan Martin e...@chromium.org wrote: Options here (I can't tell if you're suggesting #2 or #3): 1) filename extension only (what I'm suggesting) 2) require both filename extension and

[chromium-dev] Re: Implementing an onidle event (and the Linux implications)

2009-05-07 Thread David Levin
fwiw, gears had an implementation that didn't depend on XScreenSaverQueryInfo http://code.google.com/p/gears/source/detail?r=2641path=/trunk/gears/notifier/user_activity.cc see user_activity_linux.cc 2009/5/7 Adam Barth aba...@chromium.org I'd encourage you to implement it for extensions

[chromium-dev] Re: [extensions] content-type

2009-05-07 Thread Aaron Boodman
On Thu, May 7, 2009 at 4:09 PM, Adam Barth aba...@chromium.org wrote: Ugg. I know. What can I say? We are caught between idealism and practicality. 1) If the response has the right MIME type, then we can believe that the site has endorsed the extension.  As Adam says, Site

[chromium-dev] Re: Implementing an onidle event (and the Linux implications)

2009-05-07 Thread Evan Martin
Does this mean PhistucK could just rely on the gears implementation? Then it would require no Chrome changes. 2009/5/7 David Levin le...@chromium.org: fwiw, gears had an implementation that didn't depend on XScreenSaverQueryInfo

[chromium-dev] Re: [extensions] content-type

2009-05-07 Thread Adam Barth
On Thu, May 7, 2009 at 4:17 PM, Aaron Boodman a...@chromium.org wrote: Ok, thanks for the recommendation. Currently the magic string is Cr24. Not enough characters? I suggested the above to be analogous to HTML5's appcache manifests:

[chromium-dev] Re: Implementing an onidle event (and the Linux implications)

2009-05-07 Thread David Levin
That file has been deleted from gears -- not as a reflection on the implementation but due to the lack of its use in gears. 2009/5/7 Evan Martin e...@chromium.org Does this mean PhistucK could just rely on the gears implementation? Then it would require no Chrome changes. 2009/5/7 David

[chromium-dev] Re: Try out --enable-omnibox2!

2009-05-07 Thread Mohamed Mansour
Great! adds a new fresh look. One question though, is the transparency really needed? It distracts me for some reason from the actual results. I suggest lowering down the transparency a little, but that's just me. On Thu, May 7, 2009 at 1:53 PM, Ben Goodger (Google) b...@chromium.orgwrote:

[chromium-dev] Re: depot_tools is moving!

2009-05-07 Thread avcoder
Thanks Why not just apply the svn switch --relocate http://src.chromium.org/svn/trunk/depot_tools/ http://src.chromium.org/svn/trunk/tools/depot_tools/; if you only just switch to a new svn url? On Thu, May 7, 2009 at 11:56 PM, Marc-Antoine Ruel mar...@chromium.org wrote: Please visit

[chromium-dev] Re: webkit gyp conversion, another (likely) attempt tonight

2009-05-07 Thread Steven Knight
[sent this earlier, but from the wrong address...] I'm going ahead with the attempted webkit conversion tonight. ETA to close the tree ~20:30 PDT. --SK On Thu, May 7, 2009 at 11:02 AM, Steven Knight s...@chromium.org wrote: Heads up: I'm gearing up to close the tree tonight for another

[chromium-dev] FYI - src/chrome/views is now src/views

2009-05-07 Thread Ben Goodger (Google)
views has moved into a top level directory under src/. While not yet fully autonomous from chrome (yet) I am in the process of writing a stricter DEPS file that will now prevent new includes from chrome/. If you need to pull something into a common location used by views and some other part of

[chromium-dev] build error

2009-05-07 Thread Ojan Vafai
I've been getting the following build error for the past couple days on Windows. It happens if I use Incredibuild or VS. It happens on a totally fresh checkout. Any one have any ideas as to what could be causing this? 9-- Build started: Project: mksnapshot, Configuration: Debug Win32 --

[chromium-dev] Re: [extensions] content-type

2009-05-07 Thread Aaron Boodman
On Thu, May 7, 2009 at 4:20 PM, Adam Barth aba...@chromium.org wrote: On Thu, May 7, 2009 at 4:17 PM, Aaron Boodman a...@chromium.org wrote: Ok, thanks for the recommendation. Currently the magic string is Cr24. Not enough characters? I suggested the above to be analogous to HTML5's appcache

[chromium-dev] Linux splash page update

2009-05-07 Thread Evan Stade
I've noticed a good deal of helpful bugs filed recently for linux by people who are not developing chromum. Our splash page still says: Please don't file bugs: this point there are so many gaping holes that finding bugs is not the problem and dealing with them is just a distraction. I think