I finally got around to revising the text for this section of the coding
style doc to bring it inline with what I believe to be our prevailing usage.
Please let me know if you have any objections.
-Darin
On Wed, May 27, 2009 at 11:42 AM, Darin Fisher da...@chromium.org wrote:
Thanks for
I was thinking about using it in mobile environment. Your patch is
very useful there too.
And mobiles do not have slow HDD, so maybe reading it from file with
proper caching can be fast enough.
Dmitry
On 7 июл, 13:23, Brett Wilson bre...@chromium.org wrote:
On Mon, Jul 6, 2009 at 9:14 PM,
i am not 100% sure i know the reason, but i have a good feeling i do
i think that when i do 'gclient sync --force' i am getting all the
layout tests even though
i specifically excluded them using your published method, and it seems
to work when i don't have the --force flag
however, --force is
On Tue, Jul 7, 2009 at 7:25 AM, Marc-Antoine Ruel mar...@chromium.orgwrote:
On Mon, Jul 6, 2009 at 6:28 PM, Marshall Greenblatt
magreenbl...@gmail.com wrote:
On Mon, Jul 6, 2009 at 6:09 PM, Darin Fisher da...@chromium.org wrote:
I'm not sure what would be best. I was just describing the
On Mon, Jul 6, 2009 at 6:28 PM, Marshall Greenblatt
magreenbl...@gmail.comwrote:
On Mon, Jul 6, 2009 at 6:09 PM, Darin Fisher da...@chromium.org wrote:
I'm not sure what would be best. I was just describing the problem. It
might help to setup a buildbot for chromiumembedded on the fyi page:
Excellent!
On Jul 6, 2009 9:43 PM, Elliot Glaysher (Chromium) e...@chromium.org
wrote:
This is the best news I've heard in the last week.
Thank you, Thank you, Thank you.
-- Elliot
On Mon, Jul 6, 2009 at 9:11 PM, John Abd-El-Malekj...@chromium.org wrote:
Just a heads up that y...
It was a long weekend and meetings; I'll get to these today.
On Mon, Jul 6, 2009 at 8:45 PM, Thiago Farinathiago.far...@gmail.com wrote:
Hi Lei, these are the patches that I have submitted:
http://codereview.chromium.org/155060
http://codereview.chromium.org/155059
I have more but these
With a gclient sync this morning, it seems very confused about
ffmpeg/binaries. First the sync failed saying that ffmpeg/binaries was from
a different repository. Then I removed the directory and did a sync where
it pulled down ffmpeg/binaries again and told me that ffmpeg/binaries was no
longer
On Tue, Jul 7, 2009 at 9:05 AM, Erik Kay erik...@chromium.org wrote:
With a gclient sync this morning, it seems very confused about
ffmpeg/binaries. First the sync failed saying that ffmpeg/binaries was from
a different repository. Then I removed the directory and did a sync where
it pulled
Apologies... you tickled one of the edge cases that gclient doesn't handle
well. Patches welcome!
http://code.google.com/p/gclient/
-Darin
On Mon, Jul 6, 2009 at 1:49 PM, Andrew Scherkus scher...@chromium.orgwrote:
I just checked in a Chromium-specific version of FFmpeg that only includes
Unfortunately there isn't a good solution to not checking out the
layout test data :(
The LayoutTests:None line in .gclient is a good start, but it doesn't
prevent the pollution from webkit/data/layout_tests/platform.
There is already a discussion of this at:
This question comes up every so often on webkit-dev. :)
The response there has been why does one ever want a webkit source
checkout w/o layout tests?
- If you're doing development, you need the layout tests.
- If you're just want to run tip-of-tree, nightly builds are a better
way of doing
Lei can you review this patch for me?
http://codereview.chromium.org/155078
On Jul 6, 11:56 pm, Lei Zhang thes...@chromium.org wrote:
You didn't give enough context. It'll be more helpful if you put links
to the patches you want reviewed.
On Mon, Jul 6, 2009 at 7:47 PM, Thiago
On Tue, Jul 7, 2009 at 4:46 PM, Marshall Greenblatt
magreenbl...@gmail.comwrote:
What is the best way to apply Rietveld issue patches from the command-line?
patch -p0 /path/to/patch.txt
PK
--~--~-~--~~~---~--~~
Chromium Developers mailing list:
If you are using git-cl:
git cl patch patch URL or rietveld issue id
On Tue, Jul 7, 2009 at 4:46 PM, Marshall
Greenblattmagreenbl...@gmail.com wrote:
Hi All,
What is the best way to apply Rietveld issue patches from the command-line?
I've found WebKit's nifty svn-apply script that does
On Tue, Jul 7, 2009 at 7:50 PM, Elliot Glaysher (Chromium) e...@chromium.org
wrote:
If you are using git-cl:
git cl patch patch URL or rietveld issue id
Ok, it's time to jump of the git bandwagon :-) Thanks for the fast
responses guys!
On Tue, Jul 7, 2009 at 4:46 PM, Marshall
Quick question because I have no clue where/how watchlists are
implemented...
According to the watchlist file, brettw is watching base from /src. kylep
sent me a code review that only modifies touches files in /src/media/base,
however brettw got added to the cc list.
Is this intended behavior
Interesting question. I have the same doubt.
On Jul 7, 10:26 pm, Andrew Scherkus scher...@chromium.org wrote:
Quick question because I have no clue where/how watchlists are
implemented...
According to the watchlist file, brettw is watching base from /src. kylep
sent me a code review that
I believe Brett intended to watch only src/base/.If so, he can change the
regexp to be more specific, such as '^base/.*'
For a quick test you can run the watchlist.py program with a filename to
find out what matches.
E.g. $DEPOT_PATH/watchlist.py base/foo.py - prints out the
watchers for that
On Tue, Jul 7, 2009 at 2:59 PM, Kruncherleaha...@gmail.com wrote:
I would like to use the Chromium source code as the basis to a custom
documentation viewer. The following outlines what I would like to do
with the source:
- Add sidebar panels to left/right of each Chromium window.
- Remove
On Tue, Jul 7, 2009 at 6:20 PM, Andrew Scherkusscher...@google.com wrote:
According to the watchlist file, brettw is watching base from /src
kylep sent me a code review that only modifies touches files in
/src/media/base, however brettw got added to the cc list.
Is this intended behavior for
21 matches
Mail list logo
