On Mon, Nov 16, 2009 at 9:07 PM, Ian Fette wrote:
> Lint will warn you about this -- and I know that everyone runs gcl lint
> changelist_name before uploading...
Why do I have to remember to run a separate command? Why does this not run
during presubmit?
PK
--
Chromium Developers mailing li
Lint will warn you about this -- and I know that everyone runs gcl lint
changelist_name before uploading...
-Ian
2009/11/16 Dan Kegel
> On Mon, Nov 16, 2009 at 7:31 PM, Peter Kasting
> wrote:
> > Yeah, and are our preprocessors actually going to do what's described in
> > that post? I'm sure
On Mon, Nov 16, 2009 at 7:31 PM, Peter Kasting wrote:
> Yeah, and are our preprocessors actually going to do what's described in
> that post? I'm sure MSVC won't. I doubt gcc on Mac/Linux will.
This was a real issue for me with gcc a few years ago (at Google, IIRC).
- Dan
--
Chromium Develope
On Mon, Nov 16, 2009 at 7:26 PM, Dave MacLachlan wrote:
> Here's the explanation:
>
> http://gcc.gnu.org/ml/gcc/2001-07/msg01120.html
>
> Officially the standard says:
>
> If a source file that is not empty does not end in a new-line character, or
> ends in a new-line character immediately precede
On Mon, Nov 16, 2009 at 7:22 PM, Peter Kasting wrote:
> Does this warning help anyone, anywhere, for any reason?
.h files that are missing newlines cause nasty and confusing
errors on some platforms, IIRC.
--
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change
Does this warning help anyone, anywhere, for any reason? It's on explicitly
for the Mac and implicitly for Linux, and when you combine it with Warn As
Error and Visual Studio not auto-adding a trailing newline, it means my
patches frequently trivially fail to compile on the trybots. Easy fix, but
Dominic, you should turn /WX off globally in src/build/common.gypi.
That would simplify the patch.
I guess the incremental link failure is due to the exe size on a 32
bit OS, I'll mark it as a large binary so you can remove that step
too.
M-A
On Mon, Nov 16, 2009 at 8:58 PM, Bradley Nelson wrot
That's good to hear!
I see you are mainly just turning off warnings as errors in a few spots.
Is this something that we can either gate in the build based on some flag,
or are the warnings something that we could fix properly in the source? I'd
love to peel off more steps from the process.
-BradN
Hey Brad!
I just wanted to let you know that this is working great for me on
VC++ 2008 Express Edition. Thanks a lot!
I have updated my page to reflect your change. I also added a patch
that modifies some GYP files in such a way that you won’t have to
manually “play” with the project settings in
Layout Tests Task Force syncup 11/16/2009
- Number of failing tests: 635
- dashboard: http://chromiumlttf.appspot.com/
- bunch of rebaseline fixes coming up
- last week was not as productive because mstone 4.0 bugs were being
worked on
- we can see that new failures accu
On Mon, Nov 16, 2009 at 4:05 PM, Steven Knight wrote:
> Let me know if you notice any problems or have any suggestions for making
> this more useful.
I've noticed it's basically impossible to load this page over a
moderately fast internet connection because of the quantity of data
displayed.
I se
On Mon, Nov 16, 2009 at 4:05 PM, Steven Knight wrote:
> Let me know if you notice any problems or have any suggestions for making
> this more useful.
>
My lone suggestion is that "page-load-time" isn't accurate for all rows --
for example, the SunSpider row is measuring a benchmark number. It w
The current perf dashboard is getting long and unwieldy. I've put up a new
page which packs the same thumbnail graphs into a matrix:
http://build.chromium.org/buildbot/perf/dashboard/perf.html
Rows are the various perf tests we run, columns are the different build
slaves. It compresses the grap
You're off by a digit -- read only data is 2mb.
On Mon, Nov 16, 2009 at 3:27 PM, Eric Seidel wrote:
> Yay data! Thank you Evan.
>
> If I'm reading your email correctly, your script can only account for
> 3MB (7.5%) of our binary. :( 26.5MB (67%) is unknown to your script
> and 20MB of what nm
Yay data! Thank you Evan.
If I'm reading your email correctly, your script can only account for
3MB (7.5%) of our binary. :( 26.5MB (67%) is unknown to your script
and 20MB of what nm does see is labeled "read only data". Of the 3MB
nm does understand, 700K (1.7% of the total final binary) is
*UI Jank Task Force Status Updates*
The UI Jank Task Force is out to fix UI Jank and slowness in the browser. A
list of open Jank bugs is here:
http://code.google.com/p/chromium/issues/list?q=label:Jank (feel free to
take one!)
*Updates*
Chase
- Added tab switch paint histogram.
- Found
If gcl is misbehaving at home, please run "gclient" to update your
depot_tools; it was broken this morning.
M-A
--
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
src/build/gyp_chromium should add src/tools/gyp/pylib to your python
sys.path
>> sys.path.append(os.path.join(chrome_src, 'tools', 'gyp', 'pylib'))
Could you check if you have gyp files on your drive (should be under
"C:\chromiumtrunk\src\tools\gyp")?
Maybe previous "gclient sync" failed somehow a
On Mon, Nov 16, 2009 at 11:14 AM, OuterLimits wrote:
> I've been using this forever but I had to rebuild windows from scratch
> a few days ago and had to download everything again but now chromium
> updater 'fails to initialize'
>
> This is what I've been using below.. Is there another way to se
Thanks for the reply.
As suggested by Xiyuan, I unset my Python enviroment vars and it
worked! The gclient now is using its own Python version inside c:
\depot_tools.
I still don't know how to build the browser since I can't find the
file chrome\chrome.sln as specified in “Build Instructions
(Windo
Try unset your PYTHONPATH env var and run gclient again.
On Sun, Nov 15, 2009 at 8:23 PM, Eduardo Maggio wrote:
> Well, I'm not sure if it's the right place to post that, but anyway...
> In order to get the source sync and build the last version of chrome
> (OS: Windows XP), I tried to follow th
I've been using this forever but I had to rebuild windows from scratch
a few days ago and had to download everything again but now chromium
updater 'fails to initialize'
This is what I've been using below.. Is there another way to set up
nightly downloads? Thanks
http://forums.tlokzz.com/images/
Hi,
General overview of the WebKit covering following components would be very
helpful.
1. Loading phase (FrameLoader + DocumentLoader + MainResource Loader).
2. Parsing phase (HTML, WML, SVG etc).
3. Rendering phase (Layout, Painting).
4. Java script module.
For a beginner (like me), high level
Since we no longer have the cc list on Area-Extensions, I've relented
and added the Feature-Extensions label to all our existing bugs.
Please update your bookmarks and try to remember to use
Feature-Extensions now, not Area-Extensions.
- a
--
Chromium Developers mailing list: chromium-dev@google
On Mon, Nov 16, 2009 at 12:33 AM, Evan Martin wrote:
> My Release Linux build stripped is 39.5mb. (The size bots show ~44mb,
> which I think is a Chrome vs Chromium thing. It is curious how the
> Windows binary is nearly half the size of the Linux or Mac one.)
>...
> And like I had guessed, SVG
I don't know where you put your depot_tools but I'd try to delete
depot_tools\python.bat and try again.
It seems like downloading the python zip failed.
M-A
On Sun, Nov 15, 2009 at 11:23 PM, Eduardo Maggio wrote:
> Well, I'm not sure if it's the right place to post that, but anyway...
> In orde
I spent some quality time with nm. With it I can take a release
binary (so all the inlining and optimizations like dead code removal
have been done) and display symbol sizes as well as which file they're
from.
My Release Linux build stripped is 39.5mb. (The size bots show ~44mb,
which I think is
27 matches
Mail list logo
