Re: [chromium-dev] seeking c++ expertise for a tiny tricky bit of code

2010-01-13 Thread Craig Schlenter
On Wed, Jan 13, 2010 at 7:42 PM, Evan Martin e...@chromium.org wrote: [snip] With that in mind I think we should explicitly use -fno-strict-aliasing until someone is willing to take the time to run buildbots, track down regressions, etc. for the other configuration. I have a patch to do this

Re: [chromium-dev] seeking c++ expertise for a tiny tricky bit of code

2010-01-13 Thread Craig Schlenter
On Wed, Jan 13, 2010 at 8:34 PM, Antoine Labour pi...@google.com wrote: On Wed, Jan 13, 2010 at 10:06 AM, Stephen White senorbla...@chromium.org wrote: On Wed, Jan 13, 2010 at 12:19 PM, Dan Kegel d...@kegel.com wrote: On Wed, Jan 13, 2010 at 9:12 AM, Stephen White senorbla...@chromium.org

Re: [chromium-dev] seeking c++ expertise for a tiny tricky bit of code

2010-01-13 Thread Craig Schlenter
On Wed, Jan 13, 2010 at 9:28 PM, Peter Kasting pkast...@google.com wrote: On Wed, Jan 13, 2010 at 11:22 AM, Craig Schlenter craig.schlen...@chromium.org wrote: Other than the immediate gain of hiding crbug.com/28749, Which you have a patch (actually two, but one with r+) for, right? True. I

Re: [chromium-dev] seeking c++ expertise for a tiny tricky bit of code

2010-01-12 Thread Craig Schlenter
On Wed, Jan 13, 2010 at 8:07 AM, Antoine Labour pi...@google.com wrote: On Tue, Jan 12, 2010 at 10:15 AM, Craig Schlenter craig.schlen...@chromium.org wrote: On Tue, Jan 12, 2010 at 7:13 PM, Evan Martin e...@chromium.org wrote: In this bug  http://code.google.com/p/chromium/issues/detail

[chromium-dev] Re: buildbot failure in Chromium on Webkit (dbg)(1), revision 35699

2010-01-07 Thread Craig Schlenter
Random hang unrelated to my change AFAICS ... looks like it's going green on the next build. --Craig On Thu, Jan 7, 2010 at 12:55 PM, build...@chromium.org wrote: http://build.chromium.org/buildbot/waterfall/ Automatically closing tree for test_shell_tests on Webkit (dbg)(1)

Re: [chromium-dev] make all doesn't work.

2009-12-03 Thread Craig Schlenter
I think you don't need to specify a target to build everything i.e. just type make and it should work. --Craig On Fri, Dec 4, 2009 at 7:44 AM, James Su su...@chromium.org wrote: Hi,   I just switched to use make to build chromium linux, but I found that make all didn't work at all. It only

Re: [chromium-dev] make all doesn't work.

2009-12-03 Thread Craig Schlenter
all doesn't? - that might give us some clues as to what is wrong. --Craig On Fri, Dec 4, 2009 at 7:53 AM, James Su su...@chromium.org wrote: Unfortunately, it doesn't work. Actually, make == make all. - James Su 2009/12/4 Craig Schlenter craig.schlen...@gmail.com I think you don't need

Re: [chromium-dev] Symbolized backtrace on Linux chromium?

2009-11-30 Thread Craig Schlenter
The bug that is triggering here might be 28526 btw. ... ukai has a patch in review for that. --Craig On Mon, Nov 30, 2009 at 7:37 PM, Chris Bentzel cbent...@google.com wrote: When DCHECK's trigger on my debug chromium build, I get an unsymbolized stacktrace like

Re: [chromium-dev] Warning message when running chrome in gdb

2009-11-29 Thread Craig Schlenter
using the gold linker on ubuntu 9.10. I wonder if that causes the problem. On Sat, Nov 28, 2009 at 1:33 PM, Dan Kegel d...@kegel.com wrote: Might not hurt to build from the latest sources and make sure they haven't fixed it already, too. On Sat, Nov 28, 2009 at 5:57 AM, Craig Schlenter

Re: [chromium-dev] Warning message when running chrome in gdb

2009-11-27 Thread Craig Schlenter
I have a vague recollection of having seen this before ... upgrading gdb may help. http://sourceware.org/ml/gdb-patches/2003-01/msg00074.html --Craig On Sat, Nov 28, 2009 at 8:06 AM, Evan Martin e...@chromium.org wrote: I have never encountered this.  Have you tried searching for the error

[chromium-dev] Re: Compiler warning with Arch Linux and make

2009-11-02 Thread Craig Schlenter
As Evan notes, things move quickly :) What made the difference here is that Joel fixed that error and you must have updated your tree. --Craig On Sun, Nov 1, 2009 at 5:01 PM, Alexander Teinum atei...@gmail.com wrote: Success. Adding 'remove_webcore_debug_symbols' to include.gypi probably

[chromium-dev] Re: Scalability

2009-10-13 Thread Craig Schlenter
Hi The patch below should fix it (there are arguably other perhaps better ways to tackle the debugger dependency etc.). With that patch, the linux shared make build compiles and links all targets for me. --Craig diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp index 3fa1905..c0caeb6 100755

[chromium-dev] Re: Scalability

2009-10-07 Thread Craig Schlenter
On Wed, Oct 7, 2009 at 10:00 AM, Craig Schlenter craig.schlen...@gmail.com wrote: On Tue, Oct 6, 2009 at 11:09 PM, Jacob Mandelson ja...@mandelson.org wrote: On Tue, Oct 06, 2009 at 09:19:49PM +0200, Craig Schlenter wrote: On Tue, Oct 6, 2009 at 8:14 PM, Craig Schlenter craig.schlen

[chromium-dev] Re: Scalability

2009-10-06 Thread Craig Schlenter
On Tue, Oct 6, 2009 at 8:14 PM, Craig Schlenter craig.schlen...@gmail.com wrote: On Tue, Oct 6, 2009 at 7:51 PM, Jacob Mandelson ja...@mandelson.org wrote: On Tue, Oct 06, 2009 at 07:39:14PM +0200, Craig Schlenter wrote: On Tue, Oct 6, 2009 at 6:58 PM, Evan Martin e...@chromium.org wrote

[chromium-dev] Re: Compile base_unittests fails

2009-07-13 Thread Craig Schlenter
Hi I thought none of the hex stuff was supposed be compiled. Line 183 does #define NO_HEX_FP but there is some interesting interaction between INFNAN_CHECK, No_Hex_NaN and Need_Hexdig which might result in it compiling for you. Hmmm Try adding #define No_Hex_Nan after #define NO_HEX_FP

[chromium-dev] Re: Compile base_unittests fails

2009-07-13 Thread Craig Schlenter
On Mon, Jul 13, 2009 at 8:34 AM, Craig Schlentercraig.schlen...@gmail.com wrote: Hi I thought none of the hex stuff was supposed be compiled. Line 183 does #define NO_HEX_FP but there is some interesting interaction between INFNAN_CHECK, No_Hex_NaN and Need_Hexdig which might result in it

[chromium-dev] Re: Compile base_unittests fails

2009-07-13 Thread Craig Schlenter
Hi If your compiler is that old btw, then it may help to poke at the list below and see what else you need to update: http://code.google.com/p/chromium/wiki/LinuxBuildInstructionsPrerequisites Hopefully all those warnings will go away with something a bit more modern ... --Craig On Mon, Jul

[chromium-dev] Re: Improving power usage

2009-07-13 Thread Craig Schlenter
On Mon, Jul 13, 2009 at 6:22 PM, Evan Martine...@chromium.org wrote: [snip] One piece to look at is the code that calls SetProcessBackgrounded(), which on Windows marks the process as one that can be paged out but on Linux is not implemented.  I don't know how it decides it's ok to do that,

[chromium-dev] Re: Cannot use gcl change, svn fails. Any help is appreciated ...

2009-05-27 Thread Craig Schlenter
Hi Are you using vaguely equivalent versions of svn btw. between windows and linux? Sharing a working copy is always bad news for svn and I suspect horrid issues between different versions of svn on windows and linux or perhaps even cr/lf issues contributed to this problem :( Given that you

Fwd: [chromium-dev] Re: cryptoht.h not found

2009-05-16 Thread Craig Schlenter
+chromium-dev --Craig -- Forwarded message -- From: Craig Schlenter craig.schlen...@gmail.com Date: Sat, May 16, 2009 at 3:39 PM Subject: Re: [chromium-dev] Re: cryptoht.h not found To: Mohamed Mansour m0.interact...@gmail.com Hi Mohamed The instructions at http

[chromium-dev] Re: gyp shared library builds on Linux

2009-04-24 Thread Craig Schlenter
Hi At some point I had used -ldl in the xml gyp file but then I dropped that when I purely targeted chrome and not any of the other targets ... in fact I haven't even tried building the other targets for a while so it's quite possible that they won't build as shared targets. Try hammer app and

[chromium-dev] Re: gyp shared library builds on Linux

2009-04-24 Thread Craig Schlenter
On Fri, Apr 24, 2009 at 3:05 PM, Craig Schlenter craig.schlen...@gmail.com wrote: Hi At some point I had used -ldl in the xml gyp file but then I dropped that when I purely targeted chrome and not any of the other targets ... in fact I haven't even tried building the other targets for a while

[chromium-dev] Re: gyp shared library builds on Linux

2009-04-24 Thread Craig Schlenter
it there but then I was not sure if it needs another condition block for shared_library but before asking you again I wanted to try to build chrome (hammer app) and see if that works as you suggested. Thanks! Nidhi On Apr 24, 9:16 am, Craig Schlenter craig.schlen...@gmail.com wrote: Hmmm ... actually

[chromium-dev] Re: cryptoht.h not found

2009-04-20 Thread Craig Schlenter
On Mon, Apr 20, 2009 at 4:55 PM, Evan Martin e...@chromium.org wrote: [snip] Maybe now that gyp is settled and most of temporary_link_stubs is gone we could reinvestigate dynamic linking... It's working for me: http://codereview.chromium.org/67207 (changes to gyp itself, not really right)

[chromium-dev] Re: gyp build on Linux

2009-04-02 Thread Craig Schlenter
Just a wild guess but I think it's missing the circular linker magic start/end stuff when compiling the plugin. Will try to confirm when I'm near a pc again ... --Craig On 02 Apr 2009, at 15:48, Dean McNamee de...@chromium.org wrote: I confirmed the debug build line has no -g. Also,

[chromium-dev] Re: gyp build on Linux

2009-04-02 Thread Craig Schlenter
On Thu, Apr 2, 2009 at 4:47 PM, Craig Schlenter craig.schlen...@gmail.com wrote: Just a wild guess but I think it's missing the circular linker magic start/end stuff when compiling the plugin. Will try to confirm when I'm near a pc again ... Confirmed. Here's the line it's using to generate

[chromium-dev] Re: ResourceMessageFilter::OnGet(Root)WindowRect and NULL windows

2009-03-23 Thread Craig Schlenter
On Mon, Mar 23, 2009 at 6:45 PM, Darin Fisher da...@chromium.org wrote: Thanks for the info!  Could you dump this into a bug report? Added to http://crbug.com/9060 ... --Craig --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com

[chromium-dev] Re: ResourceMessageFilter::OnGet(Root)WindowRect and NULL windows

2009-03-19 Thread Craig Schlenter
, 2009 at 1:46 PM, Craig Schlenter craig.schlen...@gmail.com wrote: Hi Avi When I did the original change, that function wasn't being called with a null window. Clicking on a link in gmail opened the link in a new window as I recall. At some later point that changed possibly when some

[chromium-dev] Re: linux async IO

2009-02-25 Thread Craig Schlenter
On Wed, Feb 25, 2009 at 11:21 PM, Adam Langley a...@chromium.org wrote: On Wed, Feb 25, 2009 at 1:13 PM, William Chan (陈智昌) willc...@chromium.org wrote: I talked to Darin and he told me that this needs work since it's impacting the page cycler times, so I figured I'd pick it up. You have a