Re: [chromium-dev] Ajax maximum response size

2010-01-15 Thread James Robinson
structure issues. You should not be doing this anyway - it's really bad for the users to have the page locked up while a 100MB download occurs. - James These sound like known issues with XMLHTTPRequest and tcmalloc that were fixed a few months ago by James Robinson. What version of Chrome

Re: [chromium-dev] Process Model Extension API Proposal

2010-01-12 Thread James Robinson
Getting this information in a cross-platform way is a huge pain (do we even do it properly for mac yet?), so it seems like a decent idea to let extensions reuse the work done rather than reimplementing everything. I'd suggest having the browser fire some sort of update event to the extension

Re: [chromium-dev] Interesting performance characteristics of http://a.qoid.us/google.html

2010-01-11 Thread James Robinson
Chromium is spending nearly all of its time inside Skia, so it's likely Skia vs CG differences: Welcome to pprof! For help, type 'help'. (pprof) top Total: 1590 samples 592 37.2% 37.2% 592 37.2% SkRegion::Spanerator::Spanerator 89 5.6% 42.8% 89 5.6% sk_memset32_SSE2

Re: [chromium-dev] Red Tree 2010/1/6

2010-01-07 Thread James Robinson
Thanks a lot, Chase. When will it become feasible to run the perf tests as part of the WebKit canary process? We seem to have all the code necessary to catch these regressions at the exact WebKit revision that causes them. - James On Thu, Jan 7, 2010 at 11:13 AM, Chase Phillips

Re: [chromium-dev] Replicated State among tabs in Chromium

2010-01-07 Thread James Robinson
On Thu, Jan 7, 2010 at 12:43 PM, Fady Samuel fadysam...@gmail.com wrote: Charles, I've read your paper and ultimately I think my goal may be somewhere along the lines of making the DOM tree thread-safe by applying my research in iterators and lock-free data structures. A tricky question:

Re: [chromium-dev] Replicated State among tabs in Chromium

2010-01-07 Thread James Robinson
There's a group at UC Berkeley that was (is?) working on a similar idea, you can read about it here: http://www.eecs.berkeley.edu/~lmeyerov/projects/pbrowser/ http://www.eecs.berkeley.edu/~lmeyerov/projects/pbrowser/With a discussion that happened a few months back here:

[chromium-dev] linux_view trybot seems unable to accept any patch

2009-12-15 Thread James Robinson
Every patch sent to the linux_view trybot lately dies with this error in the 'gclient' step: Exception: /b/slave/linux_view/build/src/third_party/chromeos_login_manager/chromeos_login_manager/chromeos_login_manager.gyp not found (cwd: /b/slave/linux_view/build) while loading dependencies of

Re: [chromium-dev] Extensions and the Mac

2009-12-10 Thread James Robinson
On Thu, Dec 10, 2009 at 4:03 PM, Avi Drissman a...@chromium.org wrote: Andy sent me a CL for review about an extension crashing ( http://crbug.com/29584). Turns out the cause was a failure to load a Windows .dll on the Mac. Huh? Then I went to look at the docs (

Re: [chromium-dev] Extensions and the Mac

2009-12-10 Thread James Robinson
On Thu, Dec 10, 2009 at 5:05 PM, Avi Drissman a...@google.com wrote: On Thu, Dec 10, 2009 at 8:00 PM, Ojan Vafai o...@chromium.org wrote: I think we can wait to see what percentage of extensions actually include binaries before devoting too much time to this. Our expectation is that this

Re: [chromium-dev] class has virtual method but non-virtual destructor

2009-11-20 Thread James Robinson
On Fri, Nov 20, 2009 at 12:59 PM, Peter Kasting pkast...@google.com wrote: On Fri, Nov 20, 2009 at 12:42 PM, Mark Mentovai m...@chromium.org wrote: As Evan points out, there are some cases when it's not absolutely necessary to have a base or interface class declare a virtual destructor.

Re: [chromium-dev] class has virtual method but non-virtual destructor

2009-11-20 Thread James Robinson
On Fri, Nov 20, 2009 at 3:01 PM, Jacob Mandelson ja...@mandelson.orgwrote: On Fri, Nov 20, 2009 at 02:55:17PM -0800, Peter Kasting wrote: On Fri, Nov 20, 2009 at 2:53 PM, Jacob Mandelson ja...@mandelson.org wrote: http://codereview.chromium.org/201100/show Yes, that caused a large

[chromium-dev] Re: revert now, ask questions later? WAS: Reverting a change, the fast way

2009-11-04 Thread James Robinson
On Wed, Nov 4, 2009 at 12:02 PM, Peter Kasting pkast...@google.com wrote: On Wed, Nov 4, 2009 at 11:56 AM, Nicolas Sylvain nsylv...@chromium.orgwrote: I don't think anyone suggested immediate auto revert. Ben Goodger: I am supportive of auto-revert as long as we apply it universally

[chromium-dev] Fun with timers! A horror story

2009-10-27 Thread James Robinson
Some folks have been reporting Chromium using 100% CPU on relatively innocuous websites lately. Once we had a reduction and a theory about what was happening Mike Belshe figured out what the actual problem was pretty quickly. I wanted to record exactly what was happening for posterity - feel

[chromium-dev] Re: [Memory] Observations on memory usage in flickr

2009-10-15 Thread James Robinson
On Thu, Oct 15, 2009 at 11:11 AM, Jens Alfke s...@google.com wrote: I spent some time this morning looking at Chrome's memory usage (on OS X 10.5.8) while viewing flickr.com. First I simply started at my photo- stream page and hit Reload over and over. Next I tried going through all of my

[chromium-dev] Re: Learning Webkit: High Level Webkit overview?

2009-10-06 Thread James Robinson
On Sun, Oct 4, 2009 at 8:19 AM, Buakaw San buakaw@gmail.com wrote: There is a document called How Chromium Displays Web Pages (http:// dev.chromium.org/developers/design-documents/displaying-a-web-page-in- chrome), however I haven't found an equivalent page for Webkit. E.g. How Webkit

[chromium-dev] Re: [Memory] in TCMalloc, more careful handling of VirtualAlloc commit via SystemAlloc

2009-10-01 Thread James Robinson
at 8:42 AM, Erik Kay erik...@chromium.org wrote: On Wed, Sep 30, 2009 at 11:22 AM, James Robinson jam...@google.com wrote: I agree completely that this seems to be an issue Here's what about:tcmalloc says about my browser process right now (which is at around 267MB according

[chromium-dev] Re: [Memory] in TCMalloc, more careful handling of VirtualAlloc commit via SystemAlloc

2009-09-30 Thread James Robinson
On Wed, Sep 30, 2009 at 11:17 AM, Mike Belshe mbel...@google.com wrote: On Wed, Sep 30, 2009 at 11:05 AM, Anton Muhin ant...@chromium.org wrote: On Wed, Sep 30, 2009 at 9:58 PM, Mike Belshe mbel...@google.com wrote: On Wed, Sep 30, 2009 at 10:48 AM, Anton Muhin ant...@google.com wrote:

[chromium-dev] Re: [Memory] in TCMalloc, more careful handling of VirtualAlloc commit via SystemAlloc

2009-09-30 Thread James Robinson
On Wed, Sep 30, 2009 at 11:29 AM, Anton Muhin ant...@chromium.org wrote: On Wed, Sep 30, 2009 at 10:27 PM, Mike Belshe mbel...@google.com wrote: On Wed, Sep 30, 2009 at 11:24 AM, Anton Muhin ant...@chromium.org wrote: On Wed, Sep 30, 2009 at 10:17 PM, Mike Belshe mbel...@google.com

[chromium-dev] Re: [Memory] in TCMalloc, more careful handling of VirtualAlloc commit via SystemAlloc

2009-09-30 Thread James Robinson
On Wed, Sep 30, 2009 at 2:28 PM, James Robinson jam...@google.com wrote: On Wed, Sep 30, 2009 at 11:29 AM, Anton Muhin ant...@chromium.org wrote: On Wed, Sep 30, 2009 at 10:27 PM, Mike Belshe mbel...@google.com wrote: On Wed, Sep 30, 2009 at 11:24 AM, Anton Muhin ant...@chromium.org

[chromium-dev] Re: [chromium-extensions] Inter-extension communication API proposal

2009-07-30 Thread James Robinson
On Tue, Jul 28, 2009 at 6:02 PM, Matt Perry mpcompl...@chromium.org wrote: Two suggestions (one I accidentally sent only to James): chrome.extension.Port: // ID of the extension at the other side of this port. String senderID; Port currently has a 'tab' property if the sender was a tab.

[chromium-dev] Re: [chromium-extensions] Inter-extension communication API proposal

2009-07-30 Thread James Robinson
[bcc chromium-dev] On Thu, Jul 30, 2009 at 2:01 PM, Matt Perry mpcompl...@chromium.org wrote: On Thu, Jul 30, 2009 at 10:44 AM, James Robinson jam...@google.comwrote: On Tue, Jul 28, 2009 at 6:02 PM, Matt Perry mpcompl...@chromium.orgwrote: Two suggestions (one I accidentally sent only

[chromium-dev] Re: [chromium-extensions] Inter-extension communication API proposal

2009-07-28 Thread James Robinson
Thanks for the feedback. I've created http://code.google.com/p/chromium/wiki/InterExtensionCommunication with the proposal and would appreciate if someone with an @chromium account could link to it from http://dev.chromium.org/developers/design-documents/extensions. I copied the proposal pretty

[chromium-dev] Re: Major refactorings since 21122?

2009-07-24 Thread James Robinson
IPC infrastructure was pulled from the chrome/common project into a separate folder at 21342 along with a few follow-up patches to fix up the build: http://src.chromium.org/viewvc/chrome?view=revrevision=21342 http://src.chromium.org/viewvc/chrome?view=revrevision=21342This involved a decent

[chromium-dev] Re: The meaning of + ? ! / characters in gyp

2009-06-16 Thread James Robinson
Yes, they are to set the merge policy. Extensive documentation is here: http://code.google.com/p/gyp/wiki/InputFormatReference http://code.google.com/p/gyp/wiki/InputFormatReference- James On Tue, Jun 16, 2009 at 11:51 PM, KwangYul Seo kwangyul@gmail.comwrote: Hi, The

[chromium-dev] Re: mismatched new/delete[] in webkit?

2009-01-27 Thread James Robinson
The last one looks similar to https://bugs.webkit.org/show_bug.cgi?id=23473 or https://bugs.webkit.org/show_bug.cgi?id=22834, which Brett Wilson and Dean McNamee appear to be working on. - James On Tue, Jan 27, 2009 at 11:45 AM, Dan Kegel daniel.r.ke...@gmail.comwrote: Noticed in passing