Re: [chromium-dev] Linux sandbox configuration

2010-01-11 Thread Lei Zhang
Can you elaborate on what you mean by configure the sandbox? On Fri, Jan 8, 2010 at 11:36 PM, n179911 n179...@gmail.com wrote: Hi, Can you please tell me if/where is the file to configure chromium's renderer sandbox? Thank you. -- Chromium Developers mailing list:

Re: [chromium-dev] Build issue GL/glu.h

2010-01-07 Thread Lei Zhang
See the email from 3 days ago titled PSA: new dev packages needed on linux On Thu, Jan 7, 2010 at 8:14 AM, Aaron donnythebow...@gmail.com wrote: Any idea what could be causing this thing?  It's been going on for some time now.  All of my research turns up nothing. CXX(target)

Re: [chromium-dev] about issue #31155 : style properties returning localized string ofr numeric values

2010-01-06 Thread Lei Zhang
The bug tracker is a bit backlogged because many people went on vacation the last few weeks. There's no need to email chromium-dev about it. If everyone did that then chromium-dev would just be chromium-bugs. On Wed, Jan 6, 2010 at 2:20 AM, kapouer holi...@gmail.com wrote: Hi, could someone

Re: [chromium-dev] linux_view trybot seems unable to accept any patch

2009-12-15 Thread Lei Zhang
It has a custom .gclient entry for chrome-deps, should that be cros_deps? On Tue, Dec 15, 2009 at 3:24 PM, James Robinson jam...@chromium.org wrote: Every patch sent to the linux_view trybot lately dies with this error in the 'gclient' step: Exception:

Re: [chromium-dev] linux_view trybot seems unable to accept any patch

2009-12-15 Thread Lei Zhang
.  -Scott On Tue, Dec 15, 2009 at 3:37 PM, Lei Zhang thes...@chromium.org wrote: It has a custom .gclient entry for chrome-deps, should that be cros_deps? On Tue, Dec 15, 2009 at 3:24 PM, James Robinson jam...@chromium.org wrote: Every patch sent to the linux_view trybot lately dies

Re: [chromium-dev] linux_view trybot seems unable to accept any patch

2009-12-15 Thread Lei Zhang
/cros_deps,  }, in .gclient, but there may be syncing problems unless you have git 1.6.1 . cros deps is the new way dependency are managed between the two projects.  -Scott On Tue, Dec 15, 2009 at 4:26 PM, Lei Zhang thes...@chromium.org wrote: The 3 linux_views bots currently have Git 1.5

Re: [chromium-dev] linux_view trybot seems unable to accept any patch

2009-12-15 Thread Lei Zhang
Hmm, is the try server master overdue for a reload/restart? The master.cfg is right, but it's still checking out chrome-deps. On Tue, Dec 15, 2009 at 4:40 PM, Lei Zhang thes...@chromium.org wrote: Ok, I think I fixed it. Running a test job right now. *fingers crossed* http://build.chromium.org

Re: [chromium-dev] linux_view trybot seems unable to accept any patch

2009-12-15 Thread Lei Zhang
Unless I hear otherwise, I'll restart the try server master tonight at 9 PM PST, and apologize to the people whose try jobs failed as a result. On Tue, Dec 15, 2009 at 4:48 PM, Lei Zhang thes...@chromium.org wrote: Hmm, is the try server master overdue for a reload/restart? The master.cfg

Re: [chromium-dev] linux_view trybot seems unable to accept any patch

2009-12-15 Thread Lei Zhang
? Also, djmm@ is working on getting install_build_deps.sh to install an appropriate version of git...we should still get that done, right? On Tue, Dec 15, 2009 at 6:13 PM, Lei Zhang thes...@chromium.org wrote: Unless I hear otherwise, I'll restart the try server master tonight at 9 PM PST

Re: [chromium-dev] linux_view trybot seems unable to accept any patch

2009-12-15 Thread Lei Zhang
I also needed to install libpam0g-dev. Linux_view try bots should be happy now. On Tue, Dec 15, 2009 at 7:03 PM, Lei Zhang thes...@chromium.org wrote: It'll reload the try server configuration so try jobs will pull the right deps. I already installed git 1.6 on the linux_view

Re: [chromium-dev] Best Practices when disabling tests?

2009-12-14 Thread Lei Zhang
On Mon, Dec 14, 2009 at 8:54 AM, Drew Wilson atwil...@chromium.org wrote: Anyhow, what's our best practices for disabling tests? I think ideally we'd always log a tracking bug and add a comment, akin to what we do in the test_expectations file for layout tests. Another point to keep in mind -

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Lei Zhang
On Tue, Dec 8, 2009 at 4:11 PM, Evan Stade est...@chromium.org wrote: proposals on which of these options (again, see original attachment) to rip out are welcome and within the scope of this thread. The vbox? holding the bookmark sync status boxes is too narrow. If it used all the horizontal

Re: [chromium-dev] I use Chrome 4 in Ubuntu 9.10, I found the Chinese font text is too vague

2009-12-06 Thread Lei Zhang
File a bug at http://new.crbug.com/, provide screenshots. This mailing list is not the appropriate place to report bugs. On Sat, Dec 5, 2009 at 7:57 PM, Blade im.blade.f...@gmail.com wrote: Especially the text on buttons, Chinese characters, are very vague. How can I solve this problem? --

Re: [chromium-dev] make all doesn't work.

2009-12-04 Thread Lei Zhang
Works for me. Do you have an all target in your Makefile? Can you see what $all_targets is set to? On Thu, Dec 3, 2009 at 10:29 PM, James Su su...@chromium.org wrote: make chrome works as expected, it builds out the chrome binary. But make or make all doesn't work at all. - James Su

Re: [chromium-dev] Need a linux-views build buddy.

2009-12-03 Thread Lei Zhang
I filed http://crbug.com/29364 On Thu, Dec 3, 2009 at 2:45 PM, Mike Pinkerton pinker...@chromium.org wrote: Yes, except it's down and hasn't worked in days. On Thu, Dec 3, 2009 at 5:44 PM, Jeremy Orlow jor...@chromium.org wrote: Isn't gcl try cl -b linux_view what you want? On Thu, Dec 3,

Re: [chromium-dev] webcore_bindings target builds slowly

2009-12-01 Thread Lei Zhang
DerivedSourcesAllInOne.cpp is the biggest bottleneck on Linux too. Even when running make with a high -j value, one would end up in the situation where one core is pegged for more than a minutes while all the others sit idle. On Tue, Dec 1, 2009 at 10:57 AM, Lei Zhang thes...@google.com wrote

Re: [chromium-dev] TestShell target

2009-11-25 Thread Lei Zhang
(from the right address this time) make test_shell ? On Wed, Nov 25, 2009 at 5:21 PM, n179911 n179...@gmail.com wrote: Hi, Is there a way to build a TestShell target for chromium on linux? On MacOS, there is a TestShell project, I wonder if there is a TestShell target for building it on

Re: [chromium-dev] Linux: gold linker users should upgrade to 2.20 soon.

2009-11-23 Thread Lei Zhang
reason. Antoine On Wed, Nov 18, 2009 at 2:47 AM, Lei Zhang thes...@chromium.org wrote: Hi folks, We'll soon be relanding a patch that pass --gc-sections to the linker on Linux. For this to work, you need either GNU ld or a recent version of GNU gold. You can test and see if your copy of gold

[chromium-dev] Re: Linux: gold linker users should upgrade to 2.20 soon.

2009-11-18 Thread Lei Zhang
On Wed, Nov 18, 2009 at 2:47 AM, Lei Zhang thes...@chromium.org wrote: If you installed gold through [1], please run it again. I've updated the script at r32315 to install gold 2.20. I've also updated all the Linux build / try bots to gold 2.20. [1] http://src.chromium.org/svn/trunk/src/build

[chromium-dev] Re: Linux: gold linker users should upgrade to 2.20 soon.

2009-11-18 Thread Lei Zhang
On Wed, Nov 18, 2009 at 3:00 AM, Lei Zhang thes...@chromium.org wrote: On Wed, Nov 18, 2009 at 2:47 AM, Lei Zhang thes...@chromium.org wrote: If you installed gold through [1], please run it again. I've updated the script at r32315 to install gold 2.20. I've also updated all the Linux build

Re: [chromium-dev] Problem during compilation about gen_x86_insn.py

2009-11-13 Thread Lei Zhang
Do you have src/third_party/yasm/source/patched-yasm/modules/arch//x86/gen_x86_insn.py checked out? On Fri, Nov 13, 2009 at 1:43 AM, sahid sahid.ferdja...@gmail.com wrote: Hello, sa...@sahid-work:~/Documents/chromium/src$ cat /etc/debian_version squeeze/sid

Re: [chromium-dev] More sheriffs?

2009-11-13 Thread Lei Zhang
Big +1 for at least a third sheriff. With two sheriffs, if one is not in PST, then really we only have one sheriff. If that sheriff happens to be new, then we have 0 = num_sheriffs = 1. On Fri, Nov 13, 2009 at 12:31 PM, Peter Kasting pkast...@google.com wrote: At lunch today, a few of us

[chromium-dev] Re: Large commit - update your .gclient files to avoid

2009-11-05 Thread Lei Zhang
And have the tarball generated from this lean configuration. On Thu, Nov 5, 2009 at 11:44 AM, Ben Goodger (Google) b...@chromium.org wrote: it'd be nice to have a gclient config lean or something like that. -Ben On Thu, Nov 5, 2009 at 11:42 AM, Jeremy Orlow jor...@google.com wrote: In

[chromium-dev] [Linux] New chrome_sandbox needed at ToT if sandoxing is enabled.

2009-11-04 Thread Lei Zhang
Hi Folks, In r30948, I fixed several bugs related to the Linux suid sandbox. If you're running ToT with sandboxing turned on, you will need to rebuild chrome_sandbox. Without the new version of sandbox, Chromium will hang on start up. - Lei --~--~-~--~~~---~--~~

[chromium-dev] Re: How can we kill scons?

2009-10-28 Thread Lei Zhang
mmoss has been working on the make gyp generator, maybe he has a better feel for what's keeping us from switching. On Wed, Oct 28, 2009 at 12:35 PM, Albert J. Wong (王重傑) ajw...@chromium.org wrote: On Wed, Oct 28, 2009 at 12:34 PM, Marc-Antoine Ruel mar...@chromium.org wrote: Not that it is

[chromium-dev] Linux/Stability - Remember to check the return value from GTK functions.

2009-10-21 Thread Lei Zhang
Hi Linux folks, This is a kind reminder to check the return values from GTK functions. Every time you put the unchecked result from, say, gtk_file_chooser_get_filename() into a FilePath or std::string, you risk a browser process crash if the result is NULL. I just triaged several crashes of

[chromium-dev] Re: Change to default build architecture

2009-10-16 Thread Lei Zhang
On Thu, Oct 15, 2009 at 5:28 PM, Michael Moss mm...@chromium.org wrote: If you want to continue building 32-bit on 64-bit hosts, you can force it by setting GYP_DEFINES=target_arch=ia32 in the environment. FYI, I think $GYP_DEFINES overrides ~/.gyp/includes.gypi. You may get unexpected results

[chromium-dev] Re: Scalability

2009-10-12 Thread Lei Zhang
Maybe you need to clobber? The shared build bot on the FYI waterfall is working: http://build.chromium.org/buildbot/waterfall.fyi/builders/Chromium%20Linux%20Builder%20(dbg-shlib)/builds/1069 On Mon, Oct 12, 2009 at 6:23 PM, Jacob Mandelson ja...@mandelson.org wrote: On Wed, Oct 07, 2009 at

[chromium-dev] Re: Unkown Error During Building Chromium for Linux

2009-10-06 Thread Lei Zhang
It looks as though you didn't save stderr, only stdout, so the logs do not contain any actual error messages. 2009/10/5 Ujjwol (उज्जवल लामिछाने) ujjwollamichh...@gmail.com: While building chromium in Fedora 10, a strange build error has been encountered. The tail of the log of build(hammer

[chromium-dev] Re: Who owns crash...@chromium.org and why is there so many updates from it?

2009-10-06 Thread Lei Zhang
maruel, I think he's working on decreasing that number. On Tue, Oct 6, 2009 at 6:51 PM, John Abd-El-Malek j...@chromium.org wrote: I got 21 emails in the last day for http://code.google.com/p/chromium/issues/detail?id=20915 --~--~-~--~~~---~--~~ Chromium

[chromium-dev] Re: Who owns crash...@chromium.org and why is there so many updates from it?

2009-10-06 Thread Lei Zhang
Oh sorry, I was thinking of buildbot@ On Tue, Oct 6, 2009 at 6:57 PM, Lei Zhang thes...@chromium.org wrote: maruel, I think he's working on decreasing that number. On Tue, Oct 6, 2009 at 6:51 PM, John Abd-El-Malek j...@chromium.org wrote: I got 21 emails in the last day for http

[chromium-dev] Re: NaCl on Linux/x86-64?

2009-09-30 Thread Lei Zhang
On Wed, Sep 30, 2009 at 11:23 AM, spotrh spo...@gmail.com wrote: On 09/30/2009 01:58 PM, Lei Zhang wrote: Have you tried installing glibc-devel/i586? No, because the resulting binaries wouldn't really be x86_64, would they? :) Native client is trying to build 32-bit binaries, even on x86_64

[chromium-dev] Re: NaCl on Linux/x86-64?

2009-09-30 Thread Lei Zhang
On Wed, Sep 30, 2009 at 2:06 PM, spotrh spo...@gmail.com wrote: On 09/30/2009 04:34 PM, Lei Zhang wrote: On Wed, Sep 30, 2009 at 11:23 AM, spotrh spo...@gmail.com wrote: On 09/30/2009 01:58 PM, Lei Zhang wrote: Have you tried installing glibc-devel/i586? No, because the resulting binaries

[chromium-dev] Re: Chromium Without SSe2

2009-09-23 Thread Lei Zhang
Google Chrome builds without SSE2. On Wed, Sep 23, 2009 at 11:16 AM, Dan Kegel d...@kegel.com wrote: Oddly, I can still install fine on my pentium III laptop, I think. On Wed, Sep 23, 2009 at 11:02 AM, Evan Martin e...@chromium.org wrote: The code doesn't lie:           'conditions': [  

[chromium-dev] Re: Is it possible to customize CXXFLAGS and CFLAGS when generating make file or invoking make?

2009-09-22 Thread Lei Zhang
Looks like both CXXFLAGS=foo make and CXXFLAGS=foo hammer ignore CXXFLAGS. Is this by design? On Tue, Sep 22, 2009 at 12:07 AM, James Su su...@chromium.org wrote: Hi,   I'd like to compile chromium with some special CFLAGS/CXXFLAGS, how can I do? I'm using make build on 64bit Linux. Regards

[chromium-dev] Re: [Green Tree] Week 1

2009-09-21 Thread Lei Zhang
Of the three slowest tests as of last week, two has been fixed (thanks to evan and jcampan) and the third one has a fix being reviewed. The Linux trybots build almost as fast as the Mac trybots now, thanks to shared ccache with a ~80% cache hit rate. Windows trybots are still struggling - taking

[chromium-dev] Handling bad permissions for browser profile data

2009-09-18 Thread Lei Zhang
Normally users have access to their profile data, but there are mis-configure systems where this assumption does not hold. This leads to weird behavior and bizarre bugs. I feel we need more sanity checks and warn users that their profile data is messed up. In bug 7733, a user wrote: I found the

[chromium-dev] Re: Dashboard to show which UI/unit/etc (non-webkit) tests are slowest

2009-09-17 Thread Lei Zhang
How often is this updated? How many runs does it look at to calculate the test run times? On Thu, Sep 17, 2009 at 8:52 AM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: The slowness dashboard is ready at http://build.chromium.org/buildbot/slowness-report/ There are some problems with it

[chromium-dev] Re: Linux HTML5, List of Libraries

2009-09-08 Thread Lei Zhang
Chromium is currently 32-bit x86 only ... sounds like we need to update the build instructions for 64-bit. On Tue, Sep 8, 2009 at 11:47 AM, Evan Martine...@chromium.org wrote: If http://code.google.com/p/chromium/wiki/LinuxBuildInstructionsPrerequisites doesn't answer your question, please

[chromium-dev] Re: buildbot bisect script

2009-09-03 Thread Lei Zhang
I've heard a few complains of I cannot bisect because the archive does not go that far back. Are we tight on storage? It would be nice if we can keep more of the continuous builds around. On Thu, Sep 3, 2009 at 10:30 AM, Evan Martine...@chromium.org wrote: I feel a couple of people have

[chromium-dev] Re: Cross-compiling on ARM

2009-08-25 Thread Lei Zhang
On Mon, Aug 24, 2009 at 6:22 PM, Antoine Labourpi...@chromium.org wrote: On Mon, Aug 24, 2009 at 1:53 PM, Scott Hesssh...@chromium.org wrote: Would it be possible/reasonable to use distcc plus a farm of cross-compiler machines to let you do faster self-hosted builds?  It's not the right

[chromium-dev] Re: Cross-compiling on ARM

2009-08-21 Thread Lei Zhang
On Fri, Aug 21, 2009 at 2:25 PM, Dean McNameede...@chromium.org wrote: On Fri, Aug 21, 2009 at 1:43 PM, Antoine Labour pi...@google.com wrote: - Gyp uses pkg-config to find includes/lib dependencies, i.e. it's going to look at the host for them. If your target distribution matches your host

[chromium-dev] Chromium / Google Summer of Code

2009-08-21 Thread Lei Zhang
With the Google Summer of Code program winding down, I'm curious how our GSoC participants are doing. Can the students and their mentors share their experiences? (Assuming you're all done with evaluations and all that.) --~--~-~--~~~---~--~~ Chromium Developers

[chromium-dev] Re: FYI: XP unit purify bot broken

2009-08-19 Thread Lei Zhang
+1 for splitting unit_tests. On Linux, it's possible to generate a 2.3GB unit_tests binary that won't run. X-( On Wed, Aug 19, 2009 at 4:12 PM, Erik Kayerik...@chromium.org wrote: The XP unit Purify bot has been failing for the last week or so. Unfortunately, this has turned out to be more

[chromium-dev] Re: To get your work onto 3.0 stable

2009-08-18 Thread Lei Zhang
Question, have all the strings been translated? I tried Spanish and saw some untranslated stuff, i.e. IDS_OPEN_FILE_DIALOG_TITLE, IDS_OMNIBOX_SEARCH_HINT_INFOBAR_TEXT, and IDS_BLACKLIST_MESSAGE. I think these all made it in before the deadline. On Wed, Aug 12, 2009 at 12:52 PM, Glen

[chromium-dev] Re: [Linux] switching from hammer to make as the default build tool

2009-08-17 Thread Lei Zhang
On Mon, Aug 17, 2009 at 3:00 PM, Antoine Labourpi...@google.com wrote: On Mon, Aug 17, 2009 at 2:07 PM, Lei Zhangthes...@chromium.org wrote: Hi, On Linux, building with make is a lot faster than build with hammer. Ever since I switched to the make build on Linux, I've never looked back. I

[chromium-dev] Re: Tree hygiene

2009-08-14 Thread Lei Zhang
Do we have a warning for when the difference between the ToT revision number and LKGR pass a certain threshold? On Fri, Aug 14, 2009 at 8:00 AM, Marc-Antoine Ruelmar...@chromium.org wrote: - The reliability test has been red for so long that a bad regression hasn't been noticed before it was

[chromium-dev] Re: gyp failing while triggering gclient sync in linux with git

2009-08-06 Thread Lei Zhang
Working ok here with svn and the make build. On Thu, Aug 6, 2009 at 8:58 PM, Mohamed Mansourm0.interact...@gmail.com wrote: Tonight I was trying to sync my project so I did git pull and it worked fine, then I did gclient sync as well as --force. But gyp is failing:

[chromium-dev] Re: FYI: a new problem with the latest patch for 2008 SP1 (from today/yesterday)

2009-07-29 Thread Lei Zhang
I assume there's a similar patch for VS2005SP1. Does that have the same problem? On Wed, Jul 29, 2009 at 11:15 AM, nakroyoav.zilberb...@gmail.com wrote: if you get the latest patch of VS2008SP1 (released yesterday) you will not be able to compile chrome you will get errors relating to

[chromium-dev] Re: memory leak in the jpeg_codec.cc

2009-07-02 Thread Lei Zhang
It probably needs to be converted into a scoped_array like in JPEGCodec::Decode. Can you file a bug for this on http://crbug.com/ ? On Thu, Jul 2, 2009 at 5:59 AM, runtimerun_t...@tut.by wrote: Hi There is memory leak in the module jpeg_codec.cc, member function bool JPEGCodec::Encode(const

[chromium-dev] Re: how to judge layouttests' running result?

2009-06-25 Thread Lei Zhang
http://dev.chromium.org/developers/testing/webkit-layout-tests says: ./run_webkit_tests.sh LayoutTests/path/to/your/test.html --full-results-html will produce a page including links to the expected result, actual result, and diff. Does that help? 2009/6/25 David Jones ds...@163.com: I have

[chromium-dev] Re: Error While compiling on ubuntu 64bit

2009-06-22 Thread Lei Zhang
You need to give more info. What revision of the source code are you at? Did you make any local changes? FWIW, we have a Jaunty build bot on the experimental waterfall and it built ok. http://build.chromium.org/buildbot/waterfall.fyi/builders/Chromium%20Linux%20(Jaunty)/builds/1981 On Mon, Jun

[chromium-dev] Re: Pixel layout tests and checksums

2009-06-22 Thread Lei Zhang
I noticed this too. LayoutTests/fast/transforms/matrix-02.html has been marked fail for a while on Linux because the checksum is different from Windows, even though the output pngs are identical. On Mon, Jun 22, 2009 at 10:24 AM, Evan Martine...@chromium.org wrote: Since I'm waiting for a

[chromium-dev] Re: Memory usage in chrome

2009-06-21 Thread Lei Zhang
FYI, --single-process only works in Chromium. It's disabled in Google Chrome. Search for switches::kSingleProcess in http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_dll_main.cc?revision=18801view=markup On Sun, Jun 21, 2009 at 4:22 PM, estelectronix...@gmail.com wrote: use

[chromium-dev] Re: --single-process not working with Chrome 2.0?

2009-06-02 Thread Lei Zhang
It's always disabled in Chrome. It's all in the source code. See [1] line ~416. You can use Google Code Search to grep the code more quickly. For instance, if you search for single_process, you'll end up on [2] and oh look at the first result! [1]

[chromium-dev] Re: Tool to dump out the render tree for chromium

2009-05-23 Thread Lei Zhang
The test shell has a dump render tree function under the debug menu. Does that help? On Sat, May 23, 2009 at 12:36 AM, Daniel Dreiberg daniel.dreiber...@gmail.com wrote: Hi, Is there any tool to dump out the render tree for chromium? I would like to pass an url (e.g. www.google.com), it dumps

[chromium-dev] Re: i would like to help code chrome.. but i have some compilation issues (and unittest)

2009-05-12 Thread Lei Zhang
On Tue, May 12, 2009 at 6:19 AM, nakro yoav.zilberb...@gmail.com wrote: the other thing, is that after i modify it the unit tests fail [  PASSED  ] 864 tests. [  FAILED  ] 1 test, listed below: [  FAILED  ] URLFetcherBadHTTPSTest.BadHTTPSTest  1 FAILED TEST  YOU HAVE 19 DISABLED TESTS See

[chromium-dev] Re: No more local copy of WebCore and JavaScriptCore!

2009-05-08 Thread Lei Zhang
On Fri, May 8, 2009 at 10:20 AM, Dan Kegel daniel.r.ke...@gmail.com wrote: On Fri, May 8, 2009 at 10:16 AM, Darin Fisher da...@chromium.org wrote: gclient sync now crashes for me: That's unfortunate... I wonder what is different about your setup.  The buildbots and trybots and my personal

[chromium-dev] Re: Getting LOG(INFO) to print

2009-05-07 Thread Lei Zhang
I'm having the opposite problem. I did a release build on Linux, and I get tons of INFO spew. --log-level=N for N 0 doesn't turn it off. On Wed, Apr 22, 2009 at 11:37 AM, Evan Martin e...@chromium.org wrote: Since Pinkerton just lost some hours to this and I did again: The secret to getting

[chromium-dev] Re: gcl and git-cl brokenness

2009-04-21 Thread Lei Zhang
I reverted r14094. On Tue, Apr 21, 2009 at 4:39 PM, Evan Martin e...@chromium.org wrote: Since it's been asked about 10 times in the channel so far: - gcl is broken in some way where it thinks PRESUBMIT.py is a changelist. Workaround is to remove .svn/gcl_entries/PRESUBMIT.py .  Lei is

[chromium-dev] Re: ResourceMessageFilter::OnGet(Root)WindowRect and NULL windows

2009-03-19 Thread Lei Zhang
#include stdio.h #include windows.h int main() { HWND hwnd = GetAncestor(NULL, GA_PARENT); printf(%p\n, hwnd); hwnd = GetAncestor(NULL, GA_ROOT); printf(%p\n, hwnd); hwnd = GetAncestor(NULL, GA_ROOTOWNER); printf(%p\n, hwnd); hwnd = GetAncestor(NULL, 0); printf(%p\n, hwnd);

[chromium-dev] Re: NSS and NSPR

2009-02-25 Thread Lei Zhang
BTW, we have both src/third_party/nss/ and src/base/third_party/nss/. On Wed, Feb 25, 2009 at 5:04 PM, Thomas Van Lenten thoma...@chromium.org wrote: Sorry for arriving late w/ this question... I'm guessing NSS NSPR are needed for the linux build?  Should they be pulled in via DEPS instead

[chromium-dev] Re: thread_collision_warning error on build bot?

2009-02-12 Thread Lei Zhang
I've seen it happen a couple times on Windows with the trybots this week. (and only this week) On Thu, Feb 12, 2009 at 8:20 AM, Thomas Van Lenten thoma...@chromium.org wrote: Before I start digging, anyone seen this failure before (one mac build bot hit it today): [ RUN ]

[chromium-dev] Re: Claimings

2009-02-09 Thread Lei Zhang
We're trying out a spreadsheet on the Linux side. http://spreadsheets.google.com/ccc?key=prV2wWigilGslQBvu76GpQQ On Mon, Feb 9, 2009 at 3:37 PM, John Grabowski j...@chromium.org wrote: (We talked about a spreadsheet for this... anyone have a link?) I'm following the chain from rtn on URL in

[chromium-dev] Re: Don't include render_messages.h in a header

2009-02-05 Thread Lei Zhang
On Thu, Feb 5, 2009 at 4:21 PM, James Vega vega.ja...@gmail.com wrote: On Thu, Feb 05, 2009 at 04:04:58PM -0800, Peter Kasting wrote: On Thu, Feb 5, 2009 at 4:02 PM, Erik Kay erik...@chromium.org wrote: $ scons_deps -v target foo.c:inc.h:a.h foo.c:inc.h:b.h bar.c:bar.h etc. Does