[chromium-dev] Re: Minor proposed changes to page actions API

2009-07-13 Thread Aaron Boodman
On Mon, Jul 13, 2009 at 1:46 PM, Evan Martine...@chromium.org wrote: On Mon, Jul 13, 2009 at 1:44 PM, Aaron Boodmana...@chromium.org wrote: Increased awesomeness, shorter, more descriptive method names. Also it seems like having a utility function lying around that can decode a user-supplied

[chromium-dev] Re: Minor proposed changes to page actions API

2009-07-13 Thread Erik Kay
On Mon, Jul 13, 2009 at 1:44 PM, Aaron Boodman a...@chromium.org wrote: I'd like to close on some mumbling we've been doing about changes to the page actions API. What: * Make it not required to pre-specify this icon list in the manifest. This will require some refactoring to the utility

[chromium-dev] Re: Minor proposed changes to page actions API

2009-07-13 Thread Aaron Boodman
On Mon, Jul 13, 2009 at 2:09 PM, Erik Kayerik...@chromium.org wrote: It seems reasonable, but I have some questions / concerns: - How/where are the resulting images cached?  We don't want each request to have to be reencoded.  In the current install model, they're simply encoded in place.

[chromium-dev] Re: Minor proposed changes to page actions API

2009-07-13 Thread Erik Kay
On Mon, Jul 13, 2009 at 2:20 PM, Aaron Boodman a...@chromium.org wrote: On Mon, Jul 13, 2009 at 2:09 PM, Erik Kayerik...@chromium.org wrote: It seems reasonable, but I have some questions / concerns: - How/where are the resulting images cached? We don't want each request to have to be

[chromium-dev] Re: Minor proposed changes to page actions API

2009-07-13 Thread Aaron Boodman
On Mon, Jul 13, 2009 at 4:08 PM, Erik Kayerik...@chromium.org wrote: We'd probably need to store the list of sanitized images in prefs to avoid the extra stat for every image, but OK. There's on extra stat, read, and write the first time an image is used. This does not seem like a big deal to

[chromium-dev] Re: Minor proposed changes to page actions API

2009-07-13 Thread Erik Kay
On Mon, Jul 13, 2009 at 4:12 PM, Aaron Boodman a...@chromium.org wrote: On Mon, Jul 13, 2009 at 4:08 PM, Erik Kayerik...@chromium.org wrote: We'd probably need to store the list of sanitized images in prefs to avoid the extra stat for every image, but OK. There's on extra stat, read, and