[chromium-dev] Re: Remove svn from deps/third_party?

2009-04-23 Thread Darin Fisher
IIRC, some people (peter?) have had /usr/bin/svn on their path ahead of depot_tools, since they don't want our svn interfering with their webkit checkout. this used to work if you always accessed our svn by calling gvn instead (yes, i meant gvn). i believe that gcl, like gvn, will also pass

[chromium-dev] Re: Remove svn from deps/third_party?

2009-04-23 Thread Nicolas Sylvain
On Wed, Apr 22, 2009 at 11:13 PM, Darin Fisher da...@chromium.org wrote: IIRC, some people (peter?) have had /usr/bin/svn on their path ahead of depot_tools, since they don't want our svn interfering with their webkit checkout. this used to work if you always accessed our svn by calling gvn

[chromium-dev] Re: Remove svn from deps/third_party?

2009-04-23 Thread Marc-Antoine Ruel
I'm simply removing the references (there's 2) to third_party/svn/svn. Once that's done, I'll remove it some time after. If the tree can open, I'll check-in http://codereview.chromium.org/92074 On Thu, Apr 23, 2009 at 9:51 AM, Nicolas Sylvain nsylv...@chromium.orgwrote: On Wed, Apr 22, 2009

[chromium-dev] Re: Remove svn from deps/third_party?

2009-04-23 Thread Marc-Antoine Ruel
http://src.chromium.org/viewvc/chrome?view=revrevision=14312 It's now a warning in normal build to not have svn in the path, it's an error for official builds. Hopefully, I didn't break anything at the same time... On Thu, Apr 23, 2009 at 11:54 AM, Marc-Antoine Ruel mar...@chromium.orgwrote:

[chromium-dev] Re: Remove svn from deps/third_party?

2009-04-23 Thread Marc-Antoine Ruel
It's being worked on at this very moment. I implements a forth solution: - update.bat sense if svn/python is already installed (with nifty trick), and only install its own copy if not found. Also, I removing the linux/mac/win branches in depot_tools. I should check-in the first draft tomorrow.

[chromium-dev] Re: Remove svn from deps/third_party?

2009-04-23 Thread Nicolas Sylvain
On Thu, Apr 23, 2009 at 1:42 PM, Marc-Antoine Ruel mar...@chromium.orgwrote: Mainly scons but it's not an issue anymore. All the buildbot scripts are using the third_party\python one. It has some sitelib installed that are required, and that are not present in the depot_tools. We would need

[chromium-dev] Re: Remove svn from deps/third_party?

2009-04-22 Thread Adam Barth
Sounds good to me. (Although if I had my way, we'd check the entire toolchain into SVN, gcc and all.) Adam On Wed, Apr 22, 2009 at 9:58 PM, Mark Larson (Google) m...@chromium.org wrote: I filed http://bugs.chromium.org/10872 for this... From src/chrome/tools/build/win/version.bat: ::