jam++
Great stuff! I like how this is integrated. It feels very natural.
Erik
On Tue, Dec 16, 2008 at 8:16 PM, John Abd-El-Malek j...@chromium.org wrote:
Just a heads-up that I've integrated the script into our Rietveld
instance. If you use gcl, it will ping the server at a special url
Would be nice to make a gcl lint feature :)
gcl lint [mychangelist] before we submit it to codereview
On Wed, Dec 17, 2008 at 1:33 PM, Marc-Antoine Ruel mar...@chromium.orgwrote:
Yep, that's simple and neat
On Wed, Dec 17, 2008 at 1:29 PM, Erik Kay erik...@chromium.org wrote:
jam++
Awesome! I love lint!
On Wed, Dec 17, 2008 at 10:36 AM, Mohamed Mansour
m0.interact...@gmail.comwrote:
Would be nice to make a gcl lint feature :)
gcl lint [mychangelist] before we submit it to codereview
On Wed, Dec 17, 2008 at 1:33 PM, Marc-Antoine Ruel mar...@chromium.orgwrote:
Yep,
Awesome! Thanks John. Trailing whitespace be gone!
On Tue, Dec 16, 2008 at 8:16 PM, John Abd-El-Malek j...@chromium.org wrote:
Just a heads-up that I've integrated the script into our Rietveld
instance. If you use gcl, it will ping the server at a special url
after a patchset upload so
Awesome John, will save a lot of time for those reviewers. So I assume this
is only for Google code style, webkit patches reviews will always display an
error since they have a different style.
On Tue, Dec 16, 2008 at 11:20 PM, Adam Barth aba...@chromium.org wrote:
Awesome! Thanks John.
On Tue, Dec 16, 2008 at 8:26 PM, Mohamed Mansour
m0.interact...@gmail.com wrote:
Awesome John, will save a lot of time for those reviewers. So I assume this
is only for Google code style, webkit patches reviews will always display an
error since they have a different style.
That's correct.
I did an internal search and the current state is:
- Folks have been looking at open sourcing cpplint
- In its current incarnation, there is a lot of google-specific checks
that needs to be factored out simply because they don't apply to
external and open source projects.
- Nobody actually took
It doesn't need to be a parser, it's just a linter. You don't really
need to understand anything about the program to give useful warnings
about style. Our biggest style violation is probably trailing
whitespace, for example.
On Thu, Dec 4, 2008 at 7:33 PM, Benjamin [EMAIL PROTECTED] wrote:
Sorry to be a pest, but has there been any progress on this?
Thanks,
Marshall
On Thu, Sep 18, 2008 at 4:17 PM, Pam Greene [EMAIL PROTECTED] wrote:
On Thu, Sep 18, 2008 at 12:00 PM, Marshall Greenblatt
[EMAIL PROTECTED] wrote:
Hi Mark/Pam,
On Thu, Sep 18, 2008 at 2:48 PM, Mark Mentovai
I'll ask around and see if I can find one we can open-source.
- Pam
On Thu, Sep 18, 2008 at 7:06 AM, Marshall Greenblatt
[EMAIL PROTECTED] wrote:
Hi All,
Does a tool currently exist for verifying and/or formatting source code
based on the Google style guide? If not, has any thought been
On Thu, Sep 18, 2008 at 12:00 PM, Marshall Greenblatt
[EMAIL PROTECTED] wrote:
Hi Mark/Pam,
On Thu, Sep 18, 2008 at 2:48 PM, Mark Mentovai [EMAIL PROTECTED] wrote:
Great question. We've been talking about open-sourcing something for
this, but so far, we don't have anything yet. We do have
11 matches
Mail list logo
