On Wed, Aug 12, 2009 at 5:49 PM, Darin Fisher da...@chromium.org wrote:
Yes, sorry about that. Please see render_view.cc. They are just
implemented using WebFrame::executeCommand.
Ah, I see. As an API consumer I would prefer to have separate methods for
each supported command, or have
Yeah, I agree. Those are problems. However, the intent is to match the set
of commands reachable by script. The values for execCommand are well
known.
I also worry about having to keep the WebKit API in sync with WebCore.
I agree that selectAll should be dropped in favor of
If I understand correctly, selectAll() and executeCommand(SelectAll) are
different. The first one selects all text in the frame, while the second one
selects all text in an editor (input box).
Regards
James Su
2009/8/14 Darin Fisher da...@chromium.org
Yeah, I agree. Those are problems.
Oh, good catch. If that is indeed the case, then eliminating
WebFrame::selectAll would be a mistake.-Darin
On Thu, Aug 13, 2009 at 9:58 AM, James Su su...@chromium.org wrote:
If I understand correctly, selectAll() and executeCommand(SelectAll) are
different. The first one selects all text in
On Thu, Aug 13, 2009 at 12:58 PM, James Su su...@chromium.org wrote:
If I understand correctly, selectAll() and executeCommand(SelectAll) are
different. The first one selects all text in the frame, while the second one
selects all text in an editor (input box).
Ok :-) Can we document this in
On Thu, Aug 13, 2009 at 1:07 PM, Darin Fisher da...@chromium.org wrote:
Hmm... take a look at EditorCommands.cpp. The executeSelectAll method just
calls frame-selection()-selectAll(). That's the same method that
WebFrameImpl::selectAll() calls.
I just verified this in the debugger -- the
http://code.google.com/p/chromium/issues/detail?id=19270
(patches welcome!)
On Thu, Aug 13, 2009 at 3:35 PM, James Su su...@chromium.org wrote:
Oh yes, you are right. So it might be safe to remove selectAll().
Regards
James Su
2009/8/14 Marshall Greenblatt magreenbl...@gmail.com
On Thu,
