Re: [chromium-dev] Modifying .gyp files

2009-12-27 Thread Igor Gatis
Really? At least, it does not seem to be the case for make generator. There are no rules for handling .proto files in make generator. That's actually what I've been trying to do in the last couple of days. On Sun, Dec 27, 2009 at 12:47 PM, Mark Mentovai m...@chromium.org wrote: Igor Gatis wrote:

Re: [chromium-dev] Modifying .gyp files

2009-12-27 Thread Mark Mentovai
Igor Gatis wrote: Really? At least, it does not seem to be the case for make generator. There are no rules for handling .proto files in make generator. That's actually what I've been trying to do in the last couple of days. GYP rules are something that you have to write yourself, there aren't

Re: [chromium-dev] Modifying .gyp files

2009-12-27 Thread Igor Gatis
Great, just wrote a rule for that. I placed it on the final target of my project. What would be nice is to define such rule on the protobuf library gyp and export it. It seems this file does

Re: [chromium-dev] Modifying .gyp files

2009-12-27 Thread Mark Mentovai
Igor Gatis igorga...@gmail.com wrote: Great, just wrote a rule for that. I placed it on the final target of my project. What would be nice is to define such rule on the protobuf library gyp and export it. It seems this file does that. But when I try doing the same, I get the following error:

Re: [chromium-dev] Modifying .gyp files

2009-12-26 Thread Igor Gatis
I used a custom action with success and I believe that sounds better for module updates purposes. We used to do things like that in the pre-GYP days.  When we moved our builds over to GYP, we decided that it wasn't anywhere near worthwhile.  It inflated build times (autoconf's configure is

Re: [chromium-dev] Modifying .gyp files

2009-12-26 Thread PhistucK
http://code.google.com/p/gyp/issues/list http://code.google.com/p/gyp/issues/listSearch for the issue or create a new one. ☆PhistucK On Sun, Dec 27, 2009 at 04:08, Igor Gatis igorga...@gmail.com wrote: I used a custom action with success and I believe that sounds better for module

Re: [chromium-dev] Modifying .gyp files

2009-12-11 Thread Igor Gatis
You mean they were manually pre-created, right? I used a custom action with success and I believe that sounds better for module updates purposes. Perhaps we should consider adding a new target type, say, 'config', which would invoke configure automatically. On Fri, Dec 11, 2009 at 12:07 PM,

Re: [chromium-dev] Modifying .gyp files

2009-12-11 Thread Mark Mentovai
Igor Gatis wrote: You mean they were manually pre-created, right? Yes I used a custom action with success and I believe that sounds better for module updates purposes. We used to do things like that in the pre-GYP days. When we moved our builds over to GYP, we decided that it wasn't

Re: [chromium-dev] Modifying .gyp files

2009-12-10 Thread Igor Gatis
Thanks Mark. BTW, do you guys know of lists or wiki I could get more information regarding GYP tool? On Wed, Dec 9, 2009 at 5:40 PM, Mark Mentovai m...@chromium.org wrote: There's better info in gclient.py, as a comment. Maybe we can just rip this off and stick it in a web page somewhere on

Re: [chromium-dev] Modifying .gyp files

2009-12-10 Thread Marc-Antoine Ruel
http://code.google.com/p/gyp has some wiki pages. On Thu, Dec 10, 2009 at 10:49 AM, Igor Gatis igorga...@gmail.com wrote: Thanks Mark. BTW, do you guys know of lists or wiki I could get more information regarding GYP tool? On Wed, Dec 9, 2009 at 5:40 PM, Mark Mentovai m...@chromium.org

Re: [chromium-dev] Modifying .gyp files

2009-12-10 Thread Mikhail Naganov
http://code.google.com/p/gyp/w/list On Thu, Dec 10, 2009 at 18:49, Igor Gatis igorga...@gmail.com wrote: Thanks Mark. BTW, do you guys know of lists or wiki I could get more information regarding GYP tool? On Wed, Dec 9, 2009 at 5:40 PM, Mark Mentovai m...@chromium.org wrote: There's

Re: [chromium-dev] Modifying .gyp files

2009-12-09 Thread Igor Gatis
Is there documentation somewhere regarding gclient? I'd like to know more about how hooks and other gclient features work. On Tue, Dec 8, 2009 at 6:27 PM, Mark Mentovai mmento...@google.com wrote: Igor Gatis wrote: When I change a .gyp, do I need to call gyp or the build process does that

Re: [chromium-dev] Modifying .gyp files

2009-12-09 Thread Marc-Antoine Ruel
Humm, that's a good question. Right now the only doc is gclient help runhooks which is .. uh .. not really useful. M-A On Wed, Dec 9, 2009 at 3:28 PM, Igor Gatis igorga...@gmail.com wrote: Is there documentation somewhere regarding gclient? I'd like to know more about how hooks and other

Re: [chromium-dev] Modifying .gyp files

2009-12-09 Thread Mark Mentovai
There's better info in gclient.py, as a comment. Maybe we can just rip this off and stick it in a web page somewhere on the developer site. Hooks .gclient and DEPS files may optionally contain a list named hooks to allow custom actions to be performed based on files that have changed in the

Re: [chromium-dev] Modifying .gyp files

2009-12-08 Thread Mark Mentovai
Igor Gatis wrote: When I change a .gyp, do I need to call gyp or the build process does that for me? If it does, how does it detect the .gyp file has been modified? When you change it yourself, in your own working copy, you run gclient runhooks to get new files generated. When a .gyp change is

Re: [chromium-dev] Modifying .gyp files

2009-12-08 Thread Igor Gatis
Got it, thanks. BTW, it might be worth mentioning that somewhere, perhaps here: http://www.chromium.org/developers/quick-reference On Tue, Dec 8, 2009 at 6:27 PM, Mark Mentovai mmento...@google.com wrote: Igor Gatis wrote: When I change a .gyp, do I need to call gyp or the build process does

Re: [chromium-dev] Modifying .gyp files

2009-12-08 Thread Evan Martin
On Tue, Dec 8, 2009 at 12:23 PM, Igor Gatis igorga...@gmail.com wrote: When I change a .gyp, do I need to call gyp or the build process does that for me? If it does, how does it detect the .gyp file has been modified? On Linux, when you run make it will rerun gyp on your behalf if any gyp files