[chromium-dev] Re: Compile base_unittests fails

2009-07-13 Thread Evan Martin
On Sun, Jul 12, 2009 at 10:18 PM, Evan Martine...@chromium.org wrote: On Sun, Jul 12, 2009 at 8:38 PM, empriserxueyunl...@gmail.com wrote: third_party/dmg_fp/dtoa.cc: In function 'void dmg_fp::hexnan (dmg_fp::U*, const char**)': third_party/dmg_fp/dtoa.cc:1558: warning: array subscript has

[chromium-dev] Re: Compile base_unittests fails

2009-07-13 Thread Craig Schlenter
Hi I thought none of the hex stuff was supposed be compiled. Line 183 does #define NO_HEX_FP but there is some interesting interaction between INFNAN_CHECK, No_Hex_NaN and Need_Hexdig which might result in it compiling for you. Hmmm Try adding #define No_Hex_Nan after #define NO_HEX_FP

[chromium-dev] Re: Compile base_unittests fails

2009-07-13 Thread Craig Schlenter
On Mon, Jul 13, 2009 at 8:34 AM, Craig Schlentercraig.schlen...@gmail.com wrote: Hi I thought none of the hex stuff was supposed be compiled. Line 183 does #define NO_HEX_FP but there is some interesting interaction between INFNAN_CHECK, No_Hex_NaN and Need_Hexdig which might result in it

[chromium-dev] Re: changing chrome_exe to chrome, converting chrome.exe to gyp

2009-07-13 Thread Bradley Nelson
There are a certainly performance bugaboos at the moment (I've been keeping your email in my inbox as a reminder :-) )One thing just jumped out at me though, the environment variable we're checking for cores on windows in NUMBER_OF_PROCESSORS, not NUM_CPUS (at least for the makefile step in

[chromium-dev] Re: Compile base_unittests fails

2009-07-13 Thread Craig Schlenter
Hi If your compiler is that old btw, then it may help to poke at the list below and see what else you need to update: http://code.google.com/p/chromium/wiki/LinuxBuildInstructionsPrerequisites Hopefully all those warnings will go away with something a bit more modern ... --Craig On Mon, Jul

[chromium-dev] Re: some questions about chrome's layout-test

2009-07-13 Thread Jickae Davis
hi, dave. I think you're right. I ran the layout-test, and got the same result as yours. I mean, I also got a lot of ERRORs as you described. And I think most of these ERRORs are expected. To your situation, the 9 unexpected + sum of expected = the sum of ERRORs you get in your DOS. 2009/7/9

[chromium-dev] New path service constants

2009-07-13 Thread Thomas Van Lenten
If you are adding new path service constants as part of a new feature (ie-adding new directories to the install footprint or a new data dir for storing things in), please make sure you include someone for each platform in the review and call out what the path is for. We've had a few paths added

[chromium-dev] Improving power usage

2009-07-13 Thread Joel Stanley
Hello, I'm a Summer of Code student working with Dean. My interests are the Linux port, specifically ensuring Chromium behaves well on low spec machines. So far I've spent my 'summer' (it's winter here in Australia) on the ARM port of Chromium. As of the recent v8 gyp changes, the tree can

[chromium-dev] Re: base::string16 / WebCore::String incompatibility

2009-07-13 Thread Brett Wilson
On Fri, Jul 10, 2009 at 5:04 PM, Jeremy Orlowjor...@chromium.org wrote: WebCore::String has the interesting property of differentiating between an empty string and a null string. In string16, however, there is no such thing as null. The LocalStorage implementation I'm working on proxies data

Fwd: [chromium-dev] Improving power usage

2009-07-13 Thread Ryosuke Niwa
-- Forwarded message -- From: Ryosuke Niwa rn...@google.com Date: Mon, Jul 13, 2009 at 8:34 AM Subject: Re: [chromium-dev] Improving power usage To: j...@jms.id.au Hi, I think there was a recent discussion regarding performance, in which someone suggested to suspend inactive

[chromium-dev] Re: base::string16 / WebCore::String incompatibility

2009-07-13 Thread Darin Fisher
On Mon, Jul 13, 2009 at 8:20 AM, Brett Wilson bre...@chromium.org wrote: On Fri, Jul 10, 2009 at 5:04 PM, Jeremy Orlowjor...@chromium.org wrote: WebCore::String has the interesting property of differentiating between an empty string and a null string. In string16, however, there is no such

[chromium-dev] Re: middle click on home

2009-07-13 Thread Amanda Walker
On Fri, Jun 26, 2009 at 8:22 PM, Peter Kastingpkast...@google.com wrote: Given that there are a large number of ways to open the home page in a new foreground tab (e.g. ctrl-t + click, shift-middle click, etc.), there are a very large number of other places in the UI where middle-click opens a

[chromium-dev] Re: Improving power usage

2009-07-13 Thread Evan Martin
On Mon, Jul 13, 2009 at 9:22 AM, Evan Martine...@chromium.org wrote: As we're multi process with Chrome we could instead suspend any background renderers, plugin and extension processes without affecting the foreground tabs. One piece to look at is the code that calls

[chromium-dev] Re: Improving power usage

2009-07-13 Thread Peter Kasting
On Mon, Jul 13, 2009 at 9:22 AM, Evan Martin e...@chromium.org wrote: I think it'd be pretty interesting to fully suspend background tabs, but doing it safely is likely tricky. For example, imagine a page that has Javascript that is driving a Flash plugin playing background music. For a

[chromium-dev] Re: middle click on home

2009-07-13 Thread Peter Kasting
On Mon, Jul 13, 2009 at 9:21 AM, Amanda Walker ama...@chromium.org wrote: --Amanda (who still prefers foreground tabs, but will just resort to open in new window instead) Shift-middle or shift-control click. (All browsers I've tested support this.) PK

[chromium-dev] Re: middle click on home

2009-07-13 Thread Glen Murphy
Actually, I take that back.  I could swear they did, but I am evidently wrong (after just checking a few). Never mind :-). I believe some used to - the context menu entry was going to be our foreground-opening UI, but lots of people use it and expect background-opening.

[chromium-dev] Re: middle click on home

2009-07-13 Thread Evan Martin
On Mon, Jul 13, 2009 at 9:55 AM, Glen Murphyg...@chromium.org wrote: Actually, I take that back.  I could swear they did, but I am evidently wrong (after just checking a few). Never mind :-). I believe some used to - the context menu entry was going to be our foreground-opening UI, but

[chromium-dev] Re: base::string16 / WebCore::String incompatibility

2009-07-13 Thread Jeremy Orlow
On Mon, Jul 13, 2009 at 8:59 AM, Darin Fisher da...@chromium.org wrote: On Mon, Jul 13, 2009 at 8:20 AM, Brett Wilson bre...@chromium.org wrote: On Fri, Jul 10, 2009 at 5:04 PM, Jeremy Orlowjor...@chromium.org wrote: WebCore::String has the interesting property of differentiating between an

[chromium-dev] Re: base::string16 / WebCore::String incompatibility

2009-07-13 Thread Brett Wilson
On Mon, Jul 13, 2009 at 10:05 AM, Jeremy Orlowjor...@chromium.org wrote: On Mon, Jul 13, 2009 at 8:59 AM, Darin Fisher da...@chromium.org wrote: On Mon, Jul 13, 2009 at 8:20 AM, Brett Wilson bre...@chromium.org wrote: On Fri, Jul 10, 2009 at 5:04 PM, Jeremy Orlowjor...@chromium.org wrote:

[chromium-dev] Re: Improving power usage

2009-07-13 Thread Peter Kasting
On Mon, Jul 13, 2009 at 10:05 AM, Scott Hess sh...@chromium.org wrote: On Mon, Jul 13, 2009 at 9:37 AM, Peter Kastingpkast...@chromium.org wrote: For a common real-life example people want to work, imagine having Pandora open in a background tab. People expect it to keep playing music.

[chromium-dev] Re: base::string16 / WebCore::String incompatibility

2009-07-13 Thread Jeremy Orlow
On Mon, Jul 13, 2009 at 10:08 AM, Brett Wilson bre...@chromium.org wrote: On Mon, Jul 13, 2009 at 10:05 AM, Jeremy Orlowjor...@chromium.org wrote: On Mon, Jul 13, 2009 at 8:59 AM, Darin Fisher da...@chromium.org wrote: On Mon, Jul 13, 2009 at 8:20 AM, Brett Wilson bre...@chromium.org

[chromium-dev] Re: base::string16 / WebCore::String incompatibility

2009-07-13 Thread Scott Hess
On Mon, Jul 13, 2009 at 10:10 AM, Jeremy Orlowjor...@chromium.org wrote: On Mon, Jul 13, 2009 at 10:08 AM, Brett Wilson bre...@chromium.org wrote: Yes, I think NullableString16 is better than passing a separate bool. Can anyone think of a better name for it? What's wrong with

[chromium-dev] Re: Improving power usage

2009-07-13 Thread Craig Schlenter
On Mon, Jul 13, 2009 at 6:22 PM, Evan Martine...@chromium.org wrote: [snip] One piece to look at is the code that calls SetProcessBackgrounded(), which on Windows marks the process as one that can be paged out but on Linux is not implemented.  I don't know how it decides it's ok to do that,

[chromium-dev] Re: base::string16 / WebCore::String incompatibility

2009-07-13 Thread Jeremy Orlow
All right. NullableString16 it is. :-) And, in case it's not clear, this will only be for strings that have a valid null state. The common case should still be using string16. J On Mon, Jul 13, 2009 at 10:23 AM, Scott Hess sh...@chromium.org wrote: On Mon, Jul 13, 2009 at 10:10 AM, Jeremy

[chromium-dev] running layout_tests on vista and windows 7

2009-07-13 Thread Dirk Pranke
Hi all, (If you don't ever care to run the webkit layout tests, you can skip this note). As most of you are no doubt aware, we currently can only run the webkit layout_tests on windows XP. For some of us who primarily develop on 64-bit Vista, this is inconvenient at best, and this is only going

[chromium-dev] Re: base::string16 / WebCore::String incompatibility

2009-07-13 Thread Darin Fisher
On Mon, Jul 13, 2009 at 12:29 PM, Jeremy Orlow jor...@chromium.org wrote: On Mon, Jul 13, 2009 at 12:20 PM, David Levin le...@google.com wrote: On Mon, Jul 13, 2009 at 8:59 AM, Darin Fisher da...@chromium.org wrote: WebString exists (has for many moons now). It is just a wrapper for

[chromium-dev] Re: base::string16 / WebCore::String incompatibility

2009-07-13 Thread Jeremy Orlow
On Mon, Jul 13, 2009 at 12:54 PM, Darin Fisher da...@chromium.org wrote: On Mon, Jul 13, 2009 at 12:29 PM, Jeremy Orlow jor...@chromium.orgwrote: On Mon, Jul 13, 2009 at 12:20 PM, David Levin le...@google.com wrote: On Mon, Jul 13, 2009 at 8:59 AM, Darin Fisher da...@chromium.orgwrote:

[chromium-dev] Re: running layout_tests on vista and windows 7

2009-07-13 Thread Dirk Pranke
Yup, I've already adopted that. Thanks! On Mon, Jul 13, 2009 at 12:55 PM, Thomas Van Lententhoma...@chromium.org wrote: Quick skimmed reply: Mac already has expectations per OS where we need them, so you might be able to follow that basic model (and maybe small tweaks to the scripts to use

[chromium-dev] Re: running layout_tests on vista and windows 7

2009-07-13 Thread Julie Parent
On Mon, Jul 13, 2009 at 1:16 PM, Dirk Pranke dpra...@google.com wrote: Yup, I've already adopted that. Thanks! On Mon, Jul 13, 2009 at 12:55 PM, Thomas Van Lententhoma...@chromium.org wrote: Quick skimmed reply: Mac already has expectations per OS where we need them, so you might be

[chromium-dev] Re: Let's make build system history!

2009-07-13 Thread Dimitri Glazkov
bump. On Wed, Feb 25, 2009 at 2:27 PM, Mark Mentovaim...@chromium.org wrote: Over the past month, some of us have been working on a not-so-well-kept secret project to create a build system system. Our goal is to have something Generate Your Projects (GYP) in a variety of formats, all from

[chromium-dev] Minor proposed changes to page actions API

2009-07-13 Thread Aaron Boodman
I'd like to close on some mumbling we've been doing about changes to the page actions API. What: * Make it not required to pre-specify this icon list in the manifest. This will require some refactoring to the utility process to be able to use it to decode images at any time, not just install

[chromium-dev] Re: Moving LayoutTests to src/third_party/WebKit

2009-07-13 Thread Victor Wang
Hi, LayoutTests has been moved from webkit/data to third_party/WebKit. You should sync your client and do the following after sync: -. If your client excludes LayoutTests, remove the following line from .gclient file after sync. No need to have the old one anymore.

[chromium-dev] Re: Minor proposed changes to page actions API

2009-07-13 Thread Aaron Boodman
On Mon, Jul 13, 2009 at 1:46 PM, Evan Martine...@chromium.org wrote: On Mon, Jul 13, 2009 at 1:44 PM, Aaron Boodmana...@chromium.org wrote: Increased awesomeness, shorter, more descriptive method names. Also it seems like having a utility function lying around that can decode a user-supplied

[chromium-dev] Re: Minor proposed changes to page actions API

2009-07-13 Thread Erik Kay
On Mon, Jul 13, 2009 at 1:44 PM, Aaron Boodman a...@chromium.org wrote: I'd like to close on some mumbling we've been doing about changes to the page actions API. What: * Make it not required to pre-specify this icon list in the manifest. This will require some refactoring to the utility

[chromium-dev] Re: Minor proposed changes to page actions API

2009-07-13 Thread Aaron Boodman
On Mon, Jul 13, 2009 at 2:09 PM, Erik Kayerik...@chromium.org wrote: It seems reasonable, but I have some questions / concerns: - How/where are the resulting images cached?  We don't want each request to have to be reencoded.  In the current install model, they're simply encoded in place.

[chromium-dev] Re: running layout_tests on vista and windows 7

2009-07-13 Thread Tony Chang
(This time using a reply-all) We used to do this for things like faking font metrics. It resulted in lots of if (webkit_glue::IsLayoutTestMode()) code. We moved away from it because it made it made the code more complicated and meant we weren't shipping the code we were testing. I've heard it

[chromium-dev] Re: base::string16 / WebCore::String incompatibility

2009-07-13 Thread Darin Fisher
On Mon, Jul 13, 2009 at 12:59 PM, Jeremy Orlow jor...@chromium.org wrote: On Mon, Jul 13, 2009 at 12:54 PM, Darin Fisher da...@chromium.org wrote: On Mon, Jul 13, 2009 at 12:29 PM, Jeremy Orlow jor...@chromium.orgwrote: On Mon, Jul 13, 2009 at 12:20 PM, David Levin le...@google.com wrote:

[chromium-dev] area:webkit fixit week!

2009-07-13 Thread Darin Fisher
This week is fixit week for bugs in area:webkit. Normally, a fixit week is about getting around to fixing all of the various P3 bugs that have accumulated, but this week we're also including the crash bugs, because frankly... there are a lot of them, and I think we could use the extra focus on

[chromium-dev] Re: Minor proposed changes to page actions API

2009-07-13 Thread Erik Kay
On Mon, Jul 13, 2009 at 2:20 PM, Aaron Boodman a...@chromium.org wrote: On Mon, Jul 13, 2009 at 2:09 PM, Erik Kayerik...@chromium.org wrote: It seems reasonable, but I have some questions / concerns: - How/where are the resulting images cached? We don't want each request to have to be

[chromium-dev] Re: Minor proposed changes to page actions API

2009-07-13 Thread Aaron Boodman
On Mon, Jul 13, 2009 at 4:08 PM, Erik Kayerik...@chromium.org wrote: We'd probably need to store the list of sanitized images in prefs to avoid the extra stat for every image, but OK. There's on extra stat, read, and write the first time an image is used. This does not seem like a big deal to

[chromium-dev] Re: Minor proposed changes to page actions API

2009-07-13 Thread Erik Kay
On Mon, Jul 13, 2009 at 4:12 PM, Aaron Boodman a...@chromium.org wrote: On Mon, Jul 13, 2009 at 4:08 PM, Erik Kayerik...@chromium.org wrote: We'd probably need to store the list of sanitized images in prefs to avoid the extra stat for every image, but OK. There's on extra stat, read, and

[chromium-dev] Re: Moving LayoutTests to src/third_party/WebKit

2009-07-13 Thread Peter Kasting
On Mon, Jul 13, 2009 at 1:45 PM, Victor Wang vict...@chromium.org wrote: LayoutTests has been moved from webkit/data to third_party/WebKit. You should sync your client and do the following after sync: Reminder: if you don't have layout tests in your client, *before sync* you need to add:

[chromium-dev] Re: Moving LayoutTests to src/third_party/WebKit

2009-07-13 Thread Andrew Scherkus
Since Subversion checkouts are hermetic, you can save yourself a ton time if you manually move your LayoutTest directory to the new location before running gclient sync. On Mon, Jul 13, 2009 at 5:05 PM, Peter Kasting pkast...@google.com wrote: On Mon, Jul 13, 2009 at 1:45 PM, Victor Wang

[chromium-dev] Re: Working on a new feature? Add extensions support.

2009-07-13 Thread Darin Fisher
What is the review process for new extension APIs? -Darin On Mon, Jul 13, 2009 at 5:17 PM, Erik Kay erik...@chromium.org wrote: If you're not working on any new features or new UI, you can probably skip the rest of this email. If you are, then please take the time to think about whether